From: Marek Szyprowski <m.szyprowski@samsung.com>
To: "'Mark Brown'" <broonie@opensource.wolfsonmicro.com>
Cc: linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.arm.linux.org.uk,
"'Liam Girdwood'" <lrg@slimlogic.co.uk>,
kyungmin.park@samsung.com
Subject: RE: [PATCH] LP3971 PMIC regulator driver
Date: Thu, 14 May 2009 17:09:17 +0200 [thread overview]
Message-ID: <000001c9d4a6$003f2e10$00bd8a30$%szyprowski@samsung.com> (raw)
In-Reply-To: <20090514095700.GA28291@sirena.org.uk>
Hello!
On Thu, May 14, 2009 Mark Brown wrote:
> > This patch adds regulator drivers for National Semiconductors LP3971
> PMIC.
> > This LP3971 PMIC controller has 3 DC/DC voltage converters and 5 low
> drop-out
> > (LDO) regulators. LP3971 PMIC controller uses I2C interface.
> >
> > Reviewed-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
>
> This looks basically good, a few comments below but personally I'd be
> inclined to merge this as-is and deal with the remaining issues as
> separate patches so:
>
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
>
> It'd be good to also implement list_voltage().
Ok. I will prepare a new patches that will add this functionality and fix
issues reported below.
> > + if (reg <= BUCK_TARGET_VOL_MAX_IDX)
> > + val = 1000 * buck_voltage_map[reg];
> > + else
> > + val = 0;
>
> I'd expect some kind of warning to be displayed here?
Right.
> > + /* Detect LP3971 (initial system control 1 reg is '0x60') */
> > + ret = lp3971_i2c_read(i2c, LP3971_SYS_CONTROL1_REG, 1, &val);
> > + if (ret < 0) {
> > + dev_err(&i2c->dev, "failed to detect device\n");
> > + goto err_detect;
> > + }
> > +
>
> You don't actually appear to check the value you read back here?
Right, I forgot. Now I noticed in the chip spec that some default bits can
be eeprom programmed. I will handle this too.
Thanks for your review.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2009-05-14 15:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-14 7:33 Marek Szyprowski
2009-05-14 9:57 ` Mark Brown
2009-05-14 15:09 ` Marek Szyprowski [this message]
2009-05-18 10:10 ` Liam Girdwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001c9d4a6$003f2e10$00bd8a30$%szyprowski@samsung.com' \
--to=m.szyprowski@samsung.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®