From: Jingoo Han <jg1.han@samsung.com>
To: "'Jingoo Han'" <jg1.han@samsung.com>,
"'Samuel Ortiz'" <sameo@linux.intel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: twl4030-madc: add __exit macro to remove
Date: Wed, 20 Feb 2013 19:46:31 +0900 [thread overview]
Message-ID: <000001ce0f57$8b237050$a16a50f0$%han@samsung.com> (raw)
In-Reply-To: <000101ce0e3d$9a9e42a0$cfdac7e0$%han@samsung.com>
On Tuesday, February 19, 2013 10:08 AM, Jingoo Han wrote:
>
> Fixed build warning as below:
>
> drivers/mfd/twl4030-madc.c:788:12: warning: 'twl4030_madc_remove' defined but not used [-Wunused-
> function]
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/mfd/twl4030-madc.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/mfd/twl4030-madc.c b/drivers/mfd/twl4030-madc.c
> index 88ff9dc..86ba920 100644
> --- a/drivers/mfd/twl4030-madc.c
> +++ b/drivers/mfd/twl4030-madc.c
> @@ -785,7 +785,7 @@ err_power:
> return ret;
> }
>
> -static int twl4030_madc_remove(struct platform_device *pdev)
> +static int __exit twl4030_madc_remove(struct platform_device *pdev)
> {
> struct twl4030_madc_data *madc = platform_get_drvdata(pdev);
Removing __exit_p() would be better.
I will send V2 patch.
>
> --
> 1.7.2.5
next prev parent reply other threads:[~2013-02-20 10:46 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-19 1:08 Jingoo Han
2013-02-20 10:46 ` Jingoo Han [this message]
2013-02-20 10:52 ` [PATCH v2] mfd: twl4030-madc: remove erroneous __exit_p() in twl4030_madc_driver Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001ce0f57$8b237050$a16a50f0$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®