From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754157AbbHYBlJ (ORCPT <rfc822;w@1wt.eu>);
	Mon, 24 Aug 2015 21:41:09 -0400
Received: from mailout1.samsung.com ([203.254.224.24]:48604 "EHLO
	mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751580AbbHYBlH (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 24 Aug 2015 21:41:07 -0400
X-AuditID: cbfee61b-f79706d000001b96-57-55dbc7b07165
From: Chao Yu <chao2.yu@samsung.com>
To: "'Jaegeuk Kim'" <jaegeuk@kernel.org>
Cc: linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
References: <001b01d0de51$0b369c70$21a3d550$@samsung.com>
 <20150824165423.GC2837@jaegeuk-mac02.mot-mobility.com>
In-reply-to: <20150824165423.GC2837@jaegeuk-mac02.mot-mobility.com>
Subject: RE: [PATCH 2/2] f2fs: fix to release inode correctly
Date: Tue, 25 Aug 2015 09:39:55 +0800
Message-id: <000001d0ded7$1aa9e0a0$4ffda1e0$@samsung.com>
MIME-version: 1.0
Content-type: text/plain; charset=us-ascii
Content-transfer-encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-index: AQIO0Bg33esmKHUsU90kfH4EvwCJ2AJRWsg+nY11sXA=
Content-language: zh-cn
X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrILMWRmVeSWpSXmKPExsVy+t9jAd0Nx2+HGtyewG/xZP0sZotLi9wt
	Lu+aw+bA7LFpVSebx+4Fn5k8Pm+SC2CO4rJJSc3JLEst0rdL4MrovfyUteAIV8Xuh5eZGhi7
	OLoYOTkkBEwkvh04wgZhi0lcuLcezBYSWMooMXeDUBcjF5D9ilHi1eTT7CAJNgEVieUd/5lA
	bBEBNYnefVPAbGYBD4nGju+sEM1FErevLASLcwo4S/w6twKsV1jAVuLih6dACzg4WARUJb4d
	MgIJ8wpYSnw7284MYQtK/Jh8jwVipJbE+p3HocbLS2xe85YZ4k4FiR1nXzOCjBERsJKY97gU
	okRcYuORWywTGIVmIZk0C8mkWUgmzULSsoCRZRWjRGpBckFxUnquUV5quV5xYm5xaV66XnJ+
	7iZGcMA/k97BeHiX+yFGAQ5GJR7eDwtvhwqxJpYVV+YeYpTgYFYS4X2+ESjEm5JYWZValB9f
	VJqTWnyIUZqDRUmcV99kU6iQQHpiSWp2ampBahFMlomDU6qBUV58xZ7K9CrBvxUOB6//nujr
	PjnQe4kN94Elz1U+6HIrea7p/PRJ84hnAm/alp99jXvsdl9l4Wiasv3LHLGpypN+/t8ZnjLL
	iMFv8TT75zMddwW98I+OcT7xwWuVWuIRfaGH52fsX2Cx+YTAXpmKn+eWzp+Zu8xR71R/67PJ
	q14Uvg80dbp0/bESS3FGoqEWc1FxIgCzb+zFdAIAAA==
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Hi Jaegeuk,

> -----Original Message-----
> From: Jaegeuk Kim [mailto:jaegeuk@kernel.org]
> Sent: Tuesday, August 25, 2015 12:54 AM
> To: Chao Yu
> Cc: linux-f2fs-devel@lists.sourceforge.net; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 2/2] f2fs: fix to release inode correctly
> 

[snip]

> > +	 * if we skip truncate_node in remove_inode_page bacause we failed
> > +	 * before, it's better to find another way to release resource of
> > +	 * this inode (e.g. valid block count, node block or nid). Here we
> > +	 * choose to add this inode to orphan list, so that we can call iput
> > +	 * for releasing in orphan recovery flow.
> > +	 *
> > +	 * Note: we should add inode to orphan list before f2fs_unlock_op()
> > +	 * so we can prevent losing this orphan when encoutering checkpoint
> > +	 * and following suddenly power-off.
> > +	 */
> > +	if (err && err != -ENOENT) {
> > +		err = acquire_orphan_inode(sbi);
> > +		if (!err)
> > +			add_orphan_inode(sbi, inode->i_ino);
> 
> 		Need this too?
> 
> 		if (err)
> 			set_sbi_flag(sbi, SBI_NEED_FSCK);

We have another chance to release inode resource in following path:
 - handle_failed_inode
  - iput
   - f2fs_evict_inode
    - f2fs_truncate
    - remove_inode_page

So I choose to set SBI_NEED_FSCK in the end of f2fs_evict_inode.

Thanks,