From: "Zhang Zhuoyu" <zhangzhuoyu@cmss.chinamobile.com>
To: "'David Disseldorp'" <ddiss@suse.de>
Cc: <nab@linux-iscsi.org>, <linux-scsi@vger.kernel.org>,
<target-devel@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH 1/1] target:separate tx/rx cmd_puds
Date: Sun, 8 Apr 2018 11:57:18 +0800 [thread overview]
Message-ID: <000001d3ceed$b0d9c870$128d5950$@cmss.chinamobile.com> (raw)
In-Reply-To: <20180406140934.2dfafd45@suse.de>
> -----Original Message-----
> From: David Disseldorp [mailto:ddiss@suse.de]
> Sent: Friday, April 6, 2018 8:10 PM
> To: Zhang Zhuoyu <zhangzhuoyu@cmss.chinamobile.com>
> Cc: nab@linux-iscsi.org; linux-scsi@vger.kernel.org; target-
> devel@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: Re: [PATCH 1/1] target:separate tx/rx cmd_puds
>
> On Thu, 5 Apr 2018 13:12:12 +0200, David Disseldorp wrote:
>
> > > -CONFIGFS_ATTR_RO(target_stat_tgt_port_, in_cmds);
> > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, tx_cmds);
> > > +CONFIGFS_ATTR_RO(target_stat_tgt_port_, rx_cmds);
> >
> > I don't think the in_cmds metric should be deleted here. It could be
> > calculated on the fly via tx_cmds + rx_cmds + nodata_cmds.
>
> @Zhang Zhuoyu: How about something like the following?
> https://git.samba.org/?p=ddiss/linux.git;a=commitdiff;h=73723ccf433424721
> 830797d70cfb88d4596e0fc
>
Mmm... This patch is much better.
Looks good to me.
Zhuoyu
> ...this keeps the in_cmds metric, and renames tx/rx_cmds read/write_cmds
> respectively. read/write_cmds is still a bit ambiguous, as it refers to
the
> command data direction rather than SCSI READ/WRITE CDBs, but IMO it's
> clearer, and more consistent with the read/write_mbytes metrics.
>
> Cheers, David
prev parent reply other threads:[~2018-04-08 4:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 9:52 Zhang Zhuoyu
2018-04-05 11:12 ` David Disseldorp
2018-04-06 12:09 ` David Disseldorp
2018-04-08 3:57 ` Zhang Zhuoyu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d3ceed$b0d9c870$128d5950$@cmss.chinamobile.com' \
--to=zhangzhuoyu@cmss.chinamobile.com \
--cc=ddiss@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®