From: David Wang <davidwang@zhaoxin.com>
To: 'Thomas Gleixner' <tglx@linutronix.de>
Cc: <mingo@redhat.com>, <hpa@zytor.com>, <gregkh@linuxfoundation.org>,
<x86@kernel.org>, <linux-kernel@vger.kernel.org>,
<brucechang@via-alliance.com>, <cooperyan@zhaoxin.com>,
<qiyuanwang@zhaoxin.com>, <benjaminpan@viatech.com>,
<lukelin@viacpu.com>, <timguo@zhaoxin.com>
Subject: Re: [PATCH v3] report correct CPU/cache topology
Date: Wed, 2 May 2018 15:14:35 +0800 [thread overview]
Message-ID: <000001d3e1e5$39b15640$ad1402c0$@zhaoxin.com> (raw)
> -----Original Mail-----
> Sender: Thomas Gleixner [mailto:tglx@linutronix.de]
> Time: 2018年4月26日 19:56
> Receiver: David Wang <davidwang@zhaoxin.com>
> CC: mingo@redhat.com; hpa@zytor.com; gregkh@linuxfoundation.org;
> x86@kernel.org; linux-kernel@vger.kernel.org; brucechang@via-
> alliance.com; cooperyan@zhaoxin.com; qiyuanwang@zhaoxin.com;
> benjaminpan@viatech.com; lukelin@viacpu.com; timguo@zhaoxin.com
> Subject: Re: [PATCH v3] report correct CPU/cache topology
>
>
>
> On Thu, 26 Apr 2018, David Wang wrote:
>
> > Centaur CPUs enumerate the cache topology in the same way as Intel
> > CPUs, but the function is unused so far.
> > The Centaur init code also misses to initialize x86_info::max_cores,
> > so the CPU topology can't be described correctly.
> >
> > Initialize x86_info::max_cores and invoke init_intel_cachinfo() to
> > make CPU and cache topology information avaliable and correct
>
> Now that looks pretty good.
>
> > Signed-off-by: David Wang <davidwang@zhaoxin.com>
> >
> > Changes from v2 to v3:
> > *1 define new detect_num_cpu_cores() in common.c to replace the
> > original intel_num_cpu_cores;
> > *2 move cpu_detect_cache_sizes inside init_intel_cacheinfo.
>
> But I asked for that being a separate patch with a separate changelog. And
> the intel_cache_info() change wants to be in a separate patch as well.
Then
> the third patch is the one which makes use of these changes for centaur.
>
> Please read review comments carefully and rather ask when you have
> doubts about the meaning.
>
> Thanks,
>
> tglx
>
Sorry!
I will split the changes to three separate patches.
Thank you.
---
David
next reply other threads:[~2018-05-02 7:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 7:14 David Wang [this message]
-- strict thread matches above, loose matches on Subject: below --
2018-04-26 10:47 David Wang
2018-04-26 11:56 ` Thomas Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000001d3e1e5$39b15640$ad1402c0$@zhaoxin.com' \
--to=davidwang@zhaoxin.com \
--cc=benjaminpan@viatech.com \
--cc=brucechang@via-alliance.com \
--cc=cooperyan@zhaoxin.com \
--cc=gregkh@linuxfoundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukelin@viacpu.com \
--cc=mingo@redhat.com \
--cc=qiyuanwang@zhaoxin.com \
--cc=tglx@linutronix.de \
--cc=timguo@zhaoxin.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®