From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1EDBA1E50B for ; Mon, 21 Jul 2025 08:37:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.24 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753087031; cv=none; b=eBlO+/UlUHpr8Lkq9yLylLv34vqRn2OjHBkYD//ez53o2s3M1Xj/fWtYN3iVdxPabToHAUj3ERfByWMyqWYvyn4NrOF/xCIwU1R0q3cd0kBJjgAOn+KstBJOcyTnGxWxc7EDHjUojDkso+5hxqCKSDRHZGe7QhYY4z408OG4GNo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1753087031; c=relaxed/simple; bh=Rl1YOas+fgdSq/Kvz1mZmGoA1VVRBztEtrYFaM8Wj+Y=; h=From:To:Cc:In-Reply-To:Subject:Date:Message-ID:MIME-Version: Content-Type:References; b=fvQqEO4X1NKHOeBbJmJ4NaQWKiscnwV1EJhLSaGT2bHfjJHs2JuZuicpTqyG/VXGznaGYL4+fAlEXX73V3nI89o9q7aTC2X0d7agzkLToZ6Z0r9I4vHNjnHS0PcX8B5ekfXdPDke+2+2IU2hUdRxJjnecTqkel3w5NLA2/2mreI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=lRB2y0Gv; arc=none smtp.client-ip=203.254.224.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="lRB2y0Gv" Received: from epcas2p2.samsung.com (unknown [182.195.41.54]) by mailout1.samsung.com (KnoxPortal) with ESMTP id 20250721083706epoutp01ce7c50e74b9ed087874aa6df1d243d8d~UN1zHCmxm0973109731epoutp01X for ; Mon, 21 Jul 2025 08:37:06 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.samsung.com 20250721083706epoutp01ce7c50e74b9ed087874aa6df1d243d8d~UN1zHCmxm0973109731epoutp01X DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1753087026; bh=YG4PKzlB/k2XkqqC2Fwg1WOfj+qB+gJoAcf5VPjR4+U=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=lRB2y0GvimRKVWaKamok++pKVj5e28SutJY7wV34/xAvQ9YesFbDN2mol+rIhOW/n 5dPU3YSpoDgH1cD70AIPf+KTNgITzTT4GXITt/MA0gXvEHyOMNiD7HB2T2GHHt0gHA Ihblk1X8gHPnhAMEzgEkevl5euvQ0AC86pBSDqIw= Received: from epsnrtp03.localdomain (unknown [182.195.42.155]) by epcas2p1.samsung.com (KnoxPortal) with ESMTPS id 20250721083705epcas2p1ef23d8a6ab218eff2aecac29da62ea1d~UN1yixB0L0843808438epcas2p1U; Mon, 21 Jul 2025 08:37:05 +0000 (GMT) Received: from epcas2p1.samsung.com (unknown [182.195.36.100]) by epsnrtp03.localdomain (Postfix) with ESMTP id 4blv012mR6z3hhT4; Mon, 21 Jul 2025 08:37:05 +0000 (GMT) Received: from epsmtip1.samsung.com (unknown [182.195.34.30]) by epcas2p3.samsung.com (KnoxPortal) with ESMTPA id 20250721083704epcas2p3a89014b76970287dfaf58634370050c6~UN1xI70750668906689epcas2p37; Mon, 21 Jul 2025 08:37:04 +0000 (GMT) Received: from KORCO118546 (unknown [12.36.150.57]) by epsmtip1.samsung.com (KnoxPortal) with ESMTPA id 20250721083704epsmtip183eb0ff8b1d8a430baeee8173a410623~UN1xDxi5y2989629896epsmtip1p; Mon, 21 Jul 2025 08:37:04 +0000 (GMT) From: "hoyoung seo" To: "'Christoph Hellwig'" Cc: , , , , , , , , , , , , , , , In-Reply-To: Subject: RE: [PATCH v1] writback: remove WQ_MEM_RECLAIM flag in bdi_wq Date: Mon, 21 Jul 2025 17:37:03 +0900 Message-ID: <000001dbfa1a$a2a1ad80$e7e50880$@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGsuCKma20p4qExdocLsEkdiKd5rQFAzVkXAhcIlgS0gAXygA== Content-Language: ko X-CMS-MailID: 20250721083704epcas2p3a89014b76970287dfaf58634370050c6 X-Msg-Generator: CA X-Sendblock-Type: AUTO_CONFIDENTIAL CMS-TYPE: 102P X-CPGSPASS: Y cpgsPolicy: CPGSC10-234,Y X-CFilter-Loop: Reflected X-CMS-RootMailID: 20250721062037epcas2p25fd6fcf66914a419ceefca3285ea09f3 References: <20250721064024.113841-1-hy50.seo@samsung.com> > -----Original Message----- > From: Christoph Hellwig > Sent: Monday, July 21, 2025 4:14 PM > To: hy50.seo > Cc: linux-scsi@vger.kernel.org; linux-kernel@vger.kernel.org; > alim.akhtar@samsung.com; avri.altman@wdc.com; jejb@linux.ibm.com; > martin.petersen@oracle.com; beanhuo@micron.com; bvanassche@acm.org; > kwangwon.min@samsung.com; kwmad.kim@samsung.com; cpgs@samsung.com; > h10.kim@samsung.com; willdeacon@google.com; jaegeuk@google.com; > chao@kernel.org; linux-fsdevel@vger.kernel.org > Subject: Re: [PATCH v1] writback: remove WQ_MEM_RECLAIM flag in bdi_wq > > On Mon, Jul 21, 2025 at 03:40:24PM +0900, hy50.seo wrote: > > if it write with the write back option with f2fs, kernel panic occurs. > > Because the write back function uses bdi_wq and WQ_MEM_RECLAIM flag is > > included and created. > > However, this function calls f2fs_do_quota() of f2fs and finally tries > > to perform quota_release_work. > > the quota_release_work is performed in the events_unbound workqueue, > > but the WQ_MEM_RECLAIM flag is not included. > > And what makes you assume the WQ_MEM_RECLAIM was added just for fun and > can simply be deleted? No way.. It's because i just don't know much about this part. And WQ_MEM_RECLAIM flag is absolutely necessary. Because it is necessary for stable write back operation when memory is insufficient. is it right? I'll find another way for fix bug. Thanks for your reply.