From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Zach Brown'" <zach.brown@oracle.com>
Cc: "'Andrew Morton'" <akpm@osdl.org>,
"'Suparna Bhattacharya'" <suparna@in.ibm.com>,
<linux-kernel@vger.kernel.org>, "linux-aio" <linux-aio@kvack.org>
Subject: RE: [patch] clean up unused kiocb variables
Date: Thu, 21 Sep 2006 13:26:20 -0700 [thread overview]
Message-ID: <000101c6ddbc$334248d0$ff0da8c0@amr.corp.intel.com> (raw)
In-Reply-To: <4512E910.6000308@oracle.com>
Zach Brown wrote on Thursday, September 21, 2006 12:34 PM
> Chen, Kenneth W wrote:
> > Any reason why we keep these two variables around for kiocb structure?
>
> If there is a good one I've forgotten it.
>
> > They are not used anywhere.
>
> Indeed.
Let's remove them. We can always add them back if there is a need.
> The ki_retried users all seem pretty questionable, too. How about
> removing all that stuff?
Suparna wanted them around for debug purpose at one point. I don't know
whether that is still the case right now. At least I can wrap it around
with #if DEBUG.
- Ken
next prev parent reply other threads:[~2006-09-21 20:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-21 18:53 Chen, Kenneth W
2006-09-21 19:33 ` Zach Brown
2006-09-21 20:26 ` Chen, Kenneth W [this message]
2006-09-21 20:30 ` Zach Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000101c6ddbc$334248d0$ff0da8c0@amr.corp.intel.com' \
--to=kenneth.w.chen@intel.com \
--cc=akpm@osdl.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=suparna@in.ibm.com \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome