From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758381AbcAUGRK (ORCPT ); Thu, 21 Jan 2016 01:17:10 -0500 Received: from mailuogwhop.emc.com ([168.159.213.141]:42527 "EHLO mailuogwhop.emc.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751254AbcAUGRH convert rfc822-to-8bit (ORCPT ); Thu, 21 Jan 2016 01:17:07 -0500 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd02.lss.emc.com u0L6Guxf000587 X-DKIM: OpenDKIM Filter v2.4.3 mailuogwprd02.lss.emc.com u0L6Guxf000587 From: "Allen Hubbe" To: "'Yu, Xiangliang'" , , , , Cc: "'SPG_Linux_Kernel'" References: <1453365583-9823-1-git-send-email-Xiangliang.Yu@amd.com> <000001d15405$24fe24a0$6efa6de0$@emc.com> In-Reply-To: Subject: RE: [PATCH V5 1/1] NTB: Add support for AMD PCI-Express Non-Transparent Bridge Date: Thu, 21 Jan 2016 01:16:41 -0500 Message-ID: <000101d15413$4c466a50$e4d33ef0$@emc.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-Index: AQHRU/2O8fezn5V8G0myVuK/t+aAYZ8FWL4AgAB0d4D//64SwA== Content-Language: en-us X-RSA-Classifications: public X-Sentrion-Hostname: mailuogwprd02.lss.emc.com Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Yu, Xiangliang [mailto:Xiangliang.Yu@amd.com] > > > Signed-off-by: Jon Mason > > > Signed-off-by: Allen Hubbe > > > > NO. > > Ok, I'll change it if you doesn't want to change it. Nah, just remember it for next time... I'm satisfied with this v5. Reviewed-by: Allen Hubbe > I don’t think so. In here, the i/o memory is only happened when > pci_iomap return > Success, so the register can't be accessed through IO port way. And > ioread* will > Check if the memory type is mmio type or IO port type (please see the > definition). > I don’t think we need to check It, so I use read* because It can make > more efficient. > I think we need to think about actual usage, not only follow book. > And, I have said it in previous version, I don’t like explain it again, > and again. > If you have any concern, please tell me after my comment. It's not more efficient, on this platform it's the same. If it were my driver I would change it... but you can keep it this way. > > This is different from v4. It used to be: > > Because peer_sta is change to 0, so amd_link_is_up will return 0 > (offline) > And will not check hardware link status. So It maybe make it offline > forever It fixed a bug? Great! > > I'm nervous about ndev->peer_sta, the behavior of link_is_up, > > timers... > > Actually, the code is designed according to Atom NTB, except for the > peer_sta. Except for peer_sta, and that's a pretty critical design change. I'm still nervous, but I'll trust that you have been able to test this behavior thourougly. > I'll add the explaination when having changes. Thanks. Allen