From: "Chen, Kenneth W" <kenneth.w.chen@intel.com>
To: "'Trond Myklebust'" <trond.myklebust@fys.uio.no>
Cc: "'Andrew Morton'" <akpm@osdl.org>, <linux-aio@kvack.org>,
"'xb'" <xavier.bru@bull.net>, <linux-kernel@vger.kernel.org>,
"'Zach Brown'" <zach.brown@oracle.com>
Subject: RE: 2.6.18.4: flush_workqueue calls mutex_lock in interruptenvironment
Date: Fri, 15 Dec 2006 10:58:28 -0800 [thread overview]
Message-ID: <000201c7207b$022f77c0$ff0da8c0@amr.corp.intel.com> (raw)
In-Reply-To: <1166191273.5761.18.camel@lade.trondhjem.org>
Trond Myklebust wrote on Friday, December 15, 2006 6:01 AM
> Oops. Missed the fact that you are removed the put_ioctx from
> aio_put_req, but the first sentence is still true. If you try to wake up
> wait_for_all_aios before you've changed the condition it is waiting for,
> then it may end up hanging forever.
The easy fix to that is to put wake_up in aio_complete inside the ctx spin
lock.
> Why not fix this by having the context freed via an RCU callback? That
> way you can protect the combined call to aio_put_req() +
> wake_up(ctx->wait) using a simple preempt_off/preempt_on, and all is
> good.
That has been suggested before on a different subject. I will whip up
something.
prev parent reply other threads:[~2006-12-15 18:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-12-15 6:35 2.6.18.4: flush_workqueue calls mutex_lock in interrupt environment Chen, Kenneth W
2006-12-15 13:49 ` Trond Myklebust
2006-12-15 14:01 ` Trond Myklebust
2006-12-15 18:58 ` Chen, Kenneth W [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000201c7207b$022f77c0$ff0da8c0@amr.corp.intel.com' \
--to=kenneth.w.chen@intel.com \
--cc=akpm@osdl.org \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
--cc=xavier.bru@bull.net \
--cc=zach.brown@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®