From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, "'Nick Piggin'" <npiggin@kernel.dk>,
Jingoo Han <jg1.han@samsung.com>
Subject: Re: [PATCH 3/3] block: brd: Staticize 'rd_size'
Date: Fri, 09 Aug 2013 15:07:46 +0900 [thread overview]
Message-ID: <000301ce94c6$c4d9da10$4e8d8e30$@samsung.com> (raw)
On Friday, August 09, 2013 1:07 PM, Jingoo Han wrote:
>
> 'rd_size' is used only in this file.
> Fix the following sparse warning:
>
> drivers/block/brd.c:432:5: warning: symbol 'rd_size' was not declared. Should it be static?
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/block/brd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Sorry, please ignore this patch.
It makes link error as below:
arch/arm/kernel/built-in.o: In function `parse_tag_ramdisk':
/home/jin9/mainline/linux-next_130806_sparse/arch/arm/kernel/atags_parse.c:103: undefined reference to `rd_size'
Best regards,
Jingoo Han
>
> diff --git a/drivers/block/brd.c b/drivers/block/brd.c
> index 9bf4371..650530ab 100644
> --- a/drivers/block/brd.c
> +++ b/drivers/block/brd.c
> @@ -429,7 +429,7 @@ static const struct block_device_operations brd_fops = {
> * And now the modules code and kernel interface.
> */
> static int rd_nr;
> -int rd_size = CONFIG_BLK_DEV_RAM_SIZE;
> +static int rd_size = CONFIG_BLK_DEV_RAM_SIZE;
> static int max_part;
> static int part_shift;
> module_param(rd_nr, int, S_IRUGO);
> --
> 1.7.10.4
next reply other threads:[~2013-08-09 6:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 6:07 Jingoo Han [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-08-09 4:06 Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000301ce94c6$c4d9da10$4e8d8e30$@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=npiggin@kernel.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome