From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DC16018052 for ; Mon, 23 Dec 2024 02:16:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=203.254.224.34 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734920181; cv=none; b=eiojyfThreOVwOqRo3yW1/f/Njjy/fKNrGZG4BZzFAS19cQhn2L6rgWJ+vLYiMnQHjd9Gy/Lr8g70BEFsX5QDmVWzcYorkarl0DYXE8AZbKSp8aRY9y5H9ciySfYkju36NLOR5zi6OZTpV5A+ltDK9L8+1qVx+/JUMGNs4l5ci4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1734920181; c=relaxed/simple; bh=YQcmJvgigbK/hIJBfKzM2/sEiuFnqI5+CH0DiwWAUgE=; h=From:To:Cc:In-Reply-To:Subject:Date:Message-ID:MIME-Version: Content-Type:References; b=DeWnb/ceACNpQy8TB2byPk7+aKBSDkWAolTR+I8g0YjmCwnmyD/bqMjWquQE/WzSXGOCJKMfgapD4rijV8jUFhncIbjhmA1ck/psX01RRXxa+ZSUOEMZkc/AowH24elC+LYO04Wc+QO8SkeYGXCh3RELZpGNP6ot3UCtLiiimvQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com; spf=pass smtp.mailfrom=samsung.com; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b=YlzUabXk; arc=none smtp.client-ip=203.254.224.34 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=samsung.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=samsung.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=samsung.com header.i=@samsung.com header.b="YlzUabXk" Received: from epcas5p3.samsung.com (unknown [182.195.41.41]) by mailout4.samsung.com (KnoxPortal) with ESMTP id 20241223021618epoutp04a3f012e1270fbc784e5c6eb4b4f0cd42~TrLXJWqbT3100031000epoutp04f for ; Mon, 23 Dec 2024 02:16:18 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout4.samsung.com 20241223021618epoutp04a3f012e1270fbc784e5c6eb4b4f0cd42~TrLXJWqbT3100031000epoutp04f DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1734920178; bh=YQcmJvgigbK/hIJBfKzM2/sEiuFnqI5+CH0DiwWAUgE=; h=From:To:Cc:In-Reply-To:Subject:Date:References:From; b=YlzUabXkwem9RVSNV6dKVRDxVMsou+nQUyCYVuOcxjQqyy3QtPPOefYvfC2IrfQ1a xn+wKRvxft2kqKwipodoU0M0GMUS633jZAG3YLr0tM3T+ghwRJS0IJUxQhnRyMjocG /88yCWJBqn0zr0OTYmg9v5KbqYOWG95qepycW5Q4= Received: from epsnrtp4.localdomain (unknown [182.195.42.165]) by epcas5p3.samsung.com (KnoxPortal) with ESMTP id 20241223021617epcas5p3af44cc8efef50bc0e33b70bea3c784d3~TrLW1CVvy0790107901epcas5p3e; Mon, 23 Dec 2024 02:16:17 +0000 (GMT) Received: from epsmges5p2new.samsung.com (unknown [182.195.38.175]) by epsnrtp4.localdomain (Postfix) with ESMTP id 4YGhTW52LSz4x9QN; Mon, 23 Dec 2024 02:16:15 +0000 (GMT) Received: from epcas5p1.samsung.com ( [182.195.41.39]) by epsmges5p2new.samsung.com (Symantec Messaging Gateway) with SMTP id 6C.2F.19933.FE7C8676; Mon, 23 Dec 2024 11:16:15 +0900 (KST) Received: from epsmtrp1.samsung.com (unknown [182.195.40.13]) by epcas5p1.samsung.com (KnoxPortal) with ESMTPA id 20241223021614epcas5p1ef33f9284b52f41ba66995aa96887d17~TrLT-X6ad0385503855epcas5p1p; Mon, 23 Dec 2024 02:16:14 +0000 (GMT) Received: from epsmgms1p1new.samsung.com (unknown [182.195.42.41]) by epsmtrp1.samsung.com (KnoxPortal) with ESMTP id 20241223021614epsmtrp1b4d98e5baee9eda91bc2f69af5486f77~TrLT_nEnF1803318033epsmtrp1H; Mon, 23 Dec 2024 02:16:14 +0000 (GMT) X-AuditID: b6c32a4a-b87c770000004ddd-9a-6768c7ef1da3 Received: from epsmtip2.samsung.com ( [182.195.34.31]) by epsmgms1p1new.samsung.com (Symantec Messaging Gateway) with SMTP id 60.43.18729.EE7C8676; Mon, 23 Dec 2024 11:16:14 +0900 (KST) Received: from INBRO001561 (unknown [107.122.12.6]) by epsmtip2.samsung.com (KnoxPortal) with ESMTPA id 20241223021612epsmtip27bd87ad893acbbb305281e943c1a3e56~TrLSHMa_g2025020250epsmtip2N; Mon, 23 Dec 2024 02:16:12 +0000 (GMT) From: "Pankaj Dubey" To: "'Rob Herring \(Arm\)'" , "'Lee Jones'" , "'Arnd Bergmann'" , "'Heiko Stuebner'" , "'Liviu Dudau'" , "'Sudeep Holla'" , "'Lorenzo Pieralisi'" Cc: "'Peter Griffin'" , "'Will McVicker'" , "'John Madieu'" , "'Krzysztof Kozlowski'" , , In-Reply-To: <20241217-syscon-fixes-v2-3-4f56d750541d@kernel.org> Subject: RE: [PATCH v2 3/3] mfd: syscon: Allow syscon nodes without a "syscon" compatible Date: Mon, 23 Dec 2024 07:46:11 +0530 Message-ID: <000301db54e0$a45912b0$ed0b3810$@samsung.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQEZrw4XBTjqISieS499QzyO27eqOgJo/DN3AoqOsky0TsZ5EA== Content-Language: en-us X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNJsWRmVeSWpSXmKPExsWy7bCmuu774xnpBv2HVS3+TjrGbvH/0WtW izUb6yz2vt7KbrGjbSGLxabH11gtLu+aw2ZxYGk7i0XLnxYWiw0z/rFY/N+zg91i+akdLBar Pv1ndOD1WDNvDaPH71+TGD1WvpjN7rFgU6nHplWdbB53ru1h89i8pN5j+7V5zB6fN8kFcEZl 22SkJqakFimk5iXnp2TmpdsqeQfHO8ebmhkY6hpaWpgrKeQl5qbaKrn4BOi6ZeYAXa2kUJaY UwoUCkgsLlbSt7Mpyi8tSVXIyC8usVVKLUjJKTAp0CtOzC0uzUvXy0stsTI0MDAyBSpMyM6Y sfEnY8FDoYql/28xNzBe4O9i5OSQEDCR2Hx9H2MXIxeHkMBuRonermssEM4nRomvF1+yQzjf GCW+H/rHAtPy72kHM0RiL6PEvgUn2SCcF4wS9/7cYwapYhPQlzj3Yx4rSEJEYDaTxO/Lk8Ec ZoFpTBIHty9kBaniFHCU2LroAzuILSwQLXGt9zPYDhYBVYm78yaBTeIVsJS4+38dO4QtKHFy 5hOwGmYBbYllC18zQ9ykIPHz6TKwmSICThLbn7SzQ9SIS7w8egTsCQmBBxwSD9snsUM0uEhc OtXMBmELS7w6vgUqLiXxsr8NyOYAsn0klu72gAiXSGzoWQr1v73EgStzWEBKmAU0Jdbv0odY xSfR+/sJE0Qnr0RHmxBEtZrE9+dnoK6UkXjYvJQJwvaQ2PLxLfMERsVZSB6bheSxWUgemIWw bAEjyypGydSC4tz01GLTAqO81HJ4jCfn525iBKdqLa8djA8ffNA7xMjEwXiIUYKDWUmEl0cu NV2INyWxsiq1KD++qDQntfgQoykwtCcyS4km5wOzRV5JvKGJpYGJmZmZiaWxmaGSOO/r1rkp QgLpiSWp2ampBalFMH1MHJxSDUwcpzpMd91cVbHkRFT1QeMZseuaWhJ7pO6b52fp/l2R+9T0 5aR12aoZja5nhOsMn05xMo3VaI3O3HOzxU749QZfL48nYTpzspiF++ZzyCXEyJ69Vtr+xj7p 1tllLA/3C2o+nRey9wNLu+lL99U986YumiLwySDORuzAF38nlpnlqhoG+U+Dnufylivlrwu9 X8Ec4Vu64oD3c5emSPbvJ985FzSwn7f/J5Qkoqp/7vvpDcZzfINVmdo7+tZvutVgIdfzTfDL klNx82N9pjbKG3lxfV1TcnaCn3HSucyfl1VWLZ2xeN9rBy9vpdTVnVNSMldJ2H6zvt/07Mik Gf4dxtNeFF094eA3lTWMU2KnkxJLcUaioRZzUXEiANnGBIdeBAAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrCIsWRmVeSWpSXmKPExsWy7bCSvO674xnpBku3aFr8nXSM3eL/o9es Fms21lnsfb2V3WJH20IWi02Pr7FaXN41h83iwNJ2FouWPy0sFhtm/GOx+L9nB7vF8lM7WCxW ffrP6MDrsWbeGkaP378mMXqsfDGb3WPBplKPTas62TzuXNvD5rF5Sb3H9mvzmD0+b5IL4Izi sklJzcksSy3St0vgylg66SlbwQqhigUXJzM3ME7l72Lk5JAQMJH497SDuYuRi0NIYDejxINn txghEjISk1evYIWwhSVW/nvODmILCTxjlHj9Mg/EZhPQlzj3Yx4rSLOIwEImiTcn5oM5zAKz mCS+b1nLCjH2OKPE1qbLYGM5BRwlti76ADZKWCBS4vr+U2ArWARUJe7Om8QMYvMKWErc/b+O HcIWlDg58wkLiM0soC3x9OZTOHvZwtfMEOcpSPx8ugxsjoiAk8T2J+3sEDXiEi+PHmGfwCg8 C8moWUhGzUIyahaSlgWMLKsYJVMLinPTc4sNCwzzUsv1ihNzi0vz0vWS83M3MYIjVktzB+P2 VR/0DjEycTAeYpTgYFYS4eWRS00X4k1JrKxKLcqPLyrNSS0+xCjNwaIkziv+ojdFSCA9sSQ1 OzW1ILUIJsvEwSnVwCTtw11mbL5Y6Y5i8C1hpwfmPbt8Zk0J29+3c1pvEmOY++kpBrkLzx2f uv0Ax2bpasl16w6kO5xb/6Nr08xg7vDvUlYbqpd0zFnZeEOXretLUOTtf+6SzlU7O73zDqid vfRGZFa44sm3nDqZXZsUXLYdW/5ugtnqmMUlixXN/uqXn5v2yq3zvcqLL3eKdq1mlLnhnhKR kSi36PiKhQlMqRMCtq40vMV29P9lpcSaeu6ixo4ys0lBooZT1X5c4LeW9qqX1M/Il/teOeHc VqPjL/hyee0fGT7X2j/X2OztVldZnw2zPU0ufHwXYbDpYcKO248v8s1oFvH5dEBHzGCF5Kv1 D9lWBvVMVWWJmXv36TUlluKMREMt5qLiRADHWEEORwMAAA== X-CMS-MailID: 20241223021614epcas5p1ef33f9284b52f41ba66995aa96887d17 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" CMS-TYPE: 105P DLP-Filter: Pass X-CFilter-Loop: Reflected X-CMS-RootMailID: 20241217181206epcas5p281ddcf5e06cf1d9a76eb101597d6980e References: <20241217-syscon-fixes-v2-0-4f56d750541d@kernel.org> <20241217-syscon-fixes-v2-3-4f56d750541d@kernel.org> > -----Original Message----- > From: Rob Herring (Arm) > Sent: Tuesday, December 17, 2024 11:42 PM > To: Lee Jones ; Arnd Bergmann ; Pankaj > Dubey ; Heiko Stuebner ; > Liviu Dudau ; Sudeep Holla ; > Lorenzo Pieralisi > Cc: Peter Griffin ; Will McVicker > ; John Madieu ; > Krzysztof Kozlowski ; linux- > kernel=40vger.kernel.org; linux-arm-kernel=40lists.infradead.org > Subject: =5BPATCH v2 3/3=5D mfd: syscon: Allow syscon nodes without a =22= syscon=22 > compatible >=20 > of_syscon_register_regmap() was added for nodes which need a custom regma= p > setup. It's not really correct for those nodes to claim they are compatib= le with > =22syscon=22 as the default handling likely doesn't work in those cases. = If > device_node_get_regmap() happens to be called first, then of_syscon_regis= ter() > will be called and an incorrect regmap will be created (barring some othe= r error). > That may lead to unknown results in the worst case. In the best case, > of_syscon_register_regmap() will fail with -EEXIST. This problem remains = unless > these cases drop =22syscon=22 (an ABI issue) or we exclude them using the= ir specific > compatible. ATM, there is only one user: =22google,gs101-pmu=22 >=20 > There are also cases of adding =22syscon=22 compatible to existing nodes = after the > fact in order to register the syscon. That presents a potential DT ABI pr= oblem. > Instead, if there's a kernel change needing a syscon for a node, then it = should be > possible to allow the kernel to register a syscon without a DT change. Th= at's > only possible by using > of_syscon_register_regmap() currently, but in the future we may want to > support a match list for cases which don't need a custom regmap. >=20 > With this change, the lookup functions will succeed for any node register= ed by > of_syscon_register_regmap() regardless of whether the node compatible > contains =22syscon=22. >=20 > Signed-off-by: Rob Herring (Arm) > --- Reviewed-by: Pankaj Dubey Thanks, Pankaj Dubey