From: "Keiji Hayashibara" <hayashibara.keiji@socionext.com>
To: "Yamada, Masahiro/山田 真弘" <yamada.masahiro@socionext.com>,
wim@iguana.be, linux@roeck-us.net
Cc: linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org,
masami.hiramatsu@linaro.org, jaswinder.singh@linaro.org,
"Hayashi, Kunihiko/林 邦彦" <hayashi.kunihiko@socionext.com>,
"Owada, Kiyoshi/大和田 清志" <owada.kiyoshi@socionext.com>
Subject: RE: [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver
Date: Thu, 25 May 2017 17:44:43 +0900 [thread overview]
Message-ID: <000501d2d533$27fe47b0$77fad710$@socionext.com> (raw)
In-Reply-To: <24780eb20b3c4aecb1f5112e1827d5e1@SOC-EX01V.e01.socionext.com>
Hi Yamada-san,
> > a/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > new file mode 100644
> > index 0000000..a59d1ba
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/watchdog/uniphier-wdt.txt
> > @@ -0,0 +1,20 @@
> > +UniPhier watchdog timer controller
> > +
> > +This UniPhier watchdog timer controller must be under sysctrl compatible
> > node.
> > +
> > +Required properties:
> > +- compatible: should be "socionext,uniphier-wdt"
> > +
> > +Example:
> > +
> > + sysctrl@61840000 {
> > + compatible = "socionext,uniphier-ld11-sysctrl",
> > + "simple-mfd", "syscon";
> > + reg = <0x61840000 0x4000>;
> > +
> > + sys_wdt: watchdog {
> > + compatible = "socionext,uniphier-wdt";
> > + }
> > +
> > + other nodes ...
> > + };
>
>
> Next time, please include
> devicetree@vger.kernel.org
> (and Rob) in your CC list for binding review.
>
> I think scripts/get_maintainer.pl will do it correctly for you.
>
OK. I will include to CC list in next v2 patch.
>
>
> > +#include <linux/delay.h>
>
> Is this used?
It is unnecessary. I will remove it.
Thanks.
-----
Best Regards,
Keiji Hayashibara
next prev parent reply other threads:[~2017-05-25 8:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-24 6:34 [PATCH 0/2] add UniPhier watchdog support Keiji Hayashibara
2017-05-24 6:34 ` [PATCH 1/2] watchdog: uniphier: add UniPhier watchdog driver Keiji Hayashibara
2017-05-24 13:45 ` Guenter Roeck
2017-05-25 8:34 ` Keiji Hayashibara
2017-05-25 5:45 ` yamada.masahiro
2017-05-25 8:44 ` Keiji Hayashibara [this message]
2017-05-24 6:34 ` [PATCH 2/2] arm64: dts: uniphier: add watchdog node for LD11 and LD20 Keiji Hayashibara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000501d2d533$27fe47b0$77fad710$@socionext.com' \
--to=hayashibara.keiji@socionext.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=jaswinder.singh@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=masami.hiramatsu@linaro.org \
--cc=owada.kiyoshi@socionext.com \
--cc=wim@iguana.be \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome