From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755088AbZERLe5 (ORCPT ); Mon, 18 May 2009 07:34:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753967AbZERLep (ORCPT ); Mon, 18 May 2009 07:34:45 -0400 Received: from mailout5.samsung.com ([203.254.224.35]:37275 "EHLO mailout5.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754152AbZERLep (ORCPT ); Mon, 18 May 2009 07:34:45 -0400 Date: Mon, 18 May 2009 13:32:32 +0200 From: Marek Szyprowski Subject: RE: [PATCH] LP3971 PMIC regulator driver update In-reply-to: <1242641718.5473.2156.camel@vega.slimlogic.co.uk> To: "'Liam Girdwood'" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, kyungmin.park@samsung.com, "'Mark Brown'" , Marek Szyprowski Message-id: <000601c9d7ac$58af73d0$0a0e5b70$%szyprowski@samsung.com> MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-type: text/plain; charset=us-ascii Content-language: pl Content-transfer-encoding: 7BIT Thread-index: AcnXoZz4HPxFyKQ8QYiDX1dAhh48hQACg3Cg References: <20090515092030.GA2202@rakim.wolfsonmicro.main> <1242641718.5473.2156.camel@vega.slimlogic.co.uk> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Monday, May 18, 2009 12:15 PM Liam Girdwood wrote: > On Fri, 2009-05-15 at 10:20 +0100, Mark Brown wrote: > > On Fri, May 15, 2009 at 11:16:19AM +0200, Marek Szyprowski wrote: > > > This patch fixes issues reported by Mark Brown in his review of > National Semiconductors LP3971 > > > PMIC regulator driver. It contains: > > > - a little code cleanup > > > - list_voltage() callback added > > > > > Reviewed-by: Kyungmin Park > > > Signed-off-by: Marek Szyprowski > > > > Looks good. > > > > Acked-by: Mark Brown > > Doesn't apply :- > > Applying: LP3971 PMIC regulator driver update > error: patch failed: drivers/regulator/lp3971.c:91 > error: drivers/regulator/lp3971.c: patch does not apply > Patch failed at 0001 LP3971 PMIC regulator driver update > > Could you regenerate against the voltage for-next branch. I've checked the git://git.kernel.org/pub/scm/linux/kernel/git/lrg/voltage-2.6.git, the for-next branch. I looks that all tabs are converted to spaces in my previous patch. I've checked again it imho I've posted it properly. Maybe it was broken by merge conflicts in Makefile/Kconfig. What should I do in such case? Would you revert the broken version or do I need to post a patch for it? Best regards -- Marek Szyprowski Samsung Poland R&D Center