mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marek Szyprowski <m.szyprowski@samsung.com>
To: "'Mark Brown'" <broonie@opensource.wolfsonmicro.com>
Cc: "'Liam Girdwood'" <lrg@slimlogic.co.uk>,
	"'Samuel Ortiz'" <sameo@linux.intel.com>,
	linux-kernel@vger.kernel.org, kyungmin.park@samsung.com
Subject: RE: [PATCH v3] drivers: regulator: add Maxim 8998 driver
Date: Thu, 17 Jun 2010 15:35:35 +0200	[thread overview]
Message-ID: <000601cb0e21$fa1179b0$ee346d10$%szyprowski@samsung.com> (raw)
In-Reply-To: <20100616143041.GC24491@rakim.wolfsonmicro.main>

Hello,

On Wednesday, June 16, 2010 4:31 PM Mark Brown wrote:

> On Wed, Jun 16, 2010 at 09:04:16AM +0200, Marek Szyprowski wrote:
> > From: Kyungmin Park <kyungmin.park@samsung.com>
> >
> > This patch adds voltage regulator driver for Maxim 8998 chip. This chip
> > is used on Samsung Aquila and GONI boards and provides following
> > functionalities:
> > - 4 BUCK voltage converters, 17 LDO power regulators and 5 other power
> >   controllers
> > - battery charger
> >
> > This patch adds basic driver for voltage regulators and MAX 8998 MFD core.
> >
> > Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com>
> 
> Looks good!
> 
> Acked-by: Mark Brown <broonie@opensource.wolfsonmicro.com>

I've just noticed one more thing. Shouldn't the max8998-pmic driver depend
on max8998 mfd driver in Kconfig? Or maybe it would be better to select mfd
driver from the regulators Kconfig? What do you think? 

Best regards
--
Marek Szyprowski
Samsung Poland R&D Center



  parent reply	other threads:[~2010-06-17 13:36 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-16  7:04 Marek Szyprowski
2010-06-16 14:30 ` Mark Brown
2010-06-16 20:16   ` Liam Girdwood
2010-06-21 10:26     ` Samuel Ortiz
2010-06-17 13:35   ` Marek Szyprowski [this message]
2010-06-18  0:31     ` Mark Brown
2010-06-21  8:04       ` [PATCH] drivers: regulators: depend on MFD_MAX8998 Marek Szyprowski
2010-06-21  9:00         ` Mark Brown
2010-06-21 17:49         ` Liam Girdwood
2010-06-21 10:25 ` [PATCH v3] drivers: regulator: add Maxim 8998 driver Samuel Ortiz
2010-06-21 17:50 ` Liam Girdwood

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000601cb0e21$fa1179b0$ee346d10$%szyprowski@samsung.com' \
    --to=m.szyprowski@samsung.com \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=kyungmin.park@samsung.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    --cc=sameo@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®