From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753699AbbCLJED (ORCPT ); Thu, 12 Mar 2015 05:04:03 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:51128 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753668AbbCLJD5 (ORCPT ); Thu, 12 Mar 2015 05:03:57 -0400 X-AuditID: cbfee61a-f79c06d000004e71-03-5501567b3cd7 From: Chao Yu To: "'Wanpeng Li'" Cc: "'Jaegeuk Kim'" , "'Changman Lee'" , linux-f2fs-devel@lists.sourceforge.net, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <1426074741-31296-1-git-send-email-wanpeng.li@linux.intel.com> <009d01d05c7b$950dd970$bf298c50$@samsung.com> <20150312064210.GA12364@kernel> In-reply-to: <20150312064210.GA12364@kernel> Subject: RE: [PATCH RFC] f2fs: add fast symlink Date: Thu, 12 Mar 2015 17:02:47 +0800 Message-id: <000701d05ca3$77a597b0$66f0c710$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQKYwzFszelCKnbK5vyZ7awa34owyQIlGr7jAeA5lhibZ4ldIA== Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrJLMWRmVeSWpSXmKPExsVy+t9jQd3qMMZQg0nHpC2u7Wtksniyfhaz xaVF7hZ79p5ksbi8aw6bxb0n29gd2Dw2repk85h3MtBj94LPTB59W1YxenzeJBfAGsVlk5Ka k1mWWqRvl8CVsf/FOeaCQ1wVq5rfsDcwbuPoYuTgkBAwkWi/ENTFyAlkiklcuLeerYuRi0NI YDqjxLytW1ghnB+MEgfWrWYGqWITUJFY3vGfCcQWEdCV2PTiJFgHs8B2RolXb6exQHTMYpRo /L+GFWQFp4COxNfziSANwgL6EouONIANYhFQlZi9bh8riM0rYCnx7VMXO4QtKPFj8j0WEJtZ QEti/c7jTBC2vMTmNW+ZIU5VkNhx9jUjxBFOEl/Ob2CDqBGX2HjkFssERqFZSEbNQjJqFpJR s5C0LGBkWcUomlqQXFCclJ5rqFecmFtcmpeul5yfu4kRHCHPpHYwrmywOMQowMGoxMNb8ZUh VIg1say4MvcQowQHs5IIr4QrY6gQb0piZVVqUX58UWlOavEhRmkOFiVxXiX7thAhgfTEktTs 1NSC1CKYLBMHp1QDI/9fyZ+XOrtWvc6tODGbe2Niq/Rmh7ajDwynXPvwZbeC4Xwd5zOVPuu4 3PoPfVykdvGW9mrpmdcZDXcl1dlmOGswV7f8afO6NeemiWNLlCO3XmXBi0sFW9NXv54cKZB6 6WmCRNZccUHOLWqBCSVnmss2WFyNb/sUu3fHtdBk37U9U5wWvr/fpcRSnJFoqMVcVJwIAOFI vRKMAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Wanpeng, > -----Original Message----- > From: Wanpeng Li [mailto:wanpeng.li@linux.intel.com] > Sent: Thursday, March 12, 2015 2:42 PM > To: Chao Yu > Cc: 'Wanpeng Li'; 'Jaegeuk Kim'; 'Changman Lee'; linux-f2fs-devel@lists.sourceforge.net; > linux-fsdevel@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: Re: [PATCH RFC] f2fs: add fast symlink > > Hi Chao, > On Thu, Mar 12, 2015 at 12:17:29PM +0800, Chao Yu wrote: > > > >We always remain space in inode page for inline xattr data, > >so it's better to define our max size of fast symlink as below: > > > >#define MAX_FAST_SYMLINK_SIZE (MAX_INLINE_DATA + 1) > > > > Thanks for your review, I just handle all your comments and it works > well. > > Btw, one question, if inline xattr data area is reserved in inode > even if it isn't mounted w/ inline_xattr option? If yes, why it > is reserved? It's not, it keeps space in inode page only if inode is created when inline_xattr option is set. What I comment and suggest for MAX_FAST_SYMLINK_SIZE is wrong, sorry about that. We'd better set max size of fast symlink according to inline_xattr flag: static inline unsigned int max_fast_symlink_size(struct inode *inode) { return sizeof(__le32) * addrs_per_inode(F2FS_I(inode)); } How do you think? Thanks, > > Regards, > Wanpeng Li