From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: "'LKML'" <linux-kernel@vger.kernel.org>,
"'Richard Purdie'" <rpurdie@rpsys.net>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH] backlight: atmel-pwm-bl: remove erroneous __exit annotation
Date: Thu, 28 Feb 2013 18:46:12 +0900 [thread overview]
Message-ID: <000801ce1598$7168f800$543ae800$%han@samsung.com> (raw)
In-Reply-To:
On Thursday, February 28, 2013 1:05 PM, Jingoo Han wrote:
>
> CONFIG_HOTPLUG was removed, so __devexit or __exit of remove()
> should not be used.
This driver also use platform_driver_probe().
So, this patch is useless.
Please, abandon this patch.
Thank you.
Best regards,
Jingoo Han
>
> Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> ---
> drivers/video/backlight/atmel-pwm-bl.c | 4 ++--
> 1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/atmel-pwm-bl.c b/drivers/video/backlight/atmel-pwm-bl.c
> index de5e5e7..24b90fa 100644
> --- a/drivers/video/backlight/atmel-pwm-bl.c
> +++ b/drivers/video/backlight/atmel-pwm-bl.c
> @@ -203,7 +203,7 @@ err_free_mem:
> return retval;
> }
>
> -static int __exit atmel_pwm_bl_remove(struct platform_device *pdev)
> +static int atmel_pwm_bl_remove(struct platform_device *pdev)
> {
> struct atmel_pwm_bl *pwmbl = platform_get_drvdata(pdev);
>
> @@ -222,7 +222,7 @@ static struct platform_driver atmel_pwm_bl_driver = {
> .name = "atmel-pwm-bl",
> },
> /* REVISIT add suspend() and resume() */
> - .remove = __exit_p(atmel_pwm_bl_remove),
> + .remove = atmel_pwm_bl_remove,
> };
>
> static int __init atmel_pwm_bl_init(void)
> --
> 1.7.2.5
next reply other threads:[~2013-02-28 9:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-28 9:46 Jingoo Han [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-02-28 4:04 Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000801ce1598$7168f800$543ae800$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rpurdie@rpsys.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®