From: Jingoo Han <jg1.han@samsung.com>
To: "'Dmitry Torokhov'" <dmitry.torokhov@gmail.com>
Cc: "'Samuel Ortiz'" <sameo@linux.intel.com>,
linux-kernel@vger.kernel.org,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH 08/11] mfd: ezx-pcap: use devm_request_irq() and devm_kzalloc()
Date: Wed, 20 Feb 2013 17:06:30 +0900 [thread overview]
Message-ID: <000901ce0f41$30a23230$91e69690$%han@samsung.com> (raw)
In-Reply-To: <20130220073337.GC2648@core.coreip.homeip.net>
On Wednesday, February 20, 2013 4:34 PM, Dmitry Torokhov wrote:
>
> On Wed, Feb 20, 2013 at 03:13:06PM +0900, Jingoo Han wrote:
> > Use devm_request_irq() and devm_kzalloc() to make cleanup paths
> > more simple.
> >
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> > drivers/mfd/ezx-pcap.c | 16 +++++-----------
> > 1 files changed, 5 insertions(+), 11 deletions(-)
> >
> > diff --git a/drivers/mfd/ezx-pcap.c b/drivers/mfd/ezx-pcap.c
> > index b7a61f0..8dea3a9 100644
> > --- a/drivers/mfd/ezx-pcap.c
> > +++ b/drivers/mfd/ezx-pcap.c
> > @@ -403,7 +403,6 @@ static int ezx_pcap_remove(struct spi_device *spi)
> > /* cleanup ADC */
> > adc_irq = pcap_to_irq(pcap, (pdata->config & PCAP_SECOND_PORT) ?
> > PCAP_IRQ_ADCDONE2 : PCAP_IRQ_ADCDONE);
> > - free_irq(adc_irq, pcap);
> > mutex_lock(&pcap->adc_mutex);
> > for (i = 0; i < PCAP_ADC_MAXQ; i++)
> > kfree(pcap->adc_queue[i]);
> > @@ -415,8 +414,6 @@ static int ezx_pcap_remove(struct spi_device *spi)
> >
> > destroy_workqueue(pcap->workqueue);
> >
> > - kfree(pcap);
> > -
>
> I am pretty sure this conversion is wrong as well. Pretty much
> work/workqueue and devm_request_irq() do not mix.
Yes, you're right.
I will use devm_free_irq().
>
> Thanks.
>
> --
> Dmitry
next prev parent reply other threads:[~2013-02-20 8:06 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-02-20 6:09 [PATCH 01/11] mfd: 88pm860x: drop devm_kfree of devm_kzalloc'd data Jingoo Han
2013-02-20 6:10 ` [PATCH 02/11] mfd: lm3533: use devm_gpio_request_one() Jingoo Han
2013-02-20 6:10 ` [PATCH 03/11] mfd: aat2870: use devm_gpio_request_one() and devm_kzalloc() Jingoo Han
2013-02-20 6:11 ` [PATCH 04/11] mfd: intel_msic: use devm_gpio_request_one() Jingoo Han
2013-02-20 6:11 ` [PATCH 05/11] mfd: twl6040: use devm_gpio_request_one() and devm_request_threaded_irq() Jingoo Han
2013-02-20 7:37 ` Dmitry Torokhov
2013-02-20 8:09 ` Jingoo Han
2013-02-20 6:12 ` [PATCH 06/11] mfd: omap-usb-host: use devm_gpio_request_one() Jingoo Han
2013-02-20 6:12 ` [PATCH 07/11] mfd: menelaus: use devm_request_irq() and devm_kzalloc() Jingoo Han
2013-02-20 7:30 ` Dmitry Torokhov
2013-02-20 8:05 ` Jingoo Han
2013-02-20 8:10 ` Dmitry Torokhov
2013-02-20 8:17 ` Jingoo Han
2013-02-20 8:36 ` Dmitry Torokhov
2013-02-20 6:13 ` [PATCH 08/11] mfd: ezx-pcap: " Jingoo Han
2013-02-20 7:33 ` Dmitry Torokhov
2013-02-20 8:06 ` Jingoo Han [this message]
2013-02-20 6:13 ` [PATCH 09/11] mfd: da903x: " Jingoo Han
2013-02-20 6:14 ` [PATCH 10/11] mfd: tps65010: " Jingoo Han
2013-02-20 7:35 ` Dmitry Torokhov
2013-02-20 8:07 ` Jingoo Han
2013-02-20 6:14 ` [PATCH 11/11] mfd: tc3589x: " Jingoo Han
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000901ce0f41$30a23230$91e69690$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®