From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 13FD4199EAD for ; Wed, 1 Apr 2026 07:29:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775028579; cv=none; b=MXOISknmrAxXO+7PU7Fu6KNlVTs5Dsdt0XXRhVNmM8T3k/HFDRv64SAexVOQpGqTSt/+3FCmKnXQXZj9755oHiFawO3MlTeFkCwFYK5cEBekFHp31l84370Uc/30QY+uZidh53e9QILFHOnHGDFBZUJlMIYV8JmcN5Rw9mLFmRU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775028579; c=relaxed/simple; bh=pdceCx61hLe2j/1j2lmTPYtHb6MpZMwBUw+RRosp1pk=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Izi62t4cwSZSsK8tcxyoul3is9bUXQr51OFhP8qYY0g4M9fRsfleHTw8EoWe2DPAMfKjhyBzaRrEBw91+iV32PQE2+nU6pgoA7TICHYj+3qOWK1AQQ0ydUgZVUBs7haIh0dNVJvDoTK+ANvVGx8I1LtqZR7T2TNCKyn/UOoonSY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NPcE9R+s; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=AhpPEXa8; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NPcE9R+s"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="AhpPEXa8" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 6317Sbwm1578366 for ; Wed, 1 Apr 2026 07:29:37 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= qbS9+v2BBjG7zRi/OvSLkU/Ie2NFTC6i8v/tksgC6LY=; b=NPcE9R+sxT492Isa i5OQBCTbMTtO9lcB1zpvrVxBSX0P+f8FmzR0VjMiYhZTpwmS2pkjsq9Ue9systaC q6v2BAWitGZDIYjEbvx+hHVBK5jNCNm4z7A3PkN56LUmGbiODLSDXNdc49rzMf2n XJnaai8imJcrkEQg6Qst0M5I92ot7pLI+PoC4+cL2hY3kIN3cT0Iwuq5AEK2HEnt qZ+j68auShAi7HHvBihu8ZZzzAmviRU4tduhKUKilO3sj1wvXBq4hfS5B4o1PK/n oxOs1lIeetNdTo97b2qZTsETtWB6FKsEMEYL9WDMfWyR9+O0Uv3rIdve2BWdUPXK sKfgDA== Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4d8k6ktvkt-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 01 Apr 2026 07:29:36 +0000 (GMT) Received: by mail-qt1-f200.google.com with SMTP id d75a77b69052e-5093025ffecso205465261cf.0 for ; Wed, 01 Apr 2026 00:29:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1775028576; x=1775633376; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=qbS9+v2BBjG7zRi/OvSLkU/Ie2NFTC6i8v/tksgC6LY=; b=AhpPEXa80Ig3VQ0KN8kHWKsoLdzB0yvy9zqI9wGIXPkgJFt7zU4Lb9dYUJtSkQSqLb LbCyHubsxqErt49/RuzMNjQ8GqNQ2SoVFw7xF3Av5/2PyXxqkvBVjEIc3HoIlZ5hWCqk BQF+SpFo5Bu4spKWapgTBaXzT4oseqTvV+2diL9b+fMP8iWgps0tMYYjMsXynf+ItrIX HSYqGU3vcLGFcLKi3jUJvho90Qac0AlbsJ7dMyGLIp0eS4Wb66PeWdPqfDx4UkQ12kNb 0a09u7tV5Kde/dAxW3Yi1y+/DUChpQ/SWCA1IOjOwb92+7g23YlOoRiq1k0yixlyLdRa mVAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775028576; x=1775633376; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qbS9+v2BBjG7zRi/OvSLkU/Ie2NFTC6i8v/tksgC6LY=; b=FwPeKc0IFEyefIRsHZRRuqrlW0i69+Tv3HEzb+pVw7LFfEqfqntHswGmv8+BjqNXDw LpRljM36YhKZoshD60BJoZO9ef6Xw7S49Z2x0KPCV/Wv5lEWleZq/uOTtFHJSkbjbaoG kZ/J2KraaDGzz2o8auqqAvBJaYXsFJoxjrb7/NyF6VQpxi1W2R9sOm8DDFaexJ+A6kJZ TZyla4IwVajBMo160OzjqNGWDh4iEtMYOi1Hy9jsVBfG/gAjbLqmcTQAPDWhXap+uGsT hY0hGVhroXVo/LIaLDTXOm1s2+FaO08pvjsUd2iPCzx+bC3I54JZJ08gl/4CPiFH5VIt pVqw== X-Forwarded-Encrypted: i=1; AJvYcCWJFcmwihb9NHzxO4qWM84mJUwLl2TsXIDgY4oLGitX7vDdy3N6MgXFDQmRutyDlYpestnGFaaI2py0Yo8=@vger.kernel.org X-Gm-Message-State: AOJu0YwTbiHI0j5jWa4BkLKXQ7uH7BqYsmwW2gnqkA2206Ss6SH0vqU9 9BBbZ9ET1zN8W52RXInePSRBwJV7IXoMRda8/NiIylvl3Ndh0EefhBzRfXIgHjRnjRyMDlIgddZ C3//V9V6G4sk/ebMoLhJkLnj1TKdFLZa9ghI3Vm+Oui8nz+o/EiWElwdVpCzKBP1LImA= X-Gm-Gg: ATEYQzyalclWBO9eZDr0jLsa9oExLCbe4T5+OsFlNxZxjkHQAKM3NMOs7Wa27d30R03 hDQGJEhnJrJjjGE8pDHAWO4GY325fgWJwEfn1EdmVdVCs42N2WVxiFv32/BSu/BQcUonZXNEx3w +rmLHUyN0Co3Wm+4Oyj2g3gHVNJv5FCDWoIQMdYCNDsAL7DlivqQSLaIt3a3AZYyX1WntF0KR8l aGZYBbzlQKOZ/TNlNf7tPp7nt3ApEPUffPGrzfGn9Tc8cxHWl2yV+3gP+UvxNYen0MlSWvvSqzw D1mVzz839cSe5gnvgMr87m869k5fwmEcz+bVRNjlDSCdDP+mEJ+jZgu6DD1md7uPKsTilgKwASe 7gJkgOG7kWvkr6g1qFwPjITmiTLZlNFC2qfi3PwDnLs4HPaFm9nJbdCuTEighX/UutX6k7aVR/X sxKzjZ1qIChA2QL5Ss5aH9UBvT X-Received: by 2002:a05:622a:259a:b0:509:379b:d4e with SMTP id d75a77b69052e-50d3bcd2630mr38915081cf.32.1775028576224; Wed, 01 Apr 2026 00:29:36 -0700 (PDT) X-Received: by 2002:a05:622a:259a:b0:509:379b:d4e with SMTP id d75a77b69052e-50d3bcd2630mr38914671cf.32.1775028575723; Wed, 01 Apr 2026 00:29:35 -0700 (PDT) Received: from ?IPV6:2001:14ba:a073:af00::4c9? (2001-14ba-a073-af00--4c9.rev.dnainternet.fi. [2001:14ba:a073:af00::4c9]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a2c3d32cd0sm388804e87.8.2026.04.01.00.29.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Apr 2026 00:29:34 -0700 (PDT) Message-ID: <0009a801-8f58-487c-b5c6-5b264393ef25@oss.qualcomm.com> Date: Wed, 1 Apr 2026 10:29:33 +0300 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 28/38] drm/msm/dp: add dp_mst_drm to manage DP MST bridge operations To: Yongxing Mou Cc: Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , David Airlie , Simona Vetter , linux-arm-msm@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org, linux-kernel@vger.kernel.org, Abhinav Kumar References: <20250825-msm-dp-mst-v3-0-01faacfcdedd@oss.qualcomm.com> <20250825-msm-dp-mst-v3-28-01faacfcdedd@oss.qualcomm.com> Content-Language: en-US From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Authority-Analysis: v=2.4 cv=bfJmkePB c=1 sm=1 tr=0 ts=69ccc960 cx=c_pps a=JbAStetqSzwMeJznSMzCyw==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=A5OVakUREuEA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=COk6AnOGAAAA:8 a=EUspDBNiAAAA:8 a=nlcTEVPeAIpjwhky54wA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=uxP6HrT_eTzRwkO_Te1X:22 a=TjNXssC_j7lpFel5tvFf:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNDAxMDA2NCBTYWx0ZWRfX639xIKUdzDQM fqv5novUo1XLyIogmBHv2aqfB4dXfkyabL8URmOvgaWTsyfJOYpY+70dhCdJ89WHIm7QOaNAjhk BmU/LGK8EsgY3Xml/9HIxVNPwIS9pqtVlLLtfhD/07R45LEHefYzk9ngu85oINwQvh/kZVKzGCr 2bkApUo87cqUa1PSr2ebEMuVk3XgxeP5AauWdQpRXp3wxTVBEC2rpy8YVQMh585FDBXKmMt2zt8 /NnUY6lTrOayIJuVrk3K3MTeuh3UdcSqVd7dSMJ8oMV6DJ9O8kjkW7MVrdLzsjdDwtxaiNSQNXN srhaz/QKBTFvsMDdf/YapHjuFYVUMt+bxxv+2NWmVJU/H8wcoGajHRl7Mdo461/e/j7VOGF91Re cADYvfJsikxGqxnlKWCsC2TYaFXf26ZHSBRzVgo6euS0kyfq+IEVkx0o+x1rAxS9X9kC3tpTw1a 1cnQGttD88Wg/KKjexg== X-Proofpoint-GUID: X7kN_utsEeNgr1bOTy_YlrQseOM3-I7Z X-Proofpoint-ORIG-GUID: X7kN_utsEeNgr1bOTy_YlrQseOM3-I7Z X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-04-01_02,2026-04-01_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 malwarescore=0 clxscore=1015 lowpriorityscore=0 adultscore=0 suspectscore=0 impostorscore=0 phishscore=0 bulkscore=0 priorityscore=1501 spamscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2603050001 definitions=main-2604010064 On 01/04/2026 10:07, Yongxing Mou wrote: > > > On 8/27/2025 1:36 AM, Dmitry Baryshkov wrote: >> On Mon, Aug 25, 2025 at 10:16:14PM +0800, Yongxing Mou wrote: >>> From: Abhinav Kumar >>> >>> Add a new file dp_mst_drm to manage the DP MST bridge operations >>> similar to the dp_drm file which manages the SST bridge operations. >>> Each MST encoder creates one bridge and each bridge is bound to its >>> own dp_panel abstraction to manage the operations of its pipeline. >>> >>> Signed-off-by: Abhinav Kumar >>> Signed-off-by: Yongxing Mou >>> --- >>>   drivers/gpu/drm/msm/Makefile        |   3 +- >>>   drivers/gpu/drm/msm/dp/dp_display.h |   3 + >>>   drivers/gpu/drm/msm/dp/dp_mst_drm.c | 556 +++++++++++++++++++++++++ >>> +++++++++++ >>>   drivers/gpu/drm/msm/dp/dp_mst_drm.h |  86 ++++++ >>>   4 files changed, 647 insertions(+), 1 deletion(-) >>> >>> + >>> +struct msm_dp_mst_bridge { >>> +    struct drm_bridge base; >>> +    struct drm_private_obj obj; >>> +    u32 id; >>> + >>> +    bool in_use; >> >> What does it mean? In use currently for one of outputs? >> >>> + >>> +    struct msm_dp *display; >>> +    struct drm_encoder *encoder; >>> + >>> +    struct drm_connector *connector; >> >> Why do you have connector both as a part of the bridge and bridge state? >> >> Please describe design decisions in the commit mesage or as comments. >> > Emm. i go through the msm_dp_mst_bridge_state and msm_dp_mst_bridge.. > Can we just drop msm_dp_mst_bridge_state? just track connector and > anything else on bridge. If something is being handled by atomic helpers or being computed by atomic_check() for later use, it should be a state. If not, it can be a part of the single bridge struct. The most obvious mistake is to set globals or object data in atomic_check(). >>> +    struct msm_dp_panel *msm_dp_panel; >>> +}; >>> + >>> +struct msm_dp_mst_bridge_state { >>> +    struct drm_private_state base; >>> +    struct drm_connector *connector; >>> +    struct msm_dp_panel *msm_dp_panel; >>> + >>> +    int vcpi; >>> +    int pbn; >>> +    int num_slots; >>> +    int start_slot; >> >> I'd definitely prefer to have payload pointer here, if that's also a >> part of the state. >> >>> +}; >>> + >>> +struct msm_dp_mst { >>> +    struct drm_dp_mst_topology_mgr mst_mgr; >>> +    struct msm_dp_mst_bridge *mst_bridge[DP_STREAM_MAX]; >>> +    struct msm_dp *msm_dp; >>> +    u32 max_streams; >>> +    struct mutex mst_lock; >>> +}; >>> + >>> +struct msm_dp_mst_connector { >>> +    struct drm_connector connector; >>> +    struct drm_dp_mst_port *mst_port; >>> +    struct msm_dp *msm_dp; >>> +    struct msm_dp_panel *dp_panel; >>> +}; >>> + >>> +int msm_dp_mst_drm_bridge_init(struct msm_dp *dp, struct drm_encoder >>> *encoder); >>> + >>> +#endif /* _DP_MST_DRM_H_ */ >>> >>> -- >>> 2.34.1 >>> >> > -- With best wishes Dmitry