mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: <yael.chemla@foss.arm.com>
To: "'Wei Yongjun'" <weiyongjun1@huawei.com>,
	"'Alasdair Kergon'" <agk@redhat.com>,
	"'Mike Snitzer'" <snitzer@redhat.com>
Cc: <dm-devel@redhat.com>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: RE: [PATCH -next] dm verity: make some functions static
Date: Wed, 28 Mar 2018 14:57:43 +0300	[thread overview]
Message-ID: <000a01d3c68b$fd4ca9d0$f7e5fd70$@foss.arm.com> (raw)
In-Reply-To: <1522235518-20209-1-git-send-email-weiyongjun1@huawei.com>

Hi Wei,
i'll add this fix, got this also from the kbuild test robot.
Thank you,
Yael

> -----Original Message-----
> From: Wei Yongjun <weiyongjun1@huawei.com>
> Sent: Wednesday, 28 March 2018 14:12
> To: Alasdair Kergon <agk@redhat.com>; Mike Snitzer <snitzer@redhat.com>;
> yaeceh01 <yael.chemla@foss.arm.com>
> Cc: Wei Yongjun <weiyongjun1@huawei.com>; dm-devel@redhat.com; linux-
> kernel@vger.kernel.org; kernel-janitors@vger.kernel.org
> Subject: [PATCH -next] dm verity: make some functions static
> 
> Fixes the following sparse warnings:
> 
> drivers/md/dm-verity-target.c:375:6: warning:
>  symbol 'verity_for_io_block' was not declared. Should it be static?
> drivers/md/dm-verity-target.c:403:14: warning:
>  symbol 'verity_calc_buffs_for_bv' was not declared. Should it be static?
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
> ---
>  drivers/md/dm-verity-target.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/md/dm-verity-target.c b/drivers/md/dm-verity-target.c
> index da35f0e..e70d4d2 100644
> --- a/drivers/md/dm-verity-target.c
> +++ b/drivers/md/dm-verity-target.c
> @@ -372,9 +372,9 @@ int verity_hash_for_block(struct dm_verity *v, struct
> dm_verity_io *io,
>  /*
>   * Calculates the digest for the given bio
>   */
> -void verity_for_io_block(struct dm_verity *v, struct dm_verity_io *io,
> -			 struct bvec_iter *iter, struct scatterlist *sg,
> -			 unsigned int *nents, unsigned int *total_len)
> +static void verity_for_io_block(struct dm_verity *v, struct dm_verity_io *io,
> +				struct bvec_iter *iter, struct scatterlist *sg,
> +				unsigned int *nents, unsigned int *total_len)
>  {
>  	unsigned int todo = 1 << v->data_dev_block_bits;
>  	struct bio *bio = dm_bio_from_per_bio_data(io, v->ti-
> >per_io_data_size); @@ -400,8 +400,9 @@ void verity_for_io_block(struct
> dm_verity *v, struct dm_verity_io *io,
>   * Calculate how many buffers are required to accommodate
>   * bio_vec starting from iter.
>   */
> -unsigned int verity_calc_buffs_for_bv(struct dm_verity *v, struct
> dm_verity_io *io,
> -				      struct bvec_iter *iter)
> +static unsigned int verity_calc_buffs_for_bv(struct dm_verity *v,
> +					     struct dm_verity_io *io,
> +					     struct bvec_iter *iter)
>  {
>  	unsigned int todo = 1 << v->data_dev_block_bits;
>  	struct bio *bio = dm_bio_from_per_bio_data(io, v->ti-
> >per_io_data_size);

      reply	other threads:[~2018-03-28 11:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-28 11:11 Wei Yongjun
2018-03-28 11:57 ` yael.chemla [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000a01d3c68b$fd4ca9d0$f7e5fd70$@foss.arm.com' \
    --to=yael.chemla@foss.arm.com \
    --cc=agk@redhat.com \
    --cc=dm-devel@redhat.com \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=snitzer@redhat.com \
    --cc=weiyongjun1@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome