From: "Jiawen Wu" <jiawenwu@trustnetic.com>
To: "'Wang Ming'" <machel@vivo.com>,
"'Mengyuan Lou'" <mengyuanlou@net-swift.com>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Jakub Kicinski'" <kuba@kernel.org>,
"'Paolo Abeni'" <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>,
"'Mengyuan Lou'" <mengyuanlou@net-swift.com>,
"'David S. Miller'" <davem@davemloft.net>,
"'Eric Dumazet'" <edumazet@google.com>,
"'Jakub Kicinski'" <kuba@kernel.org>,
"'Paolo Abeni'" <pabeni@redhat.com>, <netdev@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <opensource.kernel@vivo.com>, <opensource.kernel@vivo.com>
Subject: RE: [PATCH net v1] net: ethernet: Remove repeating expression
Date: Fri, 14 Jul 2023 09:47:55 +0800 [thread overview]
Message-ID: <000a01d9b5f5$3591e8b0$a0b5ba10$@trustnetic.com> (raw)
In-Reply-To: <20230713121633.8190-1-machel@vivo.com>
On Thursday, July 13, 2023 8:16 PM, Wang Ming wrote:
> Identify issues that arise by using the tests/doublebitand.cocci
> semantic patch. Need to remove duplicate expression in if statement.
>
> Signed-off-by: Wang Ming <machel@vivo.com>
> ---
> drivers/net/ethernet/wangxun/libwx/wx_hw.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/net/ethernet/wangxun/libwx/wx_hw.c b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> index 39a9aeee7aab..6321178fc814 100644
> --- a/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> +++ b/drivers/net/ethernet/wangxun/libwx/wx_hw.c
> @@ -1511,7 +1511,6 @@ static void wx_configure_rx(struct wx *wx)
> psrtype = WX_RDB_PL_CFG_L4HDR |
> WX_RDB_PL_CFG_L3HDR |
> WX_RDB_PL_CFG_L2HDR |
> - WX_RDB_PL_CFG_TUN_TUNHDR |
> WX_RDB_PL_CFG_TUN_TUNHDR;
> wr32(wx, WX_RDB_PL_CFG(0), psrtype);
Reviewed-by: Jiawen Wu <jiawenwu@trustnetic.com>
next prev parent reply other threads:[~2023-07-14 1:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-13 12:16 Wang Ming
2023-07-14 1:47 ` Jiawen Wu [this message]
2023-07-14 8:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000a01d9b5f5$3591e8b0$a0b5ba10$@trustnetic.com' \
--to=jiawenwu@trustnetic.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=machel@vivo.com \
--cc=mengyuanlou@net-swift.com \
--cc=netdev@vger.kernel.org \
--cc=opensource.kernel@vivo.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome