mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Daniel Lezcano'" <daniel.lezcano@linaro.org>
Cc: "'Thomas Gleixner'" <tglx@linutronix.de>,
	linux-kernel@vger.kernel.org, "'Magnus Damm'" <damm@igel.co.jp>,
	"'Paul Mundt'" <lethal@linux-sh.org>,
	"'Simon Horman'" <horms+renesas@verge.net.au>,
	"'Laurent Pinchart'" <laurent.pinchart+renesas@ideasonboard.com>,
	"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 2/2] clocksource: sh_mtu2: remove unnecessary platform_set_drvdata()
Date: Tue, 03 Dec 2013 15:51:06 +0900	[thread overview]
Message-ID: <000b01ceeff4$0a6d0a60$1f471f20$%han@samsung.com> (raw)
In-Reply-To: <000001ceeff3$e867a100$b936e300$%han@samsung.com>

The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
---
 drivers/clocksource/sh_mtu2.c |    1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/clocksource/sh_mtu2.c b/drivers/clocksource/sh_mtu2.c
index 3cf1283..d8ed6e6 100644
--- a/drivers/clocksource/sh_mtu2.c
+++ b/drivers/clocksource/sh_mtu2.c
@@ -358,7 +358,6 @@ static int sh_mtu2_probe(struct platform_device *pdev)
 	ret = sh_mtu2_setup(p, pdev);
 	if (ret) {
 		kfree(p);
-		platform_set_drvdata(pdev, NULL);
 		pm_runtime_idle(&pdev->dev);
 		return ret;
 	}
-- 
1.7.10.4



  reply	other threads:[~2013-12-03  6:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-12-03  6:50 [PATCH 1/2] clocksource: sh_tmu: " Jingoo Han
2013-12-03  6:51 ` Jingoo Han [this message]
2013-12-04 14:54   ` [PATCH 2/2] clocksource: sh_mtu2: " Daniel Lezcano
2013-12-04 14:54 ` [PATCH 1/2] clocksource: sh_tmu: " Daniel Lezcano
  -- strict thread matches above, loose matches on Subject: below --
2013-08-21  9:21 Jingoo Han
2013-08-21  9:22 ` [PATCH 2/2] clocksource: sh_mtu2: " Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000b01ceeff4$0a6d0a60$1f471f20$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=damm@igel.co.jp \
    --cc=daniel.lezcano@linaro.org \
    --cc=horms+renesas@verge.net.au \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=lethal@linux-sh.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®