From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbdLEIjE (ORCPT ); Tue, 5 Dec 2017 03:39:04 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:21186 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750810AbdLEIjC (ORCPT ); Tue, 5 Dec 2017 03:39:02 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.samsung.com 20171205083901epoutp02ae9ff0f25c64bbea08380335109deb00~9WTahP8dm2592525925epoutp02j X-AuditID: b6c32a49-915ff7000000117d-09-5a265b24e7fb From: "LiFan" To: "'Chao Yu'" , "'Chao Yu'" , "'Jaegeuk Kim'" Cc: , Subject: [f2fs-dev] [PATCH] f2fs: use unlikely for release case Date: Tue, 5 Dec 2017 16:38:01 +0800 Message-ID: <000c01d36da4$7a9efbe0$6fdcf3a0$@samsung.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-Index: AdNto5BtHZey7oxYReadtE7oQ0//rg== Content-Language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprNKsWRmVeSWpSXmKPExsWy7bCmpq5KtFqUwb9dqhanp55lsniyfhaz xaVF7haXd81hs5j6eC2rA6tHy5G3rB6bVnWyeexe8JnJ4/MmuQCWKC6blNSczLLUIn27BK6M RRfPsBcsYq1Yv6e0gXENSxcjJ4eEgInEpIkTWbsYuTiEBHYzSmy884AJwvnEKNF35ymU841R 4vSzGewwLe8vbmOBSOxllLhzZi3YLCGBp4wSzfdtuhg5ONgENCSmbpYBCYsIZEvMPH+cGcRm FvCR+H3rHpgtLGAvsejke1YQm0VAReLm/f1gcV4BS4kn+6+wQtiCEidnPmGB6JWX2P52DjPE DQoSO86+ZoSYrycx7c07qBpxiTutrWDvSAhsYJOY0HkK6k8XiYNPdzFB2MISr45vgXpGSuLz u71sEPY6RonPZywgmrczSsz7+BGqwVpi85pf7CCPMQtoSqzfpQ8RtpX48/A6G8RiPone30+Y QEokBHglOtqEIErUJF6ungV1gozEvPt9UBM9JBbMnMg+gVFpFpI3ZyF5cxaSd2YhLF7AyLKK UTK1oDg3PbXYtMAwL7Vcrzgxt7g0L10vOT93EyM4yWh57mCcdc7nEKMAB6MSD+8NX9UoIdbE suLK3EOMEhzMSiK8T+YDhXhTEiurUovy44tKc1KLDzFKc7AoifMe21kaKSSQnliSmp2aWpBa BJNl4uCUamCsKmt/Vawqon1SheXdtOhHoclT/7mcWXSPa0q+bN5HXsl9QvedK4LubGX/8y/V 79qNjsQNk3Unh2/+2G7uv1fgb+iHymVqR9wVfkdVtSSwL681XK5WLrXKZMXLOfZrnkTLm1f+ XPHUau0EpYlSj76ZskxLYGmYpLzmbFzRoyl8XTz3d3iefVKkxFKckWioxVxUnAgAilgm/S4D AAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrCLMWRmVeSWpSXmKPExsWy7bCSnK5KtFqUwf8zvBanp55lsniyfhaz xaVF7haXd81hs5j6eC2rA6tHy5G3rB6bVnWyeexe8JnJ4/MmuQCWKC6blNSczLLUIn27BK6M RRfPsBcsYq1Yv6e0gXENSxcjJ4eEgInE+4vbwGwhgd2MEivmm0DEZSQWHP7CDmELS6z895wd ouYxo8TXFucuRg4ONgENiambZUDCIgK5ElOnfGcCsZkF/CR2PVzBDGILC9hLLDr5nhXEZhFQ kbh5fz9YnFfAUuLJ/iusELagxMmZT1ggerUleh+2MkLY8hLb385hhjhBQWLH2deMELv0JKa9 eQdVLy5xp7WVdQKj4Cwko2YhGTULyahZSFoWMLKsYpRMLSjOTc8tNiwwykst1ytOzC0uzUvX S87P3cQIDnstrR2MJ07EH2IU4GBU4uG94asaJcSaWFZcmXuIUYKDWUmE98l8oBBvSmJlVWpR fnxRaU5q8SFGaQ4WJXFe+fxjkUIC6YklqdmpqQWpRTBZJg5OqQbGSpNvDqLfHNijdu25c3Zz zGKHerO6qk3pRq3cnRnh0XHthg9PhxxZ0inqKHl3n9eX130VNld/19ZVrOo/t/JjFH96r7Dy apFzNw8YJqpr7tLOvrE92OTgW0H1c0n892Jtfn00nMY5Ua1QfvcTV0u/SYuMpFY+cQvL/NDI seJh27u7TnLzWncpsRRnJBpqMRcVJwIAyUVkbncCAAA= X-CMS-MailID: 20171205083900epcas5p3da0ba06455bf7f17ffacd0b25328aca3 X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-MTR: 20171205083900epcas5p3da0ba06455bf7f17ffacd0b25328aca3 CMS-TYPE: 105P X-CMS-RootMailID: 20171205083900epcas5p3da0ba06455bf7f17ffacd0b25328aca3 X-RootMTR: 20171205083900epcas5p3da0ba06455bf7f17ffacd0b25328aca3 References: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Since the variable release is only nonzero when another unlikely case occurs, use unlikely() on it seems logical. Signed-off-by: Fan li --- fs/f2fs/f2fs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/f2fs/f2fs.h b/fs/f2fs/f2fs.h index 71fbba96..0f01af0 100644 --- a/fs/f2fs/f2fs.h +++ b/fs/f2fs/f2fs.h @@ -1594,7 +1594,7 @@ static inline int inc_valid_block_count(struct f2fs_sb_info *sbi, } spin_unlock(&sbi->stat_lock); - if (release) + if (unlikely(release)) dquot_release_reservation_block(inode, release); f2fs_i_blocks_write(inode, *count, true, true); return 0; -- 2.7.4