From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by aws-us-west-2-korg-lkml-1.web.codeaurora.org (Postfix) with ESMTP id 9DB2FC433EF for ; Fri, 15 Jun 2018 04:25:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 4EF7A20864 for ; Fri, 15 Jun 2018 04:25:48 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4EF7A20864 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=toshiba.co.jp Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755560AbeFOEZq convert rfc822-to-8bit (ORCPT ); Fri, 15 Jun 2018 00:25:46 -0400 Received: from mo-csw1516.securemx.jp ([210.130.202.155]:52446 "EHLO mo-csw.securemx.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751237AbeFOEZo (ORCPT ); Fri, 15 Jun 2018 00:25:44 -0400 Received: by mo-csw.securemx.jp (mx-mo-csw1516) id w5F4OXv6009397; Fri, 15 Jun 2018 13:24:34 +0900 X-Iguazu-Qid: 34tIVOFt9LkeQsXUcy X-Iguazu-QSIG: v=1; s=0; t=1529036673; q=34tIVOFt9LkeQsXUcy; m=QUIW+ptMhDpD0HvPXyZlspWrT/9BmVucJFbV42nCF/4= Received: from imx12.toshiba.co.jp (imx12.toshiba.co.jp [61.202.160.132]) by relay.securemx.jp (mx-mr1511) id w5F4OUQX013970; Fri, 15 Jun 2018 13:24:30 +0900 Received: from hop101.toshiba.co.jp ([133.199.85.107]) by imx12.toshiba.co.jp with ESMTP id w5F4OUUc002439; Fri, 15 Jun 2018 13:24:30 +0900 (JST) From: "Daniel Sangorrin" To: "'Greg Kroah-Hartman'" , Cc: , "'Andy Lutomirski'" , "'Rik van Riel'" , "'Borislav Petkov'" , "'Brian Gerst'" , "'Dave Hansen'" , "'Denys Vlasenko'" , "'Fenghua Yu'" , "'H. Peter Anvin'" , "'Josh Poimboeuf'" , "'Linus Torvalds'" , "'Oleg Nesterov'" , "'Peter Zijlstra'" , "'Quentin Casasnovas'" , "'Thomas Gleixner'" , , "'Ingo Molnar'" References: <20180614132724.483802160@linuxfoundation.org> <20180614132724.905032027@linuxfoundation.org> In-Reply-To: <20180614132724.905032027@linuxfoundation.org> Subject: RE: [PATCH 4.4 10/24] x86/fpu: Hard-disable lazy FPU mode Date: Fri, 15 Jun 2018 13:24:27 +0900 X-TSB-HOP: ON Message-ID: <000c01d40460$bfc97710$3f5c6530$@toshiba.co.jp> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQGUQj4igkaupq7EehpFPqRFc6I8UgHKB38SpNHsNUA= Content-Language: ja Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Greg, > /* Intel-defined CPU features, CPUID level 0x00000001 (ecx), word 4 */ > --- a/arch/x86/include/asm/fpu/internal.h > +++ b/arch/x86/include/asm/fpu/internal.h > @@ -58,7 +58,7 @@ extern u64 fpu__get_supported_xfeatures_ > */ > static __always_inline __pure bool use_eager_fpu(void) > { > - return static_cpu_has_safe(X86_FEATURE_EAGER_FPU); > + return true; > } Since this function returns always true then we can remove the code depending on lazy FPU mode. Actually this has already been done in "x86/fpu: Remove use_eager_fpu()" Ref: https://patchwork.kernel.org/patch/9365883/ > static void __init fpu__init_parse_early_param(void) > { > - if (cmdline_find_option_bool(boot_command_line, "eagerfpu=off")) { > - eagerfpu = DISABLE; > - fpu__clear_eager_fpu_features(); > - } Since this patch removes the kernel boot parameter "eagerfpu", maybe we should remove it from the Documentation. This has also been done by commit "x86/fpu: Finish excising 'eagerfpu'" Ref: https://patchwork.kernel.org/patch/9380673/ I will try backporting those patches unless anyone has any objections. Thanks, Daniel Sangorrin