mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Alan Stern'" <stern@rowland.harvard.edu>,
	"'Chen, Alvin'" <alvin.chen@intel.com>
Cc: "'Sergei Shtylyov'" <sergei.shtylyov@cogentembedded.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	"'Boon Leong Ong'" <boon.leong.ong@intel.com>,
	"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH v4] USB: ehci-pci: USB host controller support for Intel Quark X1000
Date: Wed, 02 Jul 2014 09:34:48 +0900	[thread overview]
Message-ID: <000d01cf958d$6dcaac40$496004c0$%han@samsung.com> (raw)
In-Reply-To: <Pine.LNX.4.44L0.1407011009240.874-100000@iolanthe.rowland.org>

On Tuesday, July 01, 2014 11:12 PM, Alan Stern wrote: 
> On Tue, 1 Jul 2014, Chen, Alvin wrote:
> 
> > From: Bryan O'Donoghue <bryan.odonoghue@intel.com>
> >
> > The EHCI packet buffer in/out threshold is programmable for Intel Quark X1000
> > USB host controller, and the default value is 0x20 dwords. The in/out threshold
> > can be programmed to 0x80 dwords (512 Bytes) to maximize the perfomrance,
> > but only when isochronous/interrupt transactions are not initiated by the USB
> > host controller. This patch is to reconfigure the packet buffer in/out
> > threshold as maximal as possible to maximize the performance, and 0x7F dwords
> > (508 Bytes) should be used because the USB host controller initiates
> > isochronous/interrupt transactions.
> >
> > Signed-off-by: Bryan O'Donoghue <bryan.odonoghue@intel.com>
> > Signed-off-by: Alvin (Weike) Chen <alvin.chen@intel.com>
> 
> Acked-by: Alan Stern <stern@rowland.harvard.edu>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

Best regards,
Jingoo Han

> 
> There's one error in the style...
> 
> > diff --git a/drivers/usb/host/ehci-pci.c b/drivers/usb/host/ehci-pci.c
> > index 3e86bf4..429434d 100644
> > --- a/drivers/usb/host/ehci-pci.c
> > +++ b/drivers/usb/host/ehci-pci.c
> > @@ -35,6 +35,21 @@ static const char hcd_name[] = "ehci-pci";
> >  #define PCI_DEVICE_ID_INTEL_CE4100_USB	0x2e70
> >
> >  /*-------------------------------------------------------------------------*/
> > +#define PCI_DEVICE_ID_INTEL_QUARK_X1000_SOC		0x0939
> > +static inline bool is_intel_quark_x1000(struct pci_dev *pdev)
> > +{
> > +	return pdev->vendor == PCI_VENDOR_ID_INTEL &&
> > +		pdev->device == PCI_DEVICE_ID_INTEL_QUARK_X1000_SOC;
> > +}
> > +
> > +/*
> > +	* 0x84 is the offset of in/out threshold register,
> > +	* and it is the same offset as the register of 'hostpc'.
> > +	*/
> 
> This comment isn't formatted right.  It should be like this:
> 
> /*
>  * blah blah blah
>  * blah blah blah
>  */
> 
> If you want to submit a corrected version, you can.  Or Greg may be
> willing to fix the style when he merges this patch.
> 
> Alan Stern



      reply	other threads:[~2014-07-02  0:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-01 15:15 [PATCH v4] USB: ehci-pci: Add support for Intel Quark X1000 USB Chen, Alvin
2014-07-01 15:15 ` [PATCH v4] USB: ehci-pci: USB host controller support for Intel Quark X1000 Chen, Alvin
2014-07-01 14:12   ` Alan Stern
2014-07-02  0:34     ` Jingoo Han [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='000d01cf958d$6dcaac40$496004c0$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=alvin.chen@intel.com \
    --cc=boon.leong.ong@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®