From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698Ab2HAXAB (ORCPT ); Wed, 1 Aug 2012 19:00:01 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:8925 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751697Ab2HAW7t (ORCPT ); Wed, 1 Aug 2012 18:59:49 -0400 X-AuditID: cbfee61b-b7f566d000005c8a-57-5019b4e3dd78 From: Jingoo Han To: "'Damien Cassou'" Cc: "'Florian Tobias Schandinat'" , linux-fbdev@vger.kernel.org, linux-kernel@vger.kernel.org, "'Sachin Kamat'" , "'Jingoo Han'" References: <877gti1t48.fsf@gmail.com> In-reply-to: <877gti1t48.fsf@gmail.com> Subject: Re: [PATCH v2] video: exynos_dp: use devm_clk_get function Date: Thu, 02 Aug 2012 07:59:46 +0900 Message-id: <000e01cd7039$58e08b90$0aa1a2b0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac1wAZrrzyIOF4KjTSaXFU5q6sqr6QAN3Lcw Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrMLMWRmVeSWpSXmKPExsVy+t9jAd3HWyQDDHZ18lqc6PvAanF51xw2 ByaPz5vkAhijuGxSUnMyy1KL9O0SuDIufv/EVLBWpmJi707mBsb9Yl2MnBwSAiYSy3bfZ4Ww xSQu3FvP1sXIxSEksIhR4kTzGlYI5xejxLYTaxlBqtgE1CS+fDnMDmKLCOhKnFx9mxGkiFng OKPEjRvbwBJCQEXN3a/AxnIKqEusungQLC4s4Cxxd8JpsDiLgKpEx4GDzCA2r4CtxI4Fd9kh bEGJH5PvsYDYzAJaEut3HmeCsOUlNq95C1TPAXSqusSjv7oQNxhJdB+bzQxRIiKx78U7xgmM QrOQTJqFZNIsJJNmIWlZwMiyilE0tSC5oDgpPddIrzgxt7g0L10vOT93EyM4qJ9J72Bc1WBx iFGAg1GJh3dlqWSAEGtiWXFl7iFGCQ5mJRFexy6gEG9KYmVValF+fFFpTmrxIUZpDhYlcV4T 76/+QgLpiSWp2ampBalFMFkmDk6pBkapTd8l9R79lNqQF60V718u8jHhwOsKRXeDi1ul1C+d dLnTtWd3QWvBFO/ixQa217meyDyxlXpdZThfSjJPLSPZiE1j+dNZMwUf7uhi/SHoLJs9yWB+ lCS/x48PpyxSg1QjAm4Kx0toO9ye5vprUlMyn2DagulWXy0k/kk6vam18nv+42fZTyWW4oxE Qy3mouJEAH38YjVmAgAA X-TM-AS-MML: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 02, 2012 1:21 AM Damien Cassou wrote: > > From: Damien Cassou > > The devm_clk_get function allocates memory that is released when a driver > detaches. This patch uses this function for data that is allocated in the probe > function of a platform device and is only freed in the remove function. > > Additionally, this patch removes a null check after platform_get_resource that > is redundant with the one done by devm_request_and_ioremap. > > Signed-off-by: Damien Cassou Acked-by: Jingoo Han Thank you for sending the patch. Best regards, Jingoo Han > > --- > Changed subject line and description > drivers/video/exynos/exynos_dp_core.c | 27 +++++++-------------------- > 1 file changed, 7 insertions(+), 20 deletions(-) > > diff --git a/drivers/video/exynos/exynos_dp_core.c b/drivers/video/exynos/exynos_dp_core.c > index c6c016a..00fe4f0 100644 > --- a/drivers/video/exynos/exynos_dp_core.c > +++ b/drivers/video/exynos/exynos_dp_core.c > @@ -872,7 +872,7 @@ static int __devinit exynos_dp_probe(struct platform_device *pdev) > > dp->dev = &pdev->dev; > > - dp->clock = clk_get(&pdev->dev, "dp"); > + dp->clock = devm_clk_get(&pdev->dev, "dp"); > if (IS_ERR(dp->clock)) { > dev_err(&pdev->dev, "failed to get clock\n"); > return PTR_ERR(dp->clock); > @@ -881,31 +881,24 @@ static int __devinit exynos_dp_probe(struct platform_device *pdev) > clk_enable(dp->clock); > > res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > - if (!res) { > - dev_err(&pdev->dev, "failed to get registers\n"); > - ret = -EINVAL; > - goto err_clock; > - } > > dp->reg_base = devm_request_and_ioremap(&pdev->dev, res); > if (!dp->reg_base) { > dev_err(&pdev->dev, "failed to ioremap\n"); > - ret = -ENOMEM; > - goto err_clock; > + return -ENOMEM; > } > > dp->irq = platform_get_irq(pdev, 0); > if (!dp->irq) { > dev_err(&pdev->dev, "failed to get irq\n"); > - ret = -ENODEV; > - goto err_clock; > + return -ENODEV; > } > > ret = devm_request_irq(&pdev->dev, dp->irq, exynos_dp_irq_handler, 0, > "exynos-dp", dp); > if (ret) { > dev_err(&pdev->dev, "failed to request irq\n"); > - goto err_clock; > + return ret; > } > > dp->video_info = pdata->video_info; > @@ -917,7 +910,7 @@ static int __devinit exynos_dp_probe(struct platform_device *pdev) > ret = exynos_dp_detect_hpd(dp); > if (ret) { > dev_err(&pdev->dev, "unable to detect hpd\n"); > - goto err_clock; > + return ret; > } > > exynos_dp_handle_edid(dp); > @@ -926,7 +919,7 @@ static int __devinit exynos_dp_probe(struct platform_device *pdev) > dp->video_info->link_rate); > if (ret) { > dev_err(&pdev->dev, "unable to do link train\n"); > - goto err_clock; > + return ret; > } > > exynos_dp_enable_scramble(dp, 1); > @@ -940,17 +933,12 @@ static int __devinit exynos_dp_probe(struct platform_device *pdev) > ret = exynos_dp_config_video(dp, dp->video_info); > if (ret) { > dev_err(&pdev->dev, "unable to config video\n"); > - goto err_clock; > + return ret; > } > > platform_set_drvdata(pdev, dp); > > return 0; > - > -err_clock: > - clk_put(dp->clock); > - > - return ret; > } > > static int __devexit exynos_dp_remove(struct platform_device *pdev) > @@ -962,7 +950,6 @@ static int __devexit exynos_dp_remove(struct platform_device *pdev) > pdata->phy_exit(); > > clk_disable(dp->clock); > - clk_put(dp->clock); > > return 0; > }