From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755930AbcAYJt6 (ORCPT ); Mon, 25 Jan 2016 04:49:58 -0500 Received: from mailout2.samsung.com ([203.254.224.25]:36815 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbcAYJtz (ORCPT ); Mon, 25 Jan 2016 04:49:55 -0500 X-AuditID: cbfee61b-f793c6d00000236c-d0-56a5efc1a3bf From: Chao Yu To: "'Jaegeuk Kim'" Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net References: <1453580148-61861-1-git-send-email-jaegeuk@kernel.org> <1453580148-61861-2-git-send-email-jaegeuk@kernel.org> In-reply-to: <1453580148-61861-2-git-send-email-jaegeuk@kernel.org> Subject: RE: [f2fs-dev] [PATCH 2/2] f2fs: fix to overcome inline_data floods Date: Mon, 25 Jan 2016 17:49:06 +0800 Message-id: <000e01d15755$bb6b1990$32414cb0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Outlook 14.0 Thread-index: AQItp6w8bFynmuwH26WvZWYY7LI+zQGdus0MnkZsXAA= Content-language: zh-cn X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFnrKLMWRmVeSWpSXmKPExsVy+t9jQd2D75eGGcw5q2rxZP0sZotLi9wt 9uw9yWJxedccNgcWj02rOtk8di/4zOTxeZNcAHMUl01Kak5mWWqRvl0CV8a7da2sBdsFK1Ys 3sbcwDifr4uRg0NCwETi9NOiLkZOIFNM4sK99WwgtpDALEaJvr8ZXYxcQPYrRomHZx4zgSTY BFQklnf8B7NFBNQkevdNAbOZBTIlJvS/YIdorpa4MHECmM0p4Cyx/MgGVhBbWMBHYm3jF7B6 FgFVid4b21lBbuAVsJR4+y8UJMwrICjxY/I9FoiRWhLrdx6HGi8vsXnNW2aIOxUkdpx9zQjS KiJgJbHpigpEibjExiO3WCYwCs1CMmkWkkmzkEyahaRlASPLKkaJ1ILkguKk9FyjvNRyveLE 3OLSvHS95PzcTYzgwH8mvYPx8C73Q4wCHIxKPLwWakvDhFgTy4orcw8xSnAwK4nwer8DCvGm JFZWpRblxxeV5qQWH2KU5mBREufddykyTEggPbEkNTs1tSC1CCbLxMEp1cCoqmwk2n84+4BT hVmzRMKKi/Y1Eek/uDoumRlE3Dpz1vv0xgSmE4UMz4/Ntvrf6PD8xzKPc7ffJc6/EcVeZSHg Wyo1dZ39WfOzafsmB4Z7F8xqOqPPbR+butL/VNeOL55qcjP/GL5wVxVSXXXUwtmySjJ7yzyT 9PqEadZ/j0p2KZtninZ+tFViKc5INNRiLipOBABzPhG4eAIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Jaegeuk, > -----Original Message----- > From: Jaegeuk Kim [mailto:jaegeuk@kernel.org] > Sent: Sunday, January 24, 2016 4:16 AM > To: linux-kernel@vger.kernel.org; linux-fsdevel@vger.kernel.org; > linux-f2fs-devel@lists.sourceforge.net > Cc: Jaegeuk Kim > Subject: [f2fs-dev] [PATCH 2/2] f2fs: fix to overcome inline_data floods > > The scenario is: > 1. create lots of node blocks > 2. sync > 3. write lots of inline_data > -> got panic due to no free space > > In that case, we should flush node blocks when writing inline_data in #3, > and trigger gc as well. > > Signed-off-by: Jaegeuk Kim > --- > fs/f2fs/gc.c | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c > index 0204433..8686231 100644 > --- a/fs/f2fs/gc.c > +++ b/fs/f2fs/gc.c > @@ -838,8 +838,15 @@ gc_more: > > if (gc_type == BG_GC && has_not_enough_free_secs(sbi, sec_freed)) { > gc_type = FG_GC; > + /* > + * If there is no victim and no prefree segment but still not > + * enough free sections, we should flush dent/node blocks and do > + * garbage collections. > + */ > if (__get_victim(sbi, &segno, gc_type) || prefree_segments(sbi)) > write_checkpoint(sbi, &cpc); > + else if (has_not_enough_free_secs(sbi, 0)) I think this condition make checkpoint been triggered more frequently, could we trigger cp when dent/node block exceed some threshold? Thanks, > + write_checkpoint(sbi, &cpc); > } > > if (segno == NULL_SEGNO && !__get_victim(sbi, &segno, gc_type)) > -- > 2.6.3 > > > ------------------------------------------------------------------------------ > Site24x7 APM Insight: Get Deep Visibility into Application Performance > APM + Mobile APM + RUM: Monitor 3 App instances at just $35/Month > Monitor end-to-end web transactions and take corrective actions now > Troubleshoot faster and improve end-user experience. Signup Now! > http://pubads.g.doubleclick.net/gampad/clk?id=267308311&iu=/4140 > _______________________________________________ > Linux-f2fs-devel mailing list > Linux-f2fs-devel@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/linux-f2fs-devel