From: IAN CHEN <ian.cy.chen@samsung.com>
To: "'Linus Walleij'" <linus.walleij@linaro.org>
Cc: cjb@laptop.org, linkinjeon@gmail.com, adrian.hunter@intel.com,
subhashj@codeaurora.org, linux-mmc@vger.kernel.org,
linux-kernel@vger.kernel.org, d.j.shin@samsung.com,
jongtae22.kim@samsung.com, kyungmin.park@samsung.com,
jh80.chung@samsung.com
Subject: RE: [PATCH v3] mmc: card: Skip secure option for MoviNAND.
Date: Thu, 16 Aug 2012 13:09:39 +0900 [thread overview]
Message-ID: <000f01cd7b64$f70f6620$e52e3260$%cy.chen@samsung.com> (raw)
In-Reply-To: <CACRpkdYNKxjRXC=4no0p55ADkUvXTEcfW3b2z+Exg=cpHCtAAQ@mail.gmail.com>
MMC_QUIRK_SEC_ERASE_TRIM_BROKEN seems quite clear but I might not use "SEC"
due to it could be Samsung Electronics Corporation.
So, how about MMC_QUIRK_SECDISCARD_BROKEN which was used in
mmc_blk_issue_secdiscard_rq() naming, the function we skip.
Or, MMC_QUIRK_SECERASE_SECTRIM_BROKEN?
Regards,
Ian
-----Original Message-----
From: Linus Walleij [mailto:linus.walleij@linaro.org]
Sent: Tuesday, August 14, 2012 5:07 PM
To: IAN CHEN
Cc: cjb@laptop.org; linkinjeon@gmail.com; adrian.hunter@intel.com;
subhashj@codeaurora.org; linux-mmc@vger.kernel.org;
linux-kernel@vger.kernel.org; d.j.shin@samsung.com;
jongtae22.kim@samsung.com; kyungmin.park@samsung.com; jh80.chung@samsung.com
Subject: Re: [PATCH v3] mmc: card: Skip secure option for MoviNAND.
On Tue, Aug 14, 2012 at 9:06 AM, IAN CHEN <ian.cy.chen@samsung.com> wrote:
> +#define MMC_QUIRK_SECURE_MODE_BROKEN (1<<10) /* Skip secure for
> erase/trim */
OK this will work and sorry for being picky, but we are working with RPMB
support and that's some other "secure mode" so to avoid any
misuderstandings it's better to name the flag like I proposed,
MMC_QUIRK_SEC_ERASE_TRIM_BROKEN
I won't die if this goes in though :-)
Yours,
Linus Walleij
next prev parent reply other threads:[~2012-08-16 4:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-14 7:06 IAN CHEN
2012-08-14 7:23 ` Namjae Jeon
2012-08-14 8:06 ` Linus Walleij
2012-08-16 4:09 ` IAN CHEN [this message]
2012-08-16 4:14 ` Jaehoon Chung
2012-08-14 19:07 ` Jae hoon Chung
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='000f01cd7b64$f70f6620$e52e3260$%cy.chen@samsung.com' \
--to=ian.cy.chen@samsung.com \
--cc=adrian.hunter@intel.com \
--cc=cjb@laptop.org \
--cc=d.j.shin@samsung.com \
--cc=jh80.chung@samsung.com \
--cc=jongtae22.kim@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linkinjeon@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=subhashj@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®