From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754098Ab2HBXSG (ORCPT ); Thu, 2 Aug 2012 19:18:06 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:50780 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753732Ab2HBXSB (ORCPT ); Thu, 2 Aug 2012 19:18:01 -0400 X-AuditID: cbfee61a-b7f616d000004b7e-b9-501b0aa7caed From: Jingoo Han To: "'Thierry Reding'" Cc: linux-kernel@vger.kernel.org, "'Jingoo Han'" References: <002401cd708c$b3c09ed0$1b41dc70$%han@samsung.com> <20120802095354.GA18945@avionic-0098.adnet.avionic-design.de> In-reply-to: <20120802095354.GA18945@avionic-0098.adnet.avionic-design.de> Subject: Re: [PATCH 2/2] pwm: samsung: fix the number of PWMs Date: Fri, 03 Aug 2012 08:17:59 +0900 Message-id: <001001cd7105$0e465d40$2ad317c0$%han@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=us-ascii Content-transfer-encoding: 7bit X-Mailer: Microsoft Office Outlook 12.0 Thread-index: Ac1wlL4TZylWUX2wQaqBCCdr72LhNwAbc+MA Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrNLMWRmVeSWpSXmKPExsVy+t9jAd3lXNIBBkdWiVlc3jWHzYHR4/Mm uQDGKC6blNSczLLUIn27BK6Mzl0P2QuW8FfMuN3O2MA4naeLkYNDQsBEouG9WRcjJ5ApJnHh 3nq2LkYuDiGBRYwSq+/uhHJmM0n03uxkBKliE1CT+PLlMDuILSJgLrFk0V5mkEHMAi4SR6eJ gISFBGolVpy9ygJicwp4SUw++J4NxBYWsJVYcfMb2BgWAVWJtddPMoPYvEDxVXvuskPYghI/ Jt8D62UW0JJYv/M4E4QtL7F5zVtmiJvVJR791YW4wEji4Pu1UOUiEvtevGOcwCg0C8mkWUgm zUIyaRaSlgWMLKsYRVMLkguKk9JzDfWKE3OLS/PS9ZLzczcxgoP4mdQOxpUNFocYBTgYlXh4 V5ZKBgixJpYVV+YeYpTgYFYS4a1aIhUgxJuSWFmVWpQfX1Sak1p8iFGag0VJnNfY+6u/kEB6 YklqdmpqQWoRTJaJg1OqgbH3qX+d7+fHGacnL9F4vCr1vu7XoF9PGDwNltz+dbDpTMTPWXJs LLYfH29mje/6tfTl92dV3qKWtZI+f5kTe232XVSJeuSxe8vi6fPDXM2kZ9378Pyc7ZSv99oN ftjO4msReTjjsA7z5p7CuwY5tz3/L56TlWQt8uI+34yHEz60r+R1P+H3p1VSiaU4I9FQi7mo OBEAuVJajF4CAAA= X-TM-AS-MML: No Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday, August 02, 2012 6:54 PM Thierry Reding wrote: > > On Thu, Aug 02, 2012 at 05:56:27PM +0900, Jingoo Han wrote: > > Samsung SoC can provide 4 PWMs; thus, the number of PWMs should be > > set as 4. > > > > Signed-off-by: Jingoo Han > > --- > > drivers/pwm/pwm-samsung.c | 2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/pwm/pwm-samsung.c b/drivers/pwm/pwm-samsung.c > > index e5187c0..32562c6 100644 > > --- a/drivers/pwm/pwm-samsung.c > > +++ b/drivers/pwm/pwm-samsung.c > > @@ -228,7 +228,7 @@ static int s3c_pwm_probe(struct platform_device *pdev) > > s3c->chip.dev = &pdev->dev; > > s3c->chip.ops = &s3c_pwm_ops; > > s3c->chip.base = -1; > > - s3c->chip.npwm = 1; > > + s3c->chip.npwm = 4; > > I don't think this is correct. The driver seems to be using the platform > device id as index currently, which indicates that the driver is bound > against 4 different platform devices, each representing a single PWM. If > you want to service multiple PWM devices by a single instance you need > to make further changes to the driver. For instance the tcon_base is > initialized based on the platform id. This could easily be replaced by > making it depend on the .hwpwm member of pwm_device. I just want to use pwm backlight on Samsung SoC boards. After moving samusng pwm driver from 'arch/arm/plat-samsung/' to 'drivers/pwm/', pwm bakclight does not work properly. When pwm_id is '1' and PWM backlight calls pwm_request(data->pwm_id, "pwm-backlight"), pwm_to_device() returns NULL. Then, do you mean that? s3c->chip.npwm = id + 1; > > You may also want to consider making the driver a proper module if that > works on the platforms that need it. I see that it is currently an > arch_initcall, but it might be cleaner to use deferred driver probe > instead. Sorry, I cannot understand what you say. > > Thierry