From: "Manfred Spraul" <manfred@colorfullife.com>
To: "Andrew Morton" <akpm@zip.com.au>
Cc: "Paul Clements" <kernel@steeleye.com>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] 2.4.18 raid1 - fix SMP locking/interrupt
Date: Mon, 25 Mar 2002 21:57:02 +0100 [thread overview]
Message-ID: <001101c1d43f$9e0b3f90$010411ac@local> (raw)
In-Reply-To: <001001c1d436$90abdf70$010411ac@local> <3C9F870A.E1280D33@zip.com.au>
From: "Andrew Morton" <akpm@zip.com.au>
> > OTHO, if a function doesn't work correctly if it's called with
disabled
> > interrupts, then it should not use spin_lock_irqsave() - it's
> > misleading.
> > e.g. if it calls kmalloc(GFP_KERNEL), down(), schedule(), etc.
>
> mm? Those are legal (albeit unpleasant) inside local_irq_save(),
> but illegal inside global_cli() in 2.5. Aren't they? If not,
> then release_kernel_lock() needs talking to.
>
If a function is called with disabled interrupts, then the caller
probably expects that the interrupts remain disabled - otherwise he
would have reenabled them before calling. schedule reenables interrupts.
The calls might be legal, but usually they indicate a bug.
--
Manfred
prev parent reply other threads:[~2002-03-25 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-03-25 19:50 Manfred Spraul
2002-03-25 20:22 ` Andrew Morton
2002-03-25 20:57 ` Manfred Spraul [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001101c1d43f$9e0b3f90$010411ac@local' \
--to=manfred@colorfullife.com \
--cc=akpm@zip.com.au \
--cc=kernel@steeleye.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®