From: "Christopher Hoover" <ch@murgatroid.com>
To: "'Dave Jones'" <davej@suse.de>, "'Christopher Hoover'" <ch@hpl.hp.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH] 2.5.24+ fix needed for non-modular video build
Date: Tue, 23 Jul 2002 10:18:27 -0700 [thread overview]
Message-ID: <001201c2326c$f5d48e80$7a00000a@derelict> (raw)
In-Reply-To: <20020723143744.C14323@suse.de>
> On Mon, Jul 22, 2002 at 01:45:14PM -0700, Christopher Hoover wrote:
>
> > -#ifdef MODULE
> > -#if defined(CONFIG_PROC_FS) && defined(CONFIG_VIDEO_PROC_FS)
> > static void videodev_proc_destroy(void)
> > {
> > if (video_dev_proc_entry != NULL)
> > @@ -298,8 +296,6 @@
> > if (video_proc_entry != NULL)
> > remove_proc_entry("video", &proc_root);
> > }
> > -#endif
> > -#endif
>
> Why are you removing the inner ifdef too ? This looks like it
> makes sense (to me at least)
It makes sense but it is redundant -- there is a wider-scoped ifdef in
the file that catches that function and others.
-ch
mailto:ch@murgatroid.com
mailto:ch@hpl.hp.com
prev parent reply other threads:[~2002-07-23 17:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-07-22 20:45 Christopher Hoover
2002-07-23 12:37 ` Dave Jones
2002-07-23 17:18 ` Christopher Hoover [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001201c2326c$f5d48e80$7a00000a@derelict' \
--to=ch@murgatroid.com \
--cc=ch@hpl.hp.com \
--cc=davej@suse.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®