mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Michal Simek'" <michal.simek@xilinx.com>,
	linux-kernel@vger.kernel.org, monstr@monstr.eu
Cc: "'Jean-Christophe Plagniol-Villard'" <plagnioj@jcrosoft.com>,
	"'Tomi Valkeinen'" <tomi.valkeinen@ti.com>,
	linux-fbdev@vger.kernel.org, "'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH 3/3] video: xilinxfb: Simplify error path
Date: Thu, 12 Sep 2013 19:46:50 +0900	[thread overview]
Message-ID: <001301ceafa5$630798f0$2916cad0$%han@samsung.com> (raw)
In-Reply-To: <940bbdfc5c67282ab461b9c82b55f18fc34c959d.1378965270.git.michal.simek@xilinx.com>

On Thursday, September 12, 2013 2:55 PM, Michal Simek wrote:
> 
> devm_iounmap is called automatically that's why remove it from the code
> dev_set_drvdata(dev, NULL) is called by generic code
> after device_release or on probe failure.
> 
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>

Reviewed-by: Jingoo Han <jg1.han@samsung.com>

> ---
>  drivers/video/xilinxfb.c | 28 ++++++----------------------
>  1 file changed, 6 insertions(+), 22 deletions(-)


  reply	other threads:[~2013-09-12 10:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-09-12  5:54 [PATCH 1/3] video: xilinxfb: Use standard variable name convention Michal Simek
2013-09-12  5:54 ` [PATCH 2/3] video: xilinxfb: Use devm_kzalloc instead of kzalloc Michal Simek
2013-09-12 10:42   ` Jingoo Han
2013-09-12  5:54 ` [PATCH 3/3] video: xilinxfb: Simplify error path Michal Simek
2013-09-12 10:46   ` Jingoo Han [this message]
2013-09-16  9:51   ` Tomi Valkeinen
2013-09-16 10:33     ` Michal Simek
2013-09-16 10:34       ` Tomi Valkeinen
2013-09-30 12:05         ` Michal Simek
2013-10-09  9:02           ` Tomi Valkeinen
2013-10-09 10:25             ` Michal Simek
2013-10-09 10:28               ` Tomi Valkeinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001301ceafa5$630798f0$2916cad0$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michal.simek@xilinx.com \
    --cc=monstr@monstr.eu \
    --cc=plagnioj@jcrosoft.com \
    --cc=tomi.valkeinen@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®