From: Jingoo Han <jg1.han@samsung.com>
To: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, "'Hans J. Koch'" <hjk@hansjkoch.de>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 5/5] uio: uio_sercos3: remove unnecessary pci_set_drvdata()
Date: Thu, 12 Sep 2013 15:39:55 +0900 [thread overview]
Message-ID: <001401ceaf82$e4b26970$ae173c50$%han@samsung.com> (raw)
In-Reply-To: <001001ceaf82$978a36f0$c69ea4d0$%han@samsung.com>
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
drivers/uio/uio_sercos3.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/uio/uio_sercos3.c b/drivers/uio/uio_sercos3.c
index 5419832..9cfdfca 100644
--- a/drivers/uio/uio_sercos3.c
+++ b/drivers/uio/uio_sercos3.c
@@ -188,7 +188,6 @@ static void sercos3_pci_remove(struct pci_dev *dev)
uio_unregister_device(info);
pci_release_regions(dev);
pci_disable_device(dev);
- pci_set_drvdata(dev, NULL);
for (i = 0; i < 5; i++) {
if (info->mem[i].internal_addr)
iounmap(info->mem[i].internal_addr);
--
1.7.10.4
prev parent reply other threads:[~2013-09-12 6:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-09-12 6:37 [PATCH 1/5] uio: uio_aec: " Jingoo Han
2013-09-12 6:38 ` [PATCH 2/5] uio: uio_cif: " Jingoo Han
2013-09-12 6:39 ` [PATCH 3/5] uio: uio_mf624: " Jingoo Han
2013-09-12 6:39 ` [PATCH 4/5] uio: uio_netx: " Jingoo Han
2013-09-12 6:39 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001401ceaf82$e4b26970$ae173c50$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=gregkh@linuxfoundation.org \
--cc=hjk@hansjkoch.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®