From: Ilkka Koskinen <ilkka@os.amperecomputing.com>
To: Chu Guangqing <chuguangqing@inspur.com>
Cc: john.g.garry@oracle.com, will@kernel.org, james.clark@linaro.org,
mike.leach@linaro.org, leo.yan@linux.dev, peterz@infradead.org,
mingo@redhat.com, acme@kernel.org, namhyung@kernel.org,
mark.rutland@arm.com, alexander.shishkin@linux.intel.com,
jolsa@kernel.org, irogers@google.com, adrian.hunter@intel.com,
linux-arm-kernel@lists.infradead.org,
linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools: Fix typo error in json file
Date: Fri, 31 Oct 2025 12:25:37 -0700 (PDT) [thread overview]
Message-ID: <0016eecf-e261-a16e-461e-5f7c40705060@os.amperecomputing.com> (raw)
In-Reply-To: <20251031031729.2304-1-chuguangqing@inspur.com>
On Fri, 31 Oct 2025, Chu Guangqing wrote:
> Correct instruction spelling errors.
>
> Signed-off-by: Chu Guangqing <chuguangqing@inspur.com>
Thanks for the patch. Just one comment, would you mind changing the
subject line slightly. Something like
"perf vendor events arm64: Fix typo in Ampere eMag json file"
With that change
Reviewed-by: Ilkka Koskinen <ilkka@os.amperecomputing.com>
Cheers, Ilkka
> ---
> tools/perf/pmu-events/arch/arm64/ampere/emag/cache.json | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tools/perf/pmu-events/arch/arm64/ampere/emag/cache.json b/tools/perf/pmu-events/arch/arm64/ampere/emag/cache.json
> index 4cc50b7da526..4001cc5753a7 100644
> --- a/tools/perf/pmu-events/arch/arm64/ampere/emag/cache.json
> +++ b/tools/perf/pmu-events/arch/arm64/ampere/emag/cache.json
> @@ -81,7 +81,7 @@
> "BriefDescription": "L2D TLB access"
> },
> {
> - "PublicDescription": "Level 2 access to instruciton TLB that caused a page table walk. This event counts on any instruciton access which causes L2I_TLB_REFILL to count",
> + "PublicDescription": "Level 2 access to instruction TLB that caused a page table walk. This event counts on any instruction access which causes L2I_TLB_REFILL to count",
> "EventCode": "0x35",
> "EventName": "L2I_TLB_ACCESS",
> "BriefDescription": "L2I TLB access"
> --
> 2.43.7
>
>
>
next prev parent reply other threads:[~2025-10-31 19:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-31 3:17 Chu Guangqing
2025-10-31 10:00 ` James Clark
2025-10-31 19:25 ` Ilkka Koskinen [this message]
2025-10-31 19:30 ` Namhyung Kim
2025-11-03 17:53 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0016eecf-e261-a16e-461e-5f7c40705060@os.amperecomputing.com \
--to=ilkka@os.amperecomputing.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=chuguangqing@inspur.com \
--cc=irogers@google.com \
--cc=james.clark@linaro.org \
--cc=john.g.garry@oracle.com \
--cc=jolsa@kernel.org \
--cc=leo.yan@linux.dev \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mike.leach@linaro.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=peterz@infradead.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®