mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Ben Castricum" <lk08@bencastricum.nl>
To: <linux-kernel@vger.kernel.org>
Subject: [TRIVIAL PATCH] Microcode: show results on success too plus fix typo
Date: Wed, 26 Mar 2008 21:22:25 +0100	[thread overview]
Message-ID: <001701c88f7f$1e2b6c80$0602a8c0@links> (raw)

Show a bit more info when updating microcode. It used to be there but 
no with DEBUG unset makes it very silent.

This is my first patch, please let me know if I did anything wrong.

Signed-off-by: Ben Castricum <lk08@bencastricum.nl>

diff --git a/arch/x86/kernel/microcode.c b/arch/x86/kernel/microcode.c
index f2702d0..ca1fd52 100644
--- a/arch/x86/kernel/microcode.c
+++ b/arch/x86/kernel/microcode.c
@@ -336,11 +336,11 @@ static void apply_microcode(int cpu)

  spin_unlock_irqrestore(&microcode_update_lock, flags);
  if (val[1] != uci->mc->hdr.rev) {
-  printk(KERN_ERR "microcode: CPU%d updated from revision "
+  printk(KERN_ERR "microcode: CPU%d update from revision "
    "0x%x to 0x%x failed\n", cpu_num, uci->rev, val[1]);
   return;
  }
- pr_debug("microcode: CPU%d updated from revision "
+ printk(KERN_INFO "microcode: CPU%d updated from revision "
         "0x%x to 0x%x, date = %08x \n",
         cpu_num, uci->rev, val[1], uci->mc->hdr.date);
  uci->rev = val[1];


             reply	other threads:[~2008-03-26 20:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-26 20:22 Ben Castricum [this message]
2008-03-26 20:40 ` Randy Dunlap
2008-03-26 21:04   ` Jesper Juhl
2008-03-26 21:50 ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001701c88f7f$1e2b6c80$0602a8c0@links' \
    --to=lk08@bencastricum.nl \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®