From: Jingoo Han <jg1.han@samsung.com>
To: "'Sachin Kamat'" <spk.linux@gmail.com>,
"'Tomasz Figa'" <t.figa@samsung.com>
Cc: "'open list'" <linux-kernel@vger.kernel.org>,
"'linux-samsung-soc'" <linux-samsung-soc@vger.kernel.org>,
"'Kishon Vijay Abraham I'" <kishon@ti.com>,
"'Doug Anderson'" <dianders@chromium.org>,
"'Vivek Gautam'" <gautam.vivek@samsung.com>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: Re: [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs
Date: Wed, 09 Jul 2014 13:07:31 +0900 [thread overview]
Message-ID: <001701cf9b2b$4e228d60$ea67a820$%han@samsung.com> (raw)
In-Reply-To: <CAK5sBcHJeK5=LrYfBO5C4Ht1upLes2ynvofuhBo3_xYsxGO1=g@mail.gmail.com>
On Wednesday, July 09, 2014 12:42 PM, Sachin Kamat wrote:
> On Tue, Jul 8, 2014 at 9:15 PM, Tomasz Figa <t.figa@samsung.com> wrote:
> > On 30.06.2014 10:56, Sachin Kamat wrote:
> >> Since the USB 2.0 PHYs are required only with EHCI/OHCI USB drivers,
> >
> > That's not true. They are also required for USB gadget controller
> > supported by the DWC2 gadget driver (formerly s3c-hsotg). Otherwise the
> > change makes sense to me.
>
> Do you propose I amend just the patch description or also add a dependency on
> USB_DWC2 along with EHCI and OHCI. I do not have anything to test this. Based
> on your input I will re-spin the patch.
I agree with Tomasz Figa's statement. Personally, I think that it would
be good to amend the commit message and add a dependency on USB_DWC2. :-)
Thank you.
Best regards,
Jingoo Han
>
> --
> Regards,
> Sachin.
prev parent reply other threads:[~2014-07-09 4:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-30 8:56 Sachin Kamat
2014-06-30 8:56 ` [PATCH 2/2] phy: Kconfig: Update config for Exynos USB DRD Sachin Kamat
2014-07-08 4:19 ` [PATCH 1/2] phy: Kconfig: Re-organize Exynos USB 2.0 PHY configs Sachin Kamat
2014-07-08 15:45 ` Tomasz Figa
2014-07-09 3:42 ` Sachin Kamat
2014-07-09 4:07 ` Jingoo Han [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001701cf9b2b$4e228d60$ea67a820$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=dianders@chromium.org \
--cc=gautam.vivek@samsung.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=spk.linux@gmail.com \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome