From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752163AbcBECJq (ORCPT ); Thu, 4 Feb 2016 21:09:46 -0500 Received: from mailout3.samsung.com ([203.254.224.33]:37120 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752044AbcBECJo convert rfc822-to-8bit (ORCPT ); Thu, 4 Feb 2016 21:09:44 -0500 X-AuditID: cbfee68d-f79646d000001355-53-56b4046622e8 From: =?ks_c_5601-1987?B?sejA57/4?= To: "'Dan Carpenter'" , "'walter harms'" Cc: "'MyungJoo Ham'" , "'Chanwoo Choi'" , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: <20160204113609.GA11239@mwanda> <56B3486D.1050201@bfs.de> <20160204195341.GB32153@mwanda> In-reply-to: <20160204195341.GB32153@mwanda> Subject: RE: [patch] extcon: use correct size Date: Fri, 05 Feb 2016 11:09:41 +0900 Message-id: <001701d15fba$4676ed90$d364c8b0$@samsung.com> MIME-version: 1.0 Content-type: text/plain; charset=ks_c_5601-1987 Content-transfer-encoding: 8BIT X-Mailer: Microsoft Outlook 14.0 Thread-index: AQEMRp3MKdCLSF9diagEXcAiI1YNNgFxYSVDAastLZugjf+J4A== Content-language: ko X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrNIsWRmVeSWpSXmKPExsWyRsSkSDeNZUuYQfsmUYvrX56zWrz+N53F YustaYvLu+awWdxuXMFm0XFYw4HNo+/TLRaPj0+BRN+WVYwenzfJBbBEcdmkpOZklqUW6dsl cGW8b9vIXvCVt+Lfp5ssDYy93F2MnBwSAiYSe/e3MELYYhIX7q1n62Lk4hASWMEoMf/3WVaY ooO/u1ggEksZJXacPsEI4XxglDiyt5cFpIpNwE7iyo0TzCC2iICfxPN199hBbGaBGYwSN376 gNhCAukS50/MAJvKKaAjMfPnM7BeYQFdiTMrzgKt5uBgEVCV+HI5ASTMK2Ap8eNgDxOELSjx Y/I9FoiRBhLvZ/WxQtjaEk/eXYA6VEFix9nXjBAnOEmc33uPEaJGRGLfi3dgN0sIXGOX2Htw IdidLAICEt8mH2IB2SshICux6QAzxBxJiYMrbrBMYJSYhWT1LCSrZyFZPQvJigWMLKsYRVML kguKk9KLDPWKE3OLS/PS9ZLzczcxAuP09L9nvTsYbx+wPsQowMGoxMObsXpzmBBrYllxZe4h RlOgiyYyS4km5wOTQV5JvKGxmZGFqYmpsZG5pZmSOK+i1M9gYBgmlqRmp6YWpBbFF5XmpBYf YmTi4JRqYDy1dP3uSOEdx8Pc1y+c0LLW3PWIqc7nd5G1Qjn3DBcLNP9lZToxPVlA4/R5psO/ OloKfvV/cD+yM43NQdnpzLkJH64cmH33zSVeiXcGn9Q53E9PclG6lvlATzXZ1Mjg0pKL3sUG Fut+LO8xdjj8dyp/TcveEsvW6wfXd03cvLeFrdC2enF7VJQSS3FGoqEWc1FxIgDizGtIzgIA AA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupgleLIzCtJLcpLzFFi42I5/e+xgG4ay5Ywg2mTBSyuf3nOavH633QW i623pC0u75rDZnG7cQWbRcdhDQc2j75Pt1g8Pj4FEn1bVjF6fN4kF8AS1cBok5GamJJapJCa l5yfkpmXbqvkHRzvHG9qZmCoa2hpYa6kkJeYm2qr5OIToOuWmQO0W0mhLDGnFCgUkFhcrKRv h2lCaIibrgVMY4Sub0gQXI+RARpIWMOY8b5tI3vBV96Kf59usjQw9nJ3MXJySAiYSBz83cUC YYtJXLi3nq2LkYtDSGApo8SO0ycYIZwPjBJH9vaCVbEJ2ElcuXGCGcQWEfCTeL7uHjuIzSww g1Hixk8fEFtIIF3i/IkZrCA2p4COxMyfz8B6hQV0Jc6sOAu0gYODRUBV4svlBJAwr4ClxI+D PUwQtqDEj8n3WCBGGki8n9XHCmFrSzx5d4EV4lAFiR1nXzNCnOAkcX7vPUaIGhGJfS/eMU5g FJqFZNQsJKNmIRk1C0nLAkaWVYwSqQXJBcVJ6blGeanlesWJucWleel6yfm5mxjBqeCZ9A7G w7vcDzEKcDAq8fBmrN4cJsSaWFZcmXuIUYKDWUmEd8tdoBBvSmJlVWpRfnxRaU5q8SFGU6Bf JzJLiSbnA9NUXkm8obGJmZGlkbmhhZGxuZI47+P/68KAIZZYkpqdmlqQWgTTx8TBKdXAKFR5 Ri/oDnvBxNv/XXnUVf+e3XHjEacYx6Q3R+pCBFP38QhG6QQt21Pryi/ubn790vFDPY9naxw0 51B+5f7daJvc8s+twiv1/hUvimLdXXZVO8uv4KLa1rPXmp6JHmWpjp/F7ykr4deW0aL57+n3 BacmXUy5JHcwLM938zUTfqPmWcu7xL+qKLEUZyQaajEXFScCAJXjZQQbAwAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Dan 02/05/2016 04:53 AM¿¡ Dan Carpenter wrote: > > On Thu, Feb 04, 2016 at 01:47:41PM +0100, walter harms wrote: > > > > > > Am 04.02.2016 12:36, schrieb Dan Carpenter: > > > The info->status[] array has 3 elements. We are using size > > > MAX77843_MUIC_IRQ_NUM (16) instead of MAX77843_MUIC_STATUS_NUM (3) > > > as intended. > > > > > > Fixes: 135d9f7d135a ('extcon: max77843: Clear IRQ bits state > > > before request IRQ') > > > Signed-off-by: Dan Carpenter > > > --- > > > This is from static analysis and *NOT TESTED*. Please review carefully. > > > > > > diff --git a/drivers/extcon/extcon-max77843.c > > > b/drivers/extcon/extcon-max77843.c > > > index 7bbc300..b188bd6 100644 > > > --- a/drivers/extcon/extcon-max77843.c > > > +++ b/drivers/extcon/extcon-max77843.c > > > @@ -806,7 +806,7 @@ static int max77843_muic_probe(struct platform_device *pdev) > > > /* Clear IRQ bits before request IRQs */ > > > ret = regmap_bulk_read(max77843->regmap_muic, > > > MAX77843_MUIC_REG_INT1, info->status, > > > - MAX77843_MUIC_IRQ_NUM); > > > + MAX77843_MUIC_STATUS_NUM); > > > if (ret) { > > > dev_err(&pdev->dev, "Failed to Clear IRQ bits\n"); > > > goto err_muic_irq; > > > -- > > > > > > just for my curiosity: what is wrong with ARRAY_SIZE() ? > > So far i understand is the functions intention to fill the array > > completely. > > It's done pretty consistently the one way... Jaewon? > > regards, > dan carpenter > You are right. We should read only 3-sequential register. (MAX77843_MUIC_REG_INT1, MAX77843_MUIC_REG_INT2, MAX77843_MUIC_REG_INT3) Reviewed-by: Jaewon Kim Thanks Jaewon Kim