From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD2BC433E0 for ; Tue, 23 Mar 2021 14:28:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DF17A619B1 for ; Tue, 23 Mar 2021 14:28:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232249AbhCWO1s (ORCPT ); Tue, 23 Mar 2021 10:27:48 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49786 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232129AbhCWO1U (ORCPT ); Tue, 23 Mar 2021 10:27:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1616509639; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DIxwh79zPLwHGUGDrqcLjesEnHFkUQgilSVBipYKhCw=; b=HjMB7RcaMRz70Zoi9VgcprWFj3wQUGim2EpIp9BWzQNVKn82LLnpFah+skchSQJsYNUHK7 zgeS7CJd/+KtlV6iYDXBJHE93njHaj1G4T6OsW4XiNMBVtSat70cnf26cD8P2M4MXHlOAP n++0CInIlC2SCEwwkBxRRX9WV9jR0as= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-122-6i6RmrVTMmedm_5mnsaAdQ-1; Tue, 23 Mar 2021 10:27:18 -0400 X-MC-Unique: 6i6RmrVTMmedm_5mnsaAdQ-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DA7D1108BD06; Tue, 23 Mar 2021 14:27:16 +0000 (UTC) Received: from [10.36.115.54] (ovpn-115-54.ams2.redhat.com [10.36.115.54]) by smtp.corp.redhat.com (Postfix) with ESMTP id 03E73196E3; Tue, 23 Mar 2021 14:27:14 +0000 (UTC) Subject: Re: [PATCH v2 1/5] mm/migrate.c: remove unnecessary VM_BUG_ON_PAGE on putback_movable_page() To: Miaohe Lin , akpm@linux-foundation.org Cc: jglisse@redhat.com, shy828301@gmail.com, aquini@redhat.com, apopple@nvidia.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20210323135405.65059-1-linmiaohe@huawei.com> <20210323135405.65059-2-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat GmbH Message-ID: <0017dfc4-05a4-1989-59dc-3f34f7b3517c@redhat.com> Date: Tue, 23 Mar 2021 15:27:13 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0 MIME-Version: 1.0 In-Reply-To: <20210323135405.65059-2-linmiaohe@huawei.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 23.03.21 14:54, Miaohe Lin wrote: > The !PageLocked() check is implicitly done in PageMovable(). Remove this > explicit one. > > Signed-off-by: Miaohe Lin > --- > mm/migrate.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index 47df0df8f21a..facec65c7374 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -145,7 +145,6 @@ void putback_movable_page(struct page *page) > { > struct address_space *mapping; > > - VM_BUG_ON_PAGE(!PageLocked(page), page); > VM_BUG_ON_PAGE(!PageMovable(page), page); > VM_BUG_ON_PAGE(!PageIsolated(page), page); > > Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb