From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753144AbdBPHPx (ORCPT <rfc822;w@1wt.eu>);
        Thu, 16 Feb 2017 02:15:53 -0500
Received: from LGEAMRELO12.lge.com ([156.147.23.52]:55725 "EHLO
        lgeamrelo12.lge.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752105AbdBPHPw (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Thu, 16 Feb 2017 02:15:52 -0500
X-Original-SENDERIP: 156.147.1.121
X-Original-MAILFROM: byungchul.park@lge.com
X-Original-SENDERIP: 10.177.222.185
X-Original-MAILFROM: byungchul.park@lge.com
From: "byungchul.park" <byungchul.park@lge.com>
To: <juri.lelli@gmail.com>
Cc: <peterz@infradead.org>, <mingo@kernel.org>,
        <linux-kernel@vger.kernel.org>, <kernel-team@lge.com>,
        "'Steven Rostedt'" <rostedt@goodmis.org>
References: <1487212457-28839-1-git-send-email-byungchul.park@lge.com>  <1487212457-28839-2-git-send-email-byungchul.park@lge.com> <20170215214537.7936f336@grimm.local.home>
In-Reply-To: <20170215214537.7936f336@grimm.local.home>
Subject: RE: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in push_rt_task()
Date: Thu, 16 Feb 2017 16:15:47 +0900
Message-ID: <001801d28824$7f3f70f0$7dbe52d0$@lge.com>
MIME-Version: 1.0
Content-Type: text/plain;
        charset="us-ascii"
Content-Transfer-Encoding: 7bit
X-Mailer: Microsoft Outlook 14.0
Thread-Index: AQIUwm2wpKt7fy4YbagjTcs/9najwgEJ/tpmAYxKKkyg0g/CAA==
Content-Language: ko
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

> -----Original Message-----
> From: Steven Rostedt [mailto:rostedt@goodmis.org]
> Sent: Thursday, February 16, 2017 11:46 AM
> To: Byungchul Park
> Cc: peterz@infradead.org; mingo@kernel.org; linux-kernel@vger.kernel.org;
> juri.lelli@gmail.com; kernel-team@lge.com
> Subject: Re: [PATCH v3 2/2] sched/rt: Remove unnecessary condition in
> push_rt_task()
> 
> On Thu, 16 Feb 2017 11:34:17 +0900
> Byungchul Park <byungchul.park@lge.com> wrote:
> 
> > pick_next_pushable_task(rq) has BUG_ON(rq_cpu != task_cpu(task)) when
> > it returns a task other than NULL, which means that task_cpu(task) must
> > be rq->cpu. So if task == next_task, then task_cpu(next_task) must be
> > rq->cpu as well. Remove the redundant condition and make code simpler.
> >
> > By this patch, unnecessary one branch and two LOAD operations in 'if'
> > statement can be avoided.
> >
> > Signed-off-by: Byungchul Park <byungchul.park@lge.com>
> > Reviewed-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
> > Reviewed-by: Juri Lelli <juri.lelli@arm.com>
> > ---
> 
> This is a different patch, I don't believe Juri reviewed it yet.

Hello juri,

I should have asked you first and been more careful before I added
'reviewed-by'. Can I ask you for your opinion about the additional one?