From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-00069f02.pphosted.com (mx0a-00069f02.pphosted.com [205.220.165.32]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 83EF73EBF2A for ; Fri, 23 Jan 2026 18:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=205.220.165.32 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769193986; cv=fail; b=PCNtEXgXwiZF3A1UskF9HpNHSPpxwv5fMjpxLuijwiXf5rNsh12iIumlVu3e6Rg9OWTV7dQkYKU39gkV7Ci/bPyaY4AsqX8RU8sqNtABJlwFmAHHoA5Ixuw4Nng/Yw0yDnYaKtcAK5Ge9EJ4/N1wablkT9TNsIryGVIySYv7o18= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769193986; c=relaxed/simple; bh=rKsR6aDHG9xL+ocMY9Bm5C0wtLmIy0n9RvZjXDKsnic=; h=Date:From:To:Cc:Subject:Message-ID:References:Content-Type: Content-Disposition:In-Reply-To:MIME-Version; b=Zlf910Clft6XPx7KDYaHdElJg7nGAFj4txoUkFgDpoN9esJlQgwy7KnL7i9SYrkUgp6dttw32TwgDxtWMCgGGZXxXaQ5H3PLM3DbKoq/HC20R245cYyVQHru61WQWp7YBgRWWDyXhFoFmjEcOrVMDw0Ujp2u/BZBY0be6JYoEb0= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com; spf=pass smtp.mailfrom=oracle.com; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b=CRybV8uL; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b=jymJ+UeF; arc=fail smtp.client-ip=205.220.165.32 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oracle.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oracle.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="CRybV8uL"; dkim=pass (1024-bit key) header.d=oracle.onmicrosoft.com header.i=@oracle.onmicrosoft.com header.b="jymJ+UeF" Received: from pps.filterd (m0333521.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60NEhrZW1884091; Fri, 23 Jan 2026 18:44:54 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=cc :content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s= corp-2025-04-25; bh=as+kX1rMpDUwon2iMLa0bSG+EPVBv8FaAMm4SDmujuU=; b= CRybV8uLFD8m/9FwfHlO8wW7o9BdrUM1mYEDT149WfF17uwMQvSZkFKsgD9Xu/Sm RiFgLseGxCX+rR5iIROTp3+Ib/y8CSxzSOq50So67T10tg9rSv0KMQdbb9bjwc4E nL6lbmTAjSoC8DNnhVD6OcR1bclXuDPhiBAZ12eOEuqZsGQKK33A1FlQf+hnBNIN 3t3SGC1z+MVlleC5GvJGx4mJeVb0QDIHH1l2yzwsVGi8bI0J0T/bLTNdxWgjcQBc E0p7iotwyC8H8svZsYk8t+K435csXvHLM/ZMleI8x1VlASJy0YtqssRsZ9rctkle FY38U2LQnnSg23zG/C0tdg== Received: from phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (phxpaimrmta01.appoci.oracle.com [138.1.114.2]) by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 4br1b8jwyv-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Jan 2026 18:44:54 +0000 (GMT) Received: from pps.filterd (phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (8.18.1.2/8.18.1.2) with ESMTP id 60NHCgXX035795; Fri, 23 Jan 2026 18:44:53 GMT Received: from mw6pr02cu001.outbound.protection.outlook.com (mail-westus2azon11012053.outbound.protection.outlook.com [52.101.48.53]) by phxpaimrmta01.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id 4bux4yk4wr-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Fri, 23 Jan 2026 18:44:53 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j6NzYamw0TvtEmEnuhpRBFadXEOdXE4/aaKZBASUh17ViXp+VxYm1JFl0rZxDyHqwM9hrjQqfgx4/XprZtnGbx5j+tBepEvi3dTiudfFGa814N+qmKE2WWemsaVHB8EyloaxFIMFx6HfL+Yzu5W0dbkXkXyeJ/7B92/MHbDP7jKf/tOSyXtshxXZo1cIGMiZJ0rsNAoKKqCAss3vTbc7APr/2trjPvxkWSBCKNPR8NSZI1po3+89CisCjuTFn4vAQRFJW+/sdG6psWRqlH4WzE+LXri1TZTSnuI6/Js1yhoj6V0nYujLnYsyK3RXj5XaJxHEIk/Z8xp9UHos6Vbj1Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=as+kX1rMpDUwon2iMLa0bSG+EPVBv8FaAMm4SDmujuU=; b=kmF8/liQJ+Qxvf+r+IqhJgupIYezeln3Xorvlu6AwYQSz1lsciCUvnkK/HzME6KBsTrKhqaqy/sgUE0q4MXkpjqbBhbw74se3Fr2FeeDeeznzpSpekl8xcBiyXY9blPkU11LCSFaEjuPXD4q/yUrZk6N52X914oTrLYkLoJb5l+AhrDSARYHam03kXVnP22U1RIo+W6Rb0+sFWd0Bld4kcC7fh5aOJeasjrQAgjbVxtxQytgj1s8YWEz5PVJMSsHJqDrm/1Tnn5JHaRbg4h+kIDrfkF5zVLgbIA/hcuibUyxDJJtW321TTssfT98MyLVfPxsuPTzd311puikOJ6SAg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=as+kX1rMpDUwon2iMLa0bSG+EPVBv8FaAMm4SDmujuU=; b=jymJ+UeFaGQsew3aeGNzCI+qqUkCLpqbEBazjBqLFDrsoLunM5XafCuoZkTnJzO7TRiO7ZtAC7Kb46LvaU3+r8PaLPDERjWFgz1d5waRxFerctcL0A+aYkjZ6FUECYwu7W8+/cF4T2OPrzINL0LM1Dlp0XVf2kZqIQbBMDFjBRE= Received: from BL4PR10MB8229.namprd10.prod.outlook.com (2603:10b6:208:4e6::14) by PH7PR10MB6130.namprd10.prod.outlook.com (2603:10b6:510:1f6::9) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9542.11; Fri, 23 Jan 2026 18:44:47 +0000 Received: from BL4PR10MB8229.namprd10.prod.outlook.com ([fe80::552b:16d2:af:c582]) by BL4PR10MB8229.namprd10.prod.outlook.com ([fe80::552b:16d2:af:c582%6]) with mapi id 15.20.9520.005; Fri, 23 Jan 2026 18:44:47 +0000 Date: Fri, 23 Jan 2026 18:44:51 +0000 From: Lorenzo Stoakes To: Vlastimil Babka Cc: Suren Baghdasaryan , Andrew Morton , David Hildenbrand , "Liam R . Howlett" , Mike Rapoport , Michal Hocko , Shakeel Butt , Jann Horn , linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-rt-devel@lists.linux.dev, Peter Zijlstra , Ingo Molnar , Will Deacon , Boqun Feng , Waiman Long , Sebastian Andrzej Siewior , Clark Williams , Steven Rostedt Subject: Re: [PATCH RESEND v3 08/10] mm/vma: improve and document __is_vma_write_locked() Message-ID: <0019bd45-be27-43b5-bf80-1f8836c2ea91@lucifer.local> References: <70dcf80f79ecd00a750ea17101061b0949119429.1769086312.git.lorenzo.stoakes@oracle.com> Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-ClientProxiedBy: LO4P123CA0410.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:189::19) To BL4PR10MB8229.namprd10.prod.outlook.com (2603:10b6:208:4e6::14) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: BL4PR10MB8229:EE_|PH7PR10MB6130:EE_ X-MS-Office365-Filtering-Correlation-Id: 1d4b4883-c261-4c6c-701a-08de5aaf7bd7 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|376014|7416014|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?aFZ1TVN2RXlSL3ZRZStzaEZteWNxc250T3lyMGlBeHdrL2JTU2ovQTJBUmIx?= =?utf-8?B?c3QxL2VhWEFwVmR6emtwZ29vbHRRWDNBYkhMNW83K3ZsNEhIclNyaFFTeEly?= =?utf-8?B?L1VIbXcyU2FaK1o4SXBjTHo1WFh0OHBjOGVUY2s2OGoxeXFkSFRkb0tHL0Nl?= =?utf-8?B?YXpNSHRUVExEcEpqMkIrMlIyTHJnYjZNZjVjdFJvTnNTWXluWTR4bnVuM3Y1?= =?utf-8?B?dHJXOVc3d3lpSzAwc0dmMDgrQVNkZTZTRnlMbFhIVEw4V1pYNnVGbjlQa3JL?= =?utf-8?B?MjZSWWdtOWdLL1Z4WU1wK3NqVjBHL2Z0MSszYjA1Wkd3a3lkSGJWbWI0VkJm?= =?utf-8?B?YTJkUFpYVkVCQ1B0TkRHZW1kNExXYmFnYXZxdUdKcUwrU1lqd2JTUlNwUlB5?= =?utf-8?B?cGpWcDAzR3lvMWFpSGFNMituNEFpenJSRC9OM1U0aWRRTU45OHA2TVFKTXky?= =?utf-8?B?N0IvZitER3lyVXBEVXpCOEpNVkdISWgxc2hXdkRzK1Y3NGNBVmZhd1F5NVFX?= =?utf-8?B?WEw2T0ppTmtDelpsVXJtN1AwRzRGOTBFUitRNkZhSy9BMUlXakJuUXhULzhi?= =?utf-8?B?VTVRUjU4Z21VbnlaNm11VUQ1K0J1aDZ1WGtSVm9ySHZjeXZVYlBuQWZiSU5r?= =?utf-8?B?SlBPcFNXbVdmM0FYTzZSVWc1d0kzOG5pSURUNm1sWDN4VlJPOUE0UTArVysv?= =?utf-8?B?dngzcDlMK2xRcHRvb3dOVkVBQU11T1VSeEErUWJaZWhtKzRyanUrdlZlZzRR?= =?utf-8?B?UzJlNXQ4eE5oN3lhWDVmNUM4OVdPbWtyOFppUFBIRlpwT0xNQlF6dXJSR284?= =?utf-8?B?S3J6bGVxR1FaQjQwb0FKNXIydFRROUQ0cWY5UjZLazB2WTdUM0lHVW5BdG5w?= =?utf-8?B?aUNyNWVJQ09lcTlHbzY2SURkakV1bXhubEVsYW1UZUp1T2tCdHJ3USthS3RF?= =?utf-8?B?bFN4NnVPS2hmdDgwMFNyaEdFczRBanV2WjdNVGZ4NmFGQ1ZlWVFkTkUrakZz?= =?utf-8?B?ZXhSOXkxSE95d0N5RG14cnZMcGZPRk81eDZWdkhhZ0JWTW1NMnlNSE80WjVx?= =?utf-8?B?NTF1eUZvN2lDbEVHSWdNVzJzc25pbXRIYkhDdnd4K2FSY0ZoZjJVQ1dJUExr?= =?utf-8?B?dUVSYUIzM1lNN0twSE9rMWVXTzlmWVhOY2t2OVRHdUwrWWFMRWpqMXl3dm1l?= =?utf-8?B?RDdoeEorQzVkc1BxL0IxNkNIL1BYenpVd0x5THlRU1Y3UWdtZVBrdGRuUW9H?= =?utf-8?B?OEw5VS80L2REY0pnUjhsS2pSVHBqTlZ0OVhtSFpGWGc5R2dJbDR4SHhNNjRZ?= =?utf-8?B?Z1NGcjlWRUhEUlhhck0xdTUzUGJxeTMwTlc3Q1pSZnhWOU1uYWx5ODNIVEk0?= =?utf-8?B?blV2VXpLamtBUTRQMzdYT05XekFLWEt5M3phaFl3emNXVUZLYzVUN2g1c29O?= =?utf-8?B?MVBFK1dWc2wzZHNBYWJvQUpqYXYveDJmS2FPMDBRUUFtdU01RWlmMWNlNTQv?= =?utf-8?B?S3RPR0NVUHF2ZFVtbmVQV1FLa3VXS3luZ0FiQ3dnYXJYRjlaakdjZWFycEo1?= =?utf-8?B?Q3htMFozbG1CUVlsbVpOUm1KWE04TzJxMFNyVjRLSmRJS3lpdXRiaEpacnRC?= =?utf-8?B?RTYxbmJzODVleU1WK2h5Q2JIL3dYbFF0YjJkZmdiaWRCcHVKalFLMk0rOU1s?= =?utf-8?B?SE9FbHZFQlFqU0tSWXliNjB1L1ltd1hYQlh2cnVaQzhHaXlxTVQva0dDZWNZ?= =?utf-8?B?enJIUFprc1czQzN6SWd6QUJNZ3FheU1FZHk2SG9hRzVWWGVUTFZBTUFyNGVB?= =?utf-8?B?TTR5VUxBT0NSS1pUR2JuaDVVTFVMU3NCM1dWMnJNaU9zN2NSQzFGSEo3NWRY?= =?utf-8?B?NEY3V1BYbUx3SDBaeTZzZ2U0M0RiS3FKTE8xN3hpV1NhM0pCS0p6alBBcVRZ?= =?utf-8?B?MFhPeW94L1ZWMkhFUWI4dVl5ZnB0NWV1a3Rqb290SVJuRU11d3AzS3ZNMGF2?= =?utf-8?B?S0ZZOFR1S1ZBWHNlWXZmVFQyMGhHTncwbkNtMHpHSmFlbVd4Q0pYL0FWeHo4?= =?utf-8?B?bDhqR2czd1djQmxnKzN2WmR6NUU3VXRZYVlITG5nZFcwaHhyMUpqaW1tcldz?= =?utf-8?Q?4b00=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BL4PR10MB8229.namprd10.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(376014)(7416014)(366016);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TGtwYVFRUDg3WnhNNmwvemJ5cW1kVkt6V2d1M2Y1cUVwTGIvQ2dERHN2anBE?= =?utf-8?B?dDEzd240NDFSZ2huREp3cktxait5cllNcFNpeEQ0L2FNUTh5QjhDWmQyQ3R1?= =?utf-8?B?dCt2TjVGNC9ZSVVtQnhMdUp5T2RzK0s0UnorRXFSbEhFbUVnRHVjL2NPRUJW?= =?utf-8?B?RUFyNUdhL0U4RERoYk42NC8yZENLa1lhZGhoUVVVQWg3djArRkwwcDFLcnRX?= =?utf-8?B?Q00xNTFyc3NkMitBMUh1ZzJQLytTZjVvaFBQQkdiOC9DbERCWU05aEg1Y3NV?= =?utf-8?B?WlpxMWFBSEFFVFhialNtNktUcnRDZ2RTTnpOL3l3MXlVTGVRQXBIN0hQM2tW?= =?utf-8?B?cCthOFY3YW0wRzB1cC9NWmZoVWE2T25mOW9GTkZDZ0R1TlFwSTJKV2p2ZS9i?= =?utf-8?B?ellvUXdreTJuQ3k1d1h0bUd3Q3Nia2dNK09obVhlMEhJN2VONis1Q25MR0xU?= =?utf-8?B?SEhJMG03YnIrdDdIa215ZEsrd1pHY3orcE5nSDVpbElpSmUyVTV0VFFGL05F?= =?utf-8?B?L1lJSHh4ODBnY3RKT1lMRllaTlBmcG1WOWNiSWNPZ1RnRGY3UklNTGQwYkVv?= =?utf-8?B?NUNiempCOEQ1NU9JUVFJbUxNbVp5N2NPVHNJSWZuSFRBSW9nang2cXJOclBC?= =?utf-8?B?YnNmVzl0QXl2bWRXSmVGNGVoejB0bXpDK3NzR3pvbW91elVtdEpZYzQ4Q0E4?= =?utf-8?B?aHZUUXdZK29SdUhXbmt4V3c0Sk5WNWJzTmdXdENMVjVXcTd5VE85K0ladXE2?= =?utf-8?B?NThGK1ZsMDZuclREeU9qa3ViaURXWExjOWdPb2J4alZ5TG5VNE85T2lSVlk2?= =?utf-8?B?RzBpbnRuWnNJTGQxbXF4M3VpSENIbFpGUW9ZeDZSZEhsTVVqQnI5K2pnWGNu?= =?utf-8?B?eUQ1UWo5N0YxclR4Z2xHdVI0TGhHeE94TE1nNEdabXJCbWJHaDJ1Z2cvajZW?= =?utf-8?B?Q045bDlCNS9JVU11MmkzVlI2MUZXQlkzbXVYZmx2MGwrSkJMQ01NUm9WWkQ3?= =?utf-8?B?LzUrWTUvOWkrMkFqVXR4ZWJKWnJsOWhOUDRFQ3U3anpJa2RlVzNXK0Zrc2E5?= =?utf-8?B?VFhsU1VhVlJ5Rk5TSXFKZExVUGFmWlB6cDVkbGpYUmZxT2ZVWnpvZnMzbTZP?= =?utf-8?B?b0RzNTFyaTFTVmVvaUE2b2Y2eklHZXd2UndqLy9JbzhpYS9PMTZCb3lYK0s5?= =?utf-8?B?NHd6Nnl1S085NXJoSFNUVzhqMzdhTzA1M2ptQUFUSzlNMG9pNWp3Qngzcm9K?= =?utf-8?B?WHNwaG03a0hSK3FzY0c3UDlLOXpweUZ0dHJVNGhkVFZKTlhkamNSYkRYYjBu?= =?utf-8?B?d2ZWeVI3aHh0Q21GWDEreVZ6dGtqNEtuSWhDa1piT2NOYTl4N09GNFFOcDVw?= =?utf-8?B?S0R2U3VZTDNjTWdnQzhsb1ZvK0lQR2VFbzRQMldwbDU4UExIUi9QRnJvOVZj?= =?utf-8?B?WFB3MENtVkZFelFkL3ZRVTlxcE1MRzZEeCtTZXZacXVqd1Y5bUplS0dQb091?= =?utf-8?B?TGdScTd3MERJTit5V1FYZ01FN3M2a3Juc2JGQmljd3FZaUpKYkFCdTdXc2tz?= =?utf-8?B?a3NGTjB1OWxmOUxxQWM5V0VpZWQ5TlJ4M3ZxK3lCRDA3L202czZLZmJYaDZv?= =?utf-8?B?bWJ2WFI3bHBqODVxb213eWsrT1huOWhVVUw4dmRnVGxKZmJOb0FFWHY2Nzhp?= =?utf-8?B?TkhuT21OL1M1c1dOdWZ5dnR4NUZoUFh3UWI1RE14U01iRjJoUlY2V254OGNx?= =?utf-8?B?M3l0Q1NXZHJ4U0lNMlRvMm1DMmJsNnl6MUZDRW9kekhKNXNrcmhlMkNYNEpQ?= =?utf-8?B?aUFEa2xEM2hvRmx1dTZaakwvdWVoYVhlRW9qMy9wak53UlJseWZRZCswdmtr?= =?utf-8?B?MjZFREFHYjc1SVp3Ym53WmhkNi9qNWVVc3dXTy81MWI3MFdub3VMQTJ0ZHpv?= =?utf-8?B?RnlNQWd2U3c2WGpYMzlTbGxsdWZVT3RtcXl5SG5scDVjaFRyTXM5cmZCZ05i?= =?utf-8?B?R3RhUFB0YkM1RDNrS1lPcTRkZ3dBTjJlWlZKNFRwQXdLWXBhTjFkYi9WNG84?= =?utf-8?B?VUdZWk1zU2x2MTlsdmR2ZjJEbk1NRCtzTzVqbStob1owUHduWGRHVFU2SFdH?= =?utf-8?B?U3l4K1dtUUh0WlZNZXhKTlZlNmVYUSt4WjN0VnQxWTJvQXZ2ejBSdjAxMGh4?= =?utf-8?B?MzJ0bWVKL0FhSG42MmwrZWF3WVhjSDlvMlpYRE1BRXBsNjJ5eFJFVGFYdFZm?= =?utf-8?B?N2xpSS9rOXMxQ1BlT1N2RVY2YnVlekRNeTludThLczBXcEQreERaZWJsd05j?= =?utf-8?B?NW9vTkhoeC9EZmNSVDBkYmhlR215RHQ0U2o2OFNMeW84V3BDSGtxdjJMenVw?= =?utf-8?Q?nP4QLvZSu7IubnB4=3D?= X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: iUyK08ZJ2rutKwq1zij4A1EOv1c1BHU7wkAW2f34R8DtresvaM0sl+gxKfAmZEZNOFn0bFGHBsD65dk5p/7r2SDOTYXM5Tgryi8aTSvd9Qwyt1ngDkzEmQGj7QGmAgmq1rapY9bN42PiS+glD7ZuAAe7dMT0XtHNm0HXzhhnCk/14HTBWuk+EpN2Y0Amu7HNFcSEpUkYIt7+IisPDT2RsM3Oj2oyhGfJNh1GYOklLBPfboPhB9Jb1wrotgBvFvNwp3YmFYnR1spQuWwnaiP4ABMX4yzTrs9VyaZoZr6VMH/ikBKeIs8e7PtG/y3fAIMs86do88VGQaBcjTO7Id1slkb9iQ0iqViNc5lCyMIqgZHyhpag92t6WQrZsm9k+/UDaArUrDOQBmcd543I+tSR31yp8el+SVOAgVyjiEMYCgBUBX3AfIxQetOd03qOY6RF/MALwfdJ7RuWw9exi5repoFVr/OMJ6n5LDxNPBcIo3QGarzL++Y5OHVKD3Usg09fxoFroMdIVSyk4aG+mFUvkf1OaaByMu/3mlmS2f7qMkrGm89f9K/gd6MNLOcxiwYLxkDTPFUQhBqC8bdXJBvvAzBKsslk/Qr4q9cpDWLX2lI= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1d4b4883-c261-4c6c-701a-08de5aaf7bd7 X-MS-Exchange-CrossTenant-AuthSource: BL4PR10MB8229.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Jan 2026 18:44:47.7672 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0VI4m2rOa5yCFHGCkfNFWaHN6BCYSHd6itqARTlK7UpXIpct137cgDTja6BpOU8/ju+uXlZbnLg2O4kkxGKm/az1p/ymBv3YnVmnmriLmAU= X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6130 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.20,FMLib:17.12.100.49 definitions=2026-01-23_03,2026-01-22_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=0 spamscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2601150000 definitions=main-2601230142 X-Authority-Analysis: v=2.4 cv=WbcBqkhX c=1 sm=1 tr=0 ts=6973c1a6 cx=c_pps a=XiAAW1AwiKB2Y8Wsi+sD2Q==:117 a=XiAAW1AwiKB2Y8Wsi+sD2Q==:17 a=6eWqkTHjU83fiwn7nKZWdM+Sl24=:19 a=z/mQ4Ysz8XfWz/Q5cLBRGdckG28=:19 a=lCpzRmAYbLLaTzLvsPZ7Mbvzbb8=:19 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=GoEa3M9JfhUA:10 a=VkNPw1HP01LnGYTKEx00:22 a=yPCof4ZbAAAA:8 a=CLkusZBIhmaYX332FuIA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTIzMDE0MiBTYWx0ZWRfX9LJLN5+4vUP5 a2FE0viqvvRSFHCoP5H5cCQeYkwmT1S+mwzdSCMlkz+cyTmxg6JNAnZUn7eFXEC3RAJrMIbFVu7 TiLqZYMR+EDzeOsl2L5JppKGrU+hIJEkQCEfaFmbdwdmD+YFgisn/KOMo1CY0AMzNDdAlH7EGif 56SPHJnRuTP28D/HnYL1t2ykeYLRz8p6OIfE/3jznyRYzI2sfvL4rmDjqJNd3fdsGCezmJ/lZPG BFkgT4tsze991ahT1DVjXgDZdOzMasTMAxsl3ZApdxjt7kAstkgZC1Oot/y6uaGmX73YbOTlVBm dzgjUiaJvMoyFOpMwzpVf+jOBc71WaA1UF41GF4aj/Ftl2IzOoBzsoKFbn+8PJxmWRviZhlWGnj YI+xV+lEjpE860m+A2/6PqtAOHaTEj/olU0UUSNXtYxSVUlMcWQMLQy+/w2GvdtS2ATU/pbWqmT NjgI2ljVu0cZxS+86cw== X-Proofpoint-ORIG-GUID: gFOcNnd_wqmAhZB8YzEE1BcSXCBcqgda X-Proofpoint-GUID: gFOcNnd_wqmAhZB8YzEE1BcSXCBcqgda On Fri, Jan 23, 2026 at 05:21:26PM +0100, Vlastimil Babka wrote: > On 1/22/26 22:55, Suren Baghdasaryan wrote: > > On Thu, Jan 22, 2026 at 5:02 AM Lorenzo Stoakes > > wrote: > >> > >> The function is a little confusing, clean it up a little then add a > >> descriptive comment. > > > > I appreciate the descriptive comment but what exactly was confusing in > > this function? > > > >> > >> No functional change intended. > >> > >> Signed-off-by: Lorenzo Stoakes > >> --- > >> include/linux/mmap_lock.h | 23 ++++++++++++++++++----- > >> 1 file changed, 18 insertions(+), 5 deletions(-) > >> > >> diff --git a/include/linux/mmap_lock.h b/include/linux/mmap_lock.h > >> index 873bc5f3c97c..b00d34b5ad10 100644 > >> --- a/include/linux/mmap_lock.h > >> +++ b/include/linux/mmap_lock.h > >> @@ -252,17 +252,30 @@ static inline void vma_end_read(struct vm_area_struct *vma) > >> vma_refcount_put(vma); > >> } > >> > >> -/* WARNING! Can only be used if mmap_lock is expected to be write-locked */ > >> -static inline bool __is_vma_write_locked(struct vm_area_struct *vma, unsigned int *mm_lock_seq) > >> +/* > >> + * Determine whether a VMA is write-locked. Must be invoked ONLY if the mmap > >> + * write lock is held. > >> + * > >> + * Returns true if write-locked, otherwise false. > >> + * > >> + * Note that mm_lock_seq is updated only if the VMA is NOT write-locked. > > Could it also say to what it's updated to? Or is it too obvious? > > > > > True, this does not result in a functional change because we do not > > use mm_lock_seq if __is_vma_write_locked() succeeds. However this > > seems to add additional gotcha that you need to remember. Any reason > > why? > > Actually I wonder if it's really worth returning the mm_lock_seq and passing > it to __vma_start_write(), which could just determine it on its own. It > would simplify things. I mean don't we have to worry about racing vma_end_write_all()'s? I suppose not as you have to have the mmap write lock here exclusively, and we (lockdep) assert we own it, so we can probably safely assume the mm value is OK. It'd be good to drop this parameter. I see Suren approves so have done so... :) > > >> + */ > >> +static inline bool __is_vma_write_locked(struct vm_area_struct *vma, > >> + unsigned int *mm_lock_seq) > >> { > >> - mmap_assert_write_locked(vma->vm_mm); > >> + struct mm_struct *mm = vma->vm_mm; > >> + const unsigned int seq = mm->mm_lock_seq.sequence; > >> + > >> + mmap_assert_write_locked(mm); > >> > >> /* > >> * current task is holding mmap_write_lock, both vma->vm_lock_seq and > >> * mm->mm_lock_seq can't be concurrently modified. > >> */ > >> - *mm_lock_seq = vma->vm_mm->mm_lock_seq.sequence; > >> - return (vma->vm_lock_seq == *mm_lock_seq); > >> + if (vma->vm_lock_seq == seq) > >> + return true; > >> + *mm_lock_seq = seq; > >> + return false; > >> } > >> > >> int __vma_start_write(struct vm_area_struct *vma, unsigned int mm_lock_seq, > >> -- > >> 2.52.0 >