From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750907Ab1IUNrO (ORCPT ); Wed, 21 Sep 2011 09:47:14 -0400 Received: from mailout2.w1.samsung.com ([210.118.77.12]:31276 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750711Ab1IUNrN (ORCPT ); Wed, 21 Sep 2011 09:47:13 -0400 Date: Wed, 21 Sep 2011 15:47:05 +0200 From: Marek Szyprowski Subject: RE: [PATCH 7/8] ARM: integrate CMA with DMA-mapping subsystem In-reply-to: To: "'Mike Frysinger'" Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-mm@kvack.org, linaro-mm-sig@lists.linaro.org, "'Michal Nazarewicz'" , "'Kyungmin Park'" , "'Russell King'" , "'Andrew Morton'" , "'KAMEZAWA Hiroyuki'" , "'Ankita Garg'" , "'Daniel Walker'" , "'Mel Gorman'" , "'Arnd Bergmann'" , "'Jesse Barker'" , "'Jonathan Corbet'" , "'Shariq Hasnain'" , "'Chunsang Jeong'" Message-id: <001a01cc7864$f2c98ea0$d85cabe0$%szyprowski@samsung.com> Organization: SPRC MIME-version: 1.0 X-Mailer: Microsoft Office Outlook 12.0 Content-type: text/plain; charset=utf-8 Content-language: pl Content-transfer-encoding: 7BIT Thread-index: AcxuTKFS5tdpLRmXSXyFjNDs9zySPQKFwqFQ References: <1313764064-9747-1-git-send-email-m.szyprowski@samsung.com> <1313764064-9747-8-git-send-email-m.szyprowski@samsung.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, On Thursday, September 08, 2011 7:27 PM Mike Frysinger wrote: > On Fri, Aug 19, 2011 at 10:27, Marek Szyprowski wrote: > > arch/arm/include/asm/device.h | 3 + > > arch/arm/include/asm/dma-contiguous.h | 33 +++ > > seems like these would be good asm-generic/ additions rather than arm Only some of them can be really moved to asm-generic imho. The following lines are definitely architecture specific: void dma_contiguous_early_fixup(phys_addr_t base, unsigned long size); Some other archs might define empty fixup function. Right now only ARM architecture is the real client of the CMA. IMHO if any other arch stats using CMA, some of the CMA definitions can be then moved to asm-generic. Right now I wanted to keep it as simple as possible. Best regards -- Marek Szyprowski Samsung Poland R&D Center