From: Seungwon Jeon <tgih.jun@samsung.com>
To: merez@codeaurora.org
Cc: linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org,
"'Chris Ball'" <cjb@laptop.org>,
"'Subhash Jadavani'" <subhashj@codeaurora.org>,
"'S, Venkatraman'" <svenkatr@ti.com>
Subject: RE: [PATCH v7 1/3] mmc: core: Add packed command feature of eMMC4.5
Date: Tue, 12 Jun 2012 12:12:49 +0900 [thread overview]
Message-ID: <001a01cd4849$3f287180$bd795480$%jun@samsung.com> (raw)
In-Reply-To: <68ac9afd251593ab3df348a469a10adb.squirrel@www.codeaurora.org>
Maya Erez <merez@codeaurora.org> wrote:
> > + if ((host->caps2 & MMC_CAP2_PACKED_CMD) &&
> > + ((card->ext_csd.max_packed_writes > 0) ||
> > + (card->ext_csd.max_packed_reads > 0))) {
> > + err = mmc_switch(card, EXT_CSD_CMD_SET_NORMAL,
> > + EXT_CSD_EXP_EVENTS_CTRL,
> > + EXT_CSD_PACKED_EVENT_EN,
> > + card->ext_csd.generic_cmd6_time);
> > + if (err && err != -EBADMSG)
> > + goto free_card;
>
> Subhash suggestion to change to the following is missing:
> if ( (host->caps2 & MMC_CAP2_PACKED_WR &&
> card->ext_csd.max_packed_writes > 0) ||
> (host->caps2 & MMC_CAP2_PACKED_RD &&
> card->ext_csd.max_packed_reads > 0)
Thanks to detect.
It'll be applied.
Best regards,
Seungwon Jeon
>
> Thanks,
> Maya Erez
> Consultant for Qualcomm Innovation Center, Inc.
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2012-06-12 3:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 8:23 Seungwon Jeon
2012-06-11 20:26 ` merez
2012-06-12 3:12 ` Seungwon Jeon [this message]
2012-06-12 4:21 ` S, Venkatraman
2012-06-12 13:05 ` Seungwon Jeon
2012-06-12 19:15 ` merez
2012-06-13 19:49 ` S, Venkatraman
2012-06-13 21:43 ` merez
2012-06-14 3:10 ` Seungwon Jeon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001a01cd4849$3f287180$bd795480$%jun@samsung.com' \
--to=tgih.jun@samsung.com \
--cc=cjb@laptop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=merez@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=svenkatr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome