mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Andrew Morton'" <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org,
	"'Alessandro Zummo'" <a.zummo@towertech.it>,
	rtc-linux@googlegroups.com, "'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH 09/11] rtc: rtc-sun4v: use pr_warn() instead of printk()
Date: Fri, 15 Feb 2013 15:02:46 +0900	[thread overview]
Message-ID: <001a01ce0b42$138e19f0$3aaa4dd0$%han@samsung.com> (raw)
In-Reply-To: <001201ce0b41$4900c4d0$db024e70$%han@samsung.com>

Fixed the checkpatch warning as below:

  WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(...  to printk(KERN_ERR ...

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
---
 drivers/rtc/rtc-sun4v.c |   10 ++++++----
 1 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/drivers/rtc/rtc-sun4v.c b/drivers/rtc/rtc-sun4v.c
index 5b22610..59b5c2d 100644
--- a/drivers/rtc/rtc-sun4v.c
+++ b/drivers/rtc/rtc-sun4v.c
@@ -3,6 +3,8 @@
  * Copyright (C) 2008 David S. Miller <davem@davemloft.net>
  */
 
+#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
+
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/delay.h>
@@ -26,10 +28,10 @@ retry:
 			udelay(100);
 			goto retry;
 		}
-		printk(KERN_WARNING "SUN4V: tod_get() timed out.\n");
+		pr_warn("tod_get() timed out.\n");
 		return 0;
 	}
-	printk(KERN_WARNING "SUN4V: tod_get() not supported.\n");
+	pr_warn("tod_get() not supported.\n");
 	return 0;
 }
 
@@ -53,10 +55,10 @@ retry:
 			udelay(100);
 			goto retry;
 		}
-		printk(KERN_WARNING "SUN4V: tod_set() timed out.\n");
+		pr_warn("tod_set() timed out.\n");
 		return -EAGAIN;
 	}
-	printk(KERN_WARNING "SUN4V: tod_set() not supported.\n");
+	pr_warn("tod_set() not supported.\n");
 	return -EOPNOTSUPP;
 }
 
-- 
1.7.2.5



  parent reply	other threads:[~2013-02-15  6:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-02-15  5:57 [PATCH 01/11] rtc: use pr_err()/pr_warn() " Jingoo Han
2013-02-15  5:58 ` [PATCH 02/11] rtc: max77686: use dev_info() " Jingoo Han
2013-02-15  5:58 ` [PATCH 03/11] rtc: rtc-efi: use pr_err()/pr_warn() " Jingoo Han
2013-02-15  6:04   ` Venu Byravarasu
2013-02-15  5:59 ` [PATCH 04/11] rtc: rtc-ds2404: use dev_err() " Jingoo Han
2013-02-15  6:00 ` [PATCH 05/11] rtc: rtc-rs5c372: use dev_dbg()/dev_warn() instead of printk()/pr_debug() Jingoo Han
2013-02-15  6:00 ` [PATCH 06/11] rtc: rtc-at91rm9200: use dev_dbg()/dev_err() " Jingoo Han
2013-02-15  6:01 ` [PATCH 07/11] rtc: rtc-rs5c313: use pr_err() instead of printk() Jingoo Han
2013-02-15  6:02 ` [PATCH 08/11] rtc: rtc-vr41xx: use dev_info() " Jingoo Han
2013-02-15  6:02 ` Jingoo Han [this message]
2013-02-15  6:03 ` [PATCH 10/11] rtc: rtc-pcf8583: use dev_warn() " Jingoo Han
2013-02-15  6:04 ` [PATCH 11/11] rtc: rtc-cmos: use dev_warn()/dev_dbg() instead of printk()/pr_debug() Jingoo Han

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='001a01ce0b42$138e19f0$3aaa4dd0$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=a.zummo@towertech.it \
    --cc=akpm@linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rtc-linux@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®