Re: [PATCH 1/4] clocksource: em_sti: remove unnecessary OOM messages

[Jingoo Han <jg1.han@samsung.com>]

On Monday, May 19, 2014 7:48 PM, Daniel Lezcano wrote:
> On 04/29/2014 10:26 AM, Jingoo Han wrote:
> > The site-specific OOM messages are unnecessary, because they
> > duplicate the MM subsystem generic OOM message.
> 
> Are you sure the MM subsys display a message when an allocation fails ?
> 
> There are multiple reasons an allocation can fail.

(+cc Viresh Kumar, Laurent Pinchart, Dan Carpenter, Joe Perches,
       Thierry Reding, Andrew Morton)

There was a discussion about this in other threads. [1]
Please refer to the following link. Thank you.

[1] http://patchwork.ozlabs.org/patch/324158/

Best regards,
Jingoo Han

> 
> > Signed-off-by: Jingoo Han <jg1.han@samsung.com>
> > ---
> >   drivers/clocksource/em_sti.c |    4 +---
> >   1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/drivers/clocksource/em_sti.c b/drivers/clocksource/em_sti.c
> > index 9d17083..d0a7bd6 100644
> > --- a/drivers/clocksource/em_sti.c
> > +++ b/drivers/clocksource/em_sti.c
> > @@ -318,10 +318,8 @@ static int em_sti_probe(struct platform_device *pdev)
> >   	int irq;
> >
> >   	p = devm_kzalloc(&pdev->dev, sizeof(*p), GFP_KERNEL);
> > -	if (p == NULL) {
> > -		dev_err(&pdev->dev, "failed to allocate driver data\n");
> > +	if (p == NULL)
> >   		return -ENOMEM;
> > -	}
> >
> >   	p->pdev = pdev;
> >   	platform_set_drvdata(pdev, p);
> >