From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751650AbcFUKC3 (ORCPT ); Tue, 21 Jun 2016 06:02:29 -0400 Received: from SMTPBG252.QQ.COM ([183.60.52.105]:55990 "EHLO smtpbg252.qq.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751400AbcFUKCK convert rfc822-to-8bit (ORCPT ); Tue, 21 Jun 2016 06:02:10 -0400 X-QQ-mid: bizesmtp11t1466503057t918t28 X-QQ-SSF: 00100000002000F0F820000A0000000 X-QQ-FEAT: 0qwwCl8ZsE1MEMr/5P6t5LdpSSuRSc7xqeYjMs6roKRBm8aEQ3wo9GY2wfhYG WId7ENR8KGhpNpP6RcoTgOL11HgXnoE/BsMve1jl6hgTJW4RNiPkGJN1ftxpErzNZuBv36M xoNrtkCuKB5sZcpKECUPJFIb0mVF3nmmAcEPlaE7hD8gTI411i9bJaUr5y6rF6aRcE1/38M WqnDu/HZJkTokS9UHO0ddbYWsj//0LxurNtZQQtDiNp5q9jaoqzT93cECVkm2nCcAJxjIXP zodBtj8Gw+x5MXvcP9l1brnG8= X-QQ-GoodBg: 0 From: =?UTF-8?B?6auY5bOw?= To: "'Takashi Iwai'" Cc: , , , References: <1466498065-29692-1-git-send-email-fgao@ikuai8.com> <000901d1cb99$b0f36130$12da2390$@ikuai8.com> <001101d1cba0$481bc380$d8534a80$@ikuai8.com> In-Reply-To: Subject: =?UTF-8?Q?=E7=AD=94=E5=A4=8D:_=E7=AD=94=E5=A4=8D:_=E7=AD=94=E5=A4=8D:_?= =?UTF-8?Q?=5BPATCH_1/1=5D_sound:_Fix_compile_e?= =?UTF-8?Q?rror_of_seq=5Fdevice.c?= Date: Tue, 21 Jun 2016 17:57:28 +0800 Message-ID: <001c01d1cba3$53b6ed20$fb24c760$@ikuai8.com> MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT X-Mailer: Microsoft Outlook 16.0 Thread-Index: AQJe99kArK3KsIHacw8ZIlljXWrh2wJfxJUJAsEOhxQB8IlnGwFvUYusAeviuBKehfHa0A== Content-Language: zh-cn X-QQ-SENDSIZE: 520 X-QQ-Bgrelay: 1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Oh, I get it. I met the compile error when compile the kernel 3.10 on CentOS7 and fix it, then I find the seq_device of upstream is same. So I thought it should be fixed. OK. Let me compile the upstream codes on CentOS7 again. -----邮件原件----- 发件人: Takashi Iwai [mailto:tiwai@suse.de] 发送时间: 2016年6月21日 17:54 收件人: 高峰 抄送: alsa-devel@alsa-project.org; perex@perex.cz; linux-kernel@vger.kernel.org; gfree.wind@gmail.com 主题: Re: 答复: 答复: [PATCH 1/1] sound: Fix compile error of seq_device.c On Tue, 21 Jun 2016 11:35:39 +0200, 高峰 wrote: > > I have sent the new commit with the compile errors. > Is it ok now? > > BTW, I think the compile error is caused by that "subsys_initcall" statement losts the semicolon. Does this happen with the latest upstream kernel code at all...? Takashi > > -----邮件原件----- > 发件人: Takashi Iwai [mailto:tiwai@suse.de] > 发送时间: 2016年6月21日 17:20 > 收件人: 高峰 > 抄送: alsa-devel@alsa-project.org; perex@perex.cz; > linux-kernel@vger.kernel.org; gfree.wind@gmail.com > 主题: Re: 答复: [PATCH 1/1] sound: Fix compile error of seq_device.c > > On Tue, 21 Jun 2016 10:48:30 +0200, > 高峰 wrote: > > > > The lastest CentOS7 platform, and the gcc version is gcc version > > 4.8.5 > > 20150623 (Red Hat 4.8.5-4) (GCC). > > It could pass compilation after append the lost semicolon. > > > > from sound/core/seq/seq_device.c:39: > > include/linux/init.h:216:2: error: expected ‘,’ or ‘;’ before ‘static’ > > static exitcall_t __exitcall_##fn __exit_call = fn > > ^ > > include/linux/init.h:279:24: note: in expansion of macro ‘__exitcall’ > > #define module_exit(x) __exitcall(x); > > ^ > > sound/core/seq/seq_device.c:315:1: note: in expansion of macro > > ‘module_exit’ > > module_exit(alsa_seq_device_exit) > > ^ > > make[3]: *** [sound/core/seq/seq_device.o] Error 1 > > make[2]: *** [sound/core/seq] Error 2 > > make[1]: *** [sound/core] Error 2 > > make: *** [sound] Error 2 > > It's a RH specific issue. The upstream code has a different definition of module_init(), thus no such an error would occur. > > Note that I'm fine to apply the patch, it's a trivial change. > But you need to give the clear reason why to apply it. In this case, it's no fault of the upstream code. But if it would make someone's life a bit easier, it's OK to apply such a change. > > That being said, please resubmit the patch with a more explanation. > > > thanks, > > Takashi > > > > > -----邮件原件----- > > 发件人: Takashi Iwai [mailto:tiwai@suse.de] > > 发送时间: 2016年6月21日 16:45 > > 收件人: fgao@ikuai8.com > > 抄送: alsa-devel@alsa-project.org; perex@perex.cz; linux-kernel@vger.kernel. > > org; gfree.wind@gmail.com > > 主题: Re: [PATCH 1/1] sound: Fix compile error of seq_device.c > > > > On Tue, 21 Jun 2016 10:34:25 +0200, > > wrote: > > > > > > From: Gao Feng > > > > > > Signed-off-by: Gao Feng > > > > What compile error did you get? > > > > > > Takashi > > > > > --- > > > sound/core/seq/seq_device.c | 4 ++-- > > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > > > diff --git a/sound/core/seq/seq_device.c > > > b/sound/core/seq/seq_device.c index c4acf17..4e859e4 100644 > > > --- a/sound/core/seq/seq_device.c > > > +++ b/sound/core/seq/seq_device.c > > > @@ -311,5 +311,5 @@ static void __exit alsa_seq_device_exit(void) > > > bus_unregister(&snd_seq_bus_type); > > > } > > > > > > -subsys_initcall(alsa_seq_device_init) > > > -module_exit(alsa_seq_device_exit) > > > +subsys_initcall(alsa_seq_device_init); > > > +module_exit(alsa_seq_device_exit); > > > -- > > > 1.9.1 > > > > > > > > > > > > > > > > > > > > > > > >