From: Jingoo Han <jg1.han@samsung.com>
To: "'Vinod Koul'" <vinod.koul@intel.com>
Cc: "'Dan Williams'" <djbw@fb.com>,
linux-kernel@vger.kernel.org,
"'Simon Horman'" <horms@verge.net.au>,
"'Andy Shevchenko'" <andriy.shevchenko@linux.jf.intel.com>,
"'Fabio Estevam'" <fabio.estevam@freescale.com>,
"'Shawn Guo'" <shawn.guo@linaro.org>,
"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH RESEND] dma: sh: remove unnecessary platform_set_drvdata()
Date: Mon, 26 Aug 2013 09:32:05 +0900 [thread overview]
Message-ID: <001e01cea1f3$b0d5a780$1280f680$%han@samsung.com> (raw)
The driver core clears the driver data to NULL after device_release
or on probe failure. Thus, it is not needed to manually clear the
device driver data to NULL.
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Acked-by: Simon Horman <horms+renesas@verge.net.au>
---
drivers/dma/sh/shdmac.c | 3 ---
drivers/dma/sh/sudmac.c | 2 --
2 files changed, 5 deletions(-)
diff --git a/drivers/dma/sh/shdmac.c b/drivers/dma/sh/shdmac.c
index c7faded..282e93f 100755
--- a/drivers/dma/sh/shdmac.c
+++ b/drivers/dma/sh/shdmac.c
@@ -882,7 +882,6 @@ rst_err:
pm_runtime_put(&pdev->dev);
pm_runtime_disable(&pdev->dev);
- platform_set_drvdata(pdev, NULL);
shdma_cleanup(&shdev->shdma_dev);
eshdma:
synchronize_rcu();
@@ -911,8 +910,6 @@ static int sh_dmae_remove(struct platform_device *pdev)
sh_dmae_chan_remove(shdev);
shdma_cleanup(&shdev->shdma_dev);
- platform_set_drvdata(pdev, NULL);
-
synchronize_rcu();
return 0;
diff --git a/drivers/dma/sh/sudmac.c b/drivers/dma/sh/sudmac.c
index 3c7d2b8..bf85b8e 100755
--- a/drivers/dma/sh/sudmac.c
+++ b/drivers/dma/sh/sudmac.c
@@ -391,7 +391,6 @@ static int sudmac_probe(struct platform_device *pdev)
chan_probe_err:
sudmac_chan_remove(su_dev);
- platform_set_drvdata(pdev, NULL);
shdma_cleanup(&su_dev->shdma_dev);
return err;
@@ -405,7 +404,6 @@ static int sudmac_remove(struct platform_device *pdev)
dma_async_device_unregister(dma_dev);
sudmac_chan_remove(su_dev);
shdma_cleanup(&su_dev->shdma_dev);
- platform_set_drvdata(pdev, NULL);
return 0;
}
--
1.7.10.4
next reply other threads:[~2013-08-26 0:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-26 0:32 Jingoo Han [this message]
2013-08-26 8:24 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='001e01cea1f3$b0d5a780$1280f680$%han@samsung.com' \
--to=jg1.han@samsung.com \
--cc=andriy.shevchenko@linux.jf.intel.com \
--cc=djbw@fb.com \
--cc=fabio.estevam@freescale.com \
--cc=horms@verge.net.au \
--cc=linux-kernel@vger.kernel.org \
--cc=shawn.guo@linaro.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®