From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C018C205E15 for ; Thu, 11 Apr 2024 20:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712868355; cv=none; b=RpnbkOMFw0swfv8+PUFbTPFd72zhcyL5ijOoqqASgVuQALXpthak4JeKqIWH4DzrZP1dNiSVmY3svdbVA0Yim16p18CrY4ORM+GoWEr0mt1khTMyctzD1TBXp9gpuq2EJt3NXz6SRXbTfMNUVptNN0ELqePyKRhoZLnJdKGGPf0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1712868355; c=relaxed/simple; bh=//ZjAiaXc2P8treOFUP0BwgmcWVeopDlRI0E5DLLuMc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Lhsqxj6n0KQwXRfPNCaY0l5NqhsuiAnrnHzpm1z7LAGaeo/tzmxppWLnRk1Wo5Ze3oRr3lKE+xUOnFWTIghw2M9bk2dzWbS5zuu9vHl2x/Ns3tMd8O09B871L7uZIgMwQa/yglaBYUGT11ENwqMR/mPs0yU5wBrxY/bhLmHSI4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=f/w+zXY8; arc=none smtp.client-ip=209.85.166.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="f/w+zXY8" Received: by mail-io1-f43.google.com with SMTP id ca18e2360f4ac-7d6112ba6baso4802939f.1 for ; Thu, 11 Apr 2024 13:45:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1712868353; x=1713473153; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Fo4GEr311EYbdOzDjeChQAAjd+hDg5qPX6VqqIVrpLA=; b=f/w+zXY8TL/Mf0YsoDFELJdPOkX5l322B1XedX1zWJqdssy/LUUDGjnB2yq+gQ3I/M 3V0FvRCj3Wr6Nd/cRZ/f7Y9cWRw4laHblLSMYi2OiVvDQ9GBSF9kCbbI1b+5/H3vMH9i IXC7NgxrSRHQWDmKy8rybQ3p6TqQD+IrjPvvA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712868353; x=1713473153; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Fo4GEr311EYbdOzDjeChQAAjd+hDg5qPX6VqqIVrpLA=; b=xArzqwbHoJbG2ypaETaATSniK1EqlDMtuXwgyjDhnippTuynBhMo3H5hdwdPPDH2br vX1Dds0sfo5ZZpaxGIwaQIFGuh5SdsuZeLj12A1fFqx6Jz/o1lT5MPdDVlBdkjwOuR7V mb8Zyp4RuhlY3bTIUqHSa2n7vvR8F7evEmy5WpaDl1C13tkGd5DsE0KRG/cgUEZBTwb6 dsFPdiP2oZ8MEGp/TXi/ZuiF0j0gKLOzluXYJN/fvPvI33O/YlIo9f1+1oytQ36AFYHJ XTdPZs6XOuDyiO6xhuMfLIJujfcYUMkXSzo6qqobf54OZOvgYaLyQMaGdbTwxh7cKGBR +hkQ== X-Forwarded-Encrypted: i=1; AJvYcCXC6udN4xAU3vFEIonHtxg+OVPmjIG/mkdmNRxXl2yqsoTNCCkWEgGRU5oPnoghtOwrw6dtb6tf81/aJhb4izgEEJJwzdw7kZPFMPT1 X-Gm-Message-State: AOJu0YwSn8u30Ct071srDoBolYVrqIyLN2egKEBROWIfB88ycprWJMOS xwOeZPJSnceMommjVPqxqQzNRBZE4Xm6ShIxyKvfBgVnw+xGHomAvtB9j0h/ZrA= X-Google-Smtp-Source: AGHT+IH9OX1Moo1mlEB4y0c5wMRaDjl4BfEDLf4mplpYTFEyOf+192EOakCyOtoz5nCIBbH3JHDNnQ== X-Received: by 2002:a6b:cd08:0:b0:7d5:fe3e:90ff with SMTP id d8-20020a6bcd08000000b007d5fe3e90ffmr957446iog.0.1712868351549; Thu, 11 Apr 2024 13:45:51 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id t5-20020a6b5f05000000b007d5ddfda6a8sm647641iob.7.2024.04.11.13.45.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 Apr 2024 13:45:51 -0700 (PDT) Message-ID: <001f99f4-9463-451d-ac16-0cda91e37e67@linuxfoundation.org> Date: Thu, 11 Apr 2024 14:45:49 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] selftests: timers: Fix posix_timers ksft_print_msg warning To: John Stultz , LKML Cc: Shuah Khan , Anna-Maria Behnsen , Frederic Weisbecker , Thomas Gleixner , Stephen Boyd , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Oleg Nesterov , Andrew Morton , Edward Liaw , Carlos Llamas , kernel-team@android.com, linux-kselftest@vger.kernel.org, Shuah Khan References: <20240410232637.4135564-1-jstultz@google.com> Content-Language: en-US From: Shuah Khan In-Reply-To: <20240410232637.4135564-1-jstultz@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 4/10/24 17:26, John Stultz wrote: > After commit 6d029c25b71f ("selftests/timers/posix_timers: Tried to apply this for linux-kselftest next with Nathan's patch. I can't find this commit in Linux 6.9-rc3? Is this is timers tree? > Reimplement check_timer_distribution()") I started seeing the > following warning building with an older gcc: > > posix_timers.c:250:2: warning: format not a string literal and no format arguments [-Wformat-security] > 250 | ksft_print_msg(errmsg); > | ^~~~~~~~~~~~~~ > > Fix this up by changing it to ksft_print_msg("%s", errmsg) > > Cc: Shuah Khan > Cc: Anna-Maria Behnsen > Cc: Frederic Weisbecker > Cc: Thomas Gleixner > Cc: Stephen Boyd > Cc: Nathan Chancellor > Cc: Nick Desaulniers > Cc: Bill Wendling > Cc: Justin Stitt > Cc: Oleg Nesterov > Cc: Andrew Morton > Cc: Edward Liaw > Cc: Carlos Llamas > Cc: kernel-team@android.com > Cc: linux-kselftest@vger.kernel.org > Fixes: 6d029c25b71f ("selftests/timers/posix_timers: Reimplement check_timer_distribution()") > Signed-off-by: John Stultz > --- > tools/testing/selftests/timers/posix_timers.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/timers/posix_timers.c b/tools/testing/selftests/timers/posix_timers.c > index d86a0e00711e..348f47176e0a 100644 > --- a/tools/testing/selftests/timers/posix_timers.c > +++ b/tools/testing/selftests/timers/posix_timers.c > @@ -247,7 +247,7 @@ static int check_timer_distribution(void) > ksft_test_result_skip("check signal distribution (old kernel)\n"); > return 0; > err: > - ksft_print_msg(errmsg); > + ksft_print_msg("%s", errmsg); > return -1; > } > thanks, -- Shuah