From: Marek Szyprowski <m.szyprowski@samsung.com>
To: "'Alan Cox'" <alan@lxorguk.ukuu.org.uk>
Cc: "'David Brownell'" <david-b@pacbell.net>,
"'Alan Stern'" <stern@rowland.harvard.edu>,
"'Peter Korsgaard'" <jacmet@sunsite.dk>,
"'USB list'" <linux-usb@vger.kernel.org>,
"'Kernel development list'" <linux-kernel@vger.kernel.org>,
kyungmin.park@samsung.com
Subject: RE: PROBLEM: kernel oops with g_serial USB gadget on 2.6.30
Date: Tue, 23 Jun 2009 11:33:35 +0200 [thread overview]
Message-ID: <002101c9f3e5$b4dc5a10$1e950e30$%szyprowski@samsung.com> (raw)
In-Reply-To: <20090623102129.3b58adbf@lxorguk.ukuu.org.uk>
Hello,
On Tuesday, June 23, 2009 11:21 AM, Alan Cox wrote:
> > that g_serial driver interacts with tty layer in that packet_done
> callback,
> > so this is the source of the problems. I noticed that some other UDC
> > drivers also does all its job from an interrupt, so they also might
> be
> > affected. How this bug should be properly resolved?
>
> Either by not setting ->low_latency or by running the data paths from a
> non IRQ context.
>
> Basically: don't set tty->low_latency if you are handling the
> processing
> from the IRQ path. The only case low_latency is useful is handling data
> from a non-IRQ path where you have latency concerns for tx/rx
> switching.
I know that, but I wonder how this should be handled in g_serial gadget
driver, which might be working on top of both types of low level
drivers (doing callback from irq or tasklet).
Are there any drawbacks of disabling low_latency mode if callbacks are
done from tasklet not from interrupt? If no then the low latency mode
should be disabled in g_serial driver.
Best regards
--
Marek Szyprowski
Samsung Poland R&D Center
next prev parent reply other threads:[~2009-06-23 9:34 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-22 12:04 Marek Szyprowski
2009-06-22 12:33 ` Peter Korsgaard
2009-06-22 13:55 ` Marek Szyprowski
2009-06-22 14:06 ` Peter Korsgaard
2009-06-22 14:06 ` Alan Stern
2009-06-22 14:12 ` Marek Szyprowski
2009-06-22 15:02 ` Alan Stern
2009-06-23 3:26 ` David Brownell
2009-06-23 6:41 ` Marek Szyprowski
2009-06-23 7:22 ` David Brownell
2009-06-23 8:37 ` Marek Szyprowski
2009-06-23 9:21 ` Alan Cox
2009-06-23 9:33 ` Marek Szyprowski [this message]
2009-06-23 9:54 ` Alan Cox
2009-06-23 15:00 ` Marek Szyprowski
2009-06-23 16:47 ` David Brownell
2009-06-23 16:52 ` David Brownell
2009-06-24 7:07 ` Marek Szyprowski
2009-06-24 8:42 ` Alan Cox
2009-06-24 8:54 ` David Brownell
2009-06-24 8:49 ` David Brownell
2009-06-24 10:30 ` Marek Szyprowski
2009-06-24 23:43 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002101c9f3e5$b4dc5a10$1e950e30$%szyprowski@samsung.com' \
--to=m.szyprowski@samsung.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=david-b@pacbell.net \
--cc=jacmet@sunsite.dk \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®