From: Boojin Kim <boojin.kim@samsung.com>
To: "'Russell King - ARM Linux'" <linux@arm.linux.org.uk>
Cc: "'Catalin Marinas'" <Catalin.Marinas@arm.com>,
"'Kukjin Kim'" <kgene.kim@samsung.com>,
"'Will Deacon'" <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: RE: [PATCH 1/3] ARM: MM: Add the workaround of Errata 774769
Date: Mon, 10 Dec 2012 10:19:03 +0900 [thread overview]
Message-ID: <002101cdd674$57884070$0698c150$%kim@samsung.com> (raw)
In-Reply-To: <20121210000825.GH14363@n2100.arm.linux.org.uk>
Russell King - ARM Linux wrote:
> > -3: mov r10, #0
> > + /* Cortex-A15 Errata */
> > +3: ldr r10, =0x00000c0f @ Cortex-A15 primary part number
> > + teq r0, r10
> > + bne 4f
> > +#ifdef CONFIG_ARM_ERRATA_774769
>
> There's not much point testing for the part number of the work-around isn't
> enabled.
The errata 773022 on second patch series is also required to checking the part number.
In my opinion, the testing for Cortex-A15 primary part number is required
before working the work-around to support several A15 errata.
>
> > + teq r6, #0x4 @ present in r0p4
> > + mrceq p15, 0, r10, c1, c0, 1 @ read aux control register
>
> tsteq r10, #1 << 15
>
> to avoid writing to the aux control register if the errata has already been
> applied.
Do you mean "tsteq r10, #1 << 25" ?
If yes, it needs to branch and will make a little complicated
And, I think maybe this function could be the first step to configure this erratum.
Thanks for your review
>
> > + orreq r10, r10, #1 << 25 @ set bit #25
> > + mcreq p15, 0, r10, c1, c0, 1 @ write aux control register
> > +#endif
> > +
> > +4: mov r10, #0
> > mcr p15, 0, r10, c7, c5, 0 @ I+BTB cache invalidate
> > dsb
> > #ifdef CONFIG_MMU
> > --
> > 1.7.5.4
> >
> >
> >
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2012-12-10 1:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-09 23:58 Boojin Kim
2012-12-10 0:08 ` Russell King - ARM Linux
2012-12-10 1:19 ` Boojin Kim [this message]
2012-12-10 14:10 ` Santosh Shilimkar
2012-12-10 14:16 ` Russell King - ARM Linux
2012-12-10 14:20 ` Santosh Shilimkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='002101cdd674$57884070$0698c150$%kim@samsung.com' \
--to=boojin.kim@samsung.com \
--cc=Catalin.Marinas@arm.com \
--cc=kgene.kim@samsung.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®