mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jingoo Han <jg1.han@samsung.com>
To: "'Greg Kroah-Hartman'" <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org,
	"'Florian Fainelli'" <f.fainelli@gmail.com>,
	"'Thierry Reding'" <thierry.reding@gmail.com>,
	"'Joe Perches'" <joe@perches.com>,
	"'Dan Carpenter'" <dan.carpenter@oracle.com>,
	"'Jingoo Han'" <jg1.han@samsung.com>
Subject: [PATCH] lib: devres: Mark devm_request_and_ioremap() as deprecated
Date: Wed, 14 May 2014 14:38:11 +0900	[thread overview]
Message-ID: <002301cf6f36$b1d11320$15733960$%han@samsung.com> (raw)

devm_request_and_ioremap() was obsoleted by devm_ioremap_resource().
(7509657 "lib: devres: Introduce devm_ioremap_resource()") So,
let's mark it as deprecated in order to stop using it.

Suggested-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Cc: Thierry Reding <thierry.reding@gmail.com>
---
 include/linux/device.h |    4 ++--
 lib/devres.c           |    1 +
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/include/linux/device.h b/include/linux/device.h
index 67f003a..769c86b 100644
--- a/include/linux/device.h
+++ b/include/linux/device.h
@@ -627,8 +627,8 @@ extern void *devm_kmemdup(struct device *dev, const void *src, size_t len,
 			  gfp_t gfp);
 
 void __iomem *devm_ioremap_resource(struct device *dev, struct resource *res);
-void __iomem *devm_request_and_ioremap(struct device *dev,
-			struct resource *res);
+void __deprecated __iomem *devm_request_and_ioremap(struct device *dev,
+						    struct resource *res);
 
 /* allows to add/remove a custom action to devres stack */
 int devm_add_action(struct device *dev, void (*action)(void *), void *data);
diff --git a/lib/devres.c b/lib/devres.c
index 2f16c13..44c7cb2 100644
--- a/lib/devres.c
+++ b/lib/devres.c
@@ -147,6 +147,7 @@ EXPORT_SYMBOL(devm_ioremap_resource);
  * @dev: Generic device to handle the resource for
  * @res: resource to be handled
  *
+ * This is deprecated, please use devm_ioremap_resource() instead.
  * Takes all necessary steps to ioremap a mem resource. Uses managed device, so
  * everything is undone on driver detach. Checks arguments, so you can feed
  * it the result from e.g. platform_get_resource() directly. Returns the
-- 
1.7.10.4



             reply	other threads:[~2014-05-14  5:38 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-14  5:38 Jingoo Han [this message]
2014-05-14 14:30 ` 'Greg Kroah-Hartman'

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='002301cf6f36$b1d11320$15733960$%han@samsung.com' \
    --to=jg1.han@samsung.com \
    --cc=dan.carpenter@oracle.com \
    --cc=f.fainelli@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=thierry.reding@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®