From: Stephan Mueller <smueller@chronox.de>
To: Meng Yu <yumeng18@huawei.com>,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: linux-crypto@vger.kernel.org, xuzaibo@huawei.com,
wangzhou1@hisilicon.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 5/5] crypto: hisilicon/hpre - add 'CURVE25519' algorithm
Date: Fri, 11 Dec 2020 15:14:33 +0100 [thread overview]
Message-ID: <00235d6da9beddd365217aeb8add986c615762bc.camel@chronox.de> (raw)
In-Reply-To: <1607668234-46130-6-git-send-email-yumeng18@huawei.com>
Am Freitag, den 11.12.2020, 14:30 +0800 schrieb Meng Yu:
>
> +/* curve25519 */
> +static u64 curve25519_g_x[] = { 0x0000000000000009, 0x0000000000000000,
> + 0x0000000000000000, 0x0000000000000000 };
> +static u64 curve25519_p[] = { 0xffffffffffffffed, 0xffffffffffffffff,
> + 0xffffffffffffffff, 0x7fffffffffffffff };
> +static u64 curve25519_a[] = { 0x000000000001DB41, 0x0000000000000000,
> + 0x0000000000000000, 0x0000000000000000 };
> +static const struct ecc_curve ecc_25519 = {
> + .name = "curve25519",
> + .g = {
> + .x = curve25519_g_x,
> + .ndigits = 4,
> + },
> + .p = curve25519_p,
> + .a = curve25519_a,
> +};
With this definition, I am not sure whether ecc_is_pubkey_valid_partial would
work correctly. At least it *seems* that there would be a NULL-pointer
dereference in vli_add with the undefined .b value. Did you test and can you
confirm?
Thanks
Stephan
next prev parent reply other threads:[~2020-12-12 1:00 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-11 6:30 [PATCH v4 0/5] add ECDH and CURVE25519 algorithms support for Kunpeng 930 Meng Yu
2020-12-11 6:30 ` [PATCH v4 1/5] crypto: hisilicon/hpre - add some updates to adapt to " Meng Yu
2020-12-11 6:30 ` [PATCH v4 2/5] crypto: hisilicon/hpre - add algorithm type Meng Yu
2020-12-11 6:30 ` [PATCH v4 3/5] crypto: expose elliptic curve parameters as Crypto APIs Meng Yu
2020-12-11 13:13 ` Vitaly Chikunov
[not found] ` <75a25392-464d-b76e-ba92-4287e24acbf7@huawei.com>
2020-12-16 2:32 ` Fwd: " yumeng
2020-12-11 6:30 ` [PATCH v4 4/5] crypto: hisilicon/hpre - add 'ECDH' algorithm Meng Yu
2020-12-11 14:08 ` Stephan Mueller
[not found] ` <3903e2e8-165f-51b5-056c-24b8ce52e842@huawei.com>
2020-12-16 2:39 ` yumeng
2020-12-16 20:10 ` Stephan Mueller
2020-12-17 3:07 ` yumeng
2020-12-19 21:25 ` Stephan Müller
2020-12-11 6:30 ` [PATCH v4 5/5] crypto: hisilicon/hpre - add 'CURVE25519' algorithm Meng Yu
2020-12-11 14:14 ` Stephan Mueller [this message]
[not found] ` <e6bf72e0-38cd-a17e-ecae-e6fabdb313eb@huawei.com>
2020-12-16 2:45 ` yumeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=00235d6da9beddd365217aeb8add986c615762bc.camel@chronox.de \
--to=smueller@chronox.de \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
--cc=yumeng18@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®